[PATCH 1/2] perf Makefile: fix GNU-only grep usage

[PATCH 1/2] perf Makefile: fix GNU-only grep usage

[John Spencer]

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: 0001-perf-Makefile-fix-GNU-only-grep-usage.patch --]
[-- Type: text/plain, Size: 836 bytes --]

From efa79d5b7bc750369332a3a34442573af7b1b35c Mon Sep 17 00:00:00 2001
From: John Spencer <maillist-linux@barfooze.de>
Date: Mon, 25 Aug 2014 21:24:30 +0200
Subject: [PATCH 1/2] perf Makefile: fix GNU-only grep usage

this makes it work with non-GNU grep's as well.

Signed-off-by: John Spencer <maillist-linux@barfooze.de>

---
 tools/perf/config/utilities.mak | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/config/utilities.mak b/tools/perf/config/utilities.mak
index 4d985e0..7076a62 100644
--- a/tools/perf/config/utilities.mak
+++ b/tools/perf/config/utilities.mak
@@ -132,7 +132,7 @@ endef
 #
 # Usage: bool-value = $(call is-absolute,path)
 #
-is-absolute = $(shell echo $(shell-sq) | grep ^/ -q && echo y)
+is-absolute = $(shell echo $(shell-sq) | grep -q ^/ && echo y)
 
 # lookup
 #
-- 
1.8.4

Re: [PATCH 1/2] perf Makefile: fix GNU-only grep usage

[Namhyung Kim]

Hi John,

You'd better to CC the lkml (linux-kernel@vger.kernel.org) for the perf
patches to get reviewed by other developers.  I'm copying to the list
this time.


On Mon, 25 Aug 2014 21:36:32 +0200, John Spencer wrote:
> From efa79d5b7bc750369332a3a34442573af7b1b35c Mon Sep 17 00:00:00 2001
> From: John Spencer <maillist-linux@barfooze.de>
> Date: Mon, 25 Aug 2014 21:24:30 +0200
> Subject: [PATCH 1/2] perf Makefile: fix GNU-only grep usage
>
> this makes it work with non-GNU grep's as well.
>
> Signed-off-by: John Spencer <maillist-linux@barfooze.de>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


>
> ---
>  tools/perf/config/utilities.mak | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/config/utilities.mak b/tools/perf/config/utilities.mak
> index 4d985e0..7076a62 100644
> --- a/tools/perf/config/utilities.mak
> +++ b/tools/perf/config/utilities.mak
> @@ -132,7 +132,7 @@ endef
>  #
>  # Usage: bool-value = $(call is-absolute,path)
>  #
> -is-absolute = $(shell echo $(shell-sq) | grep ^/ -q && echo y)
> +is-absolute = $(shell echo $(shell-sq) | grep -q ^/ && echo y)
>  
>  # lookup
>  #