Re: [PATCH] powerpc: Fix build error for vga16fb

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]

On 19/08/14 00:28, Geert Uytterhoeven wrote:
> Hi Pranith,
> 
> On Mon, Aug 18, 2014 at 11:13 PM, Pranith Kumar <bobby.prani@gmail.com> wrote:
>> Fix a build error caused by
>>
>> drivers/built-in.o: In function `vga16fb_probe':
>> drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base'
>> drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base'
>> make: *** [vmlinux] Error 1
>>
>> This is occuring as vgacon_remap_base is exported only when
>> CONFIG_VGA_CONSOLE=y. Fix the error by making FB_VBA16 depend on
>> CONFIG_VGA_CONSOLE.
>>
>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> CC: Andrew Morton <akpm@linux-foundation.org>
>> ---
>>  drivers/video/fbdev/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
>> index e911b9c..09df564 100644
>> --- a/drivers/video/fbdev/Kconfig
>> +++ b/drivers/video/fbdev/Kconfig
>> @@ -547,7 +547,7 @@ config FB_IMSTT
>>
>>  config FB_VGA16
>>         tristate "VGA 16-color graphics support"
>> -       depends on FB && (X86 || PPC)
>> +       depends on FB && (X86 || PPC) && CONFIG_VGA_CONSOLE
> 
> The dependency on CONFIG_VGA_CONSOLE only exists on PPC, not on x86.
> So this is not correct.
> 
> Digging a bit deeper: There's no code left in arch/powerpc that actually
> sets vgacon_remap_base, so it's not gonna work anyway.
> It seems vga16 support on PPC died with the removal of arch/ppc/.

Hmm, so I wonder if vga16fb is supposed to work on ppc or not. Pranith's
follow-up patch disables vga16fb for PPC, which obviously fixes the
compilation problem, but is that really a correct fix?

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]