* [PATCH v2] ppc: Fix build error with CONFIG_PCI=n @ 2014-08-18 21:13 ` Pranith Kumar 0 siblings, 0 replies; 10+ messages in thread From: Pranith Kumar @ 2014-08-18 21:13 UTC (permalink / raw) To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman, open list:LINUX FOR POWERPC..., open list Cc: Andrew Morton, geert Fix ppc 32 build failure as reported here: http://kisskb.ellerman.id.au/kisskb/buildresult/11663513/ The error is as follows: arch/powerpc/include/asm/floppy.h:142:20: error: 'isa_bridge_pcidev' undeclared (first use in this function) This is happening since floppy.o is enabled by BLK_DEV_FD which depends on ARCH_MAY_HAVE_PC_FDC which is in-turn enabled if PPC_PSERIES=n. The following commit changes the dependency so that ARCH_MAY_HAVE_PC_FDC is dependent exclusively on PCI since otherwise it will not compile. Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> CC: Andrew Morton <akpm@linux-foundation.org> --- arch/powerpc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index a577609f..9c1aa77 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -182,7 +182,7 @@ config SCHED_OMIT_FRAME_POINTER config ARCH_MAY_HAVE_PC_FDC bool - default !PPC_PSERIES || PCI + default PCI config PPC_OF def_bool y -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2] ppc: Fix build error with CONFIG_PCI=n @ 2014-08-18 21:13 ` Pranith Kumar 0 siblings, 0 replies; 10+ messages in thread From: Pranith Kumar @ 2014-08-18 21:13 UTC (permalink / raw) To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman, open list:LINUX FOR POWERPC..., open list Cc: geert, Andrew Morton Fix ppc 32 build failure as reported here: http://kisskb.ellerman.id.au/kisskb/buildresult/11663513/ The error is as follows: arch/powerpc/include/asm/floppy.h:142:20: error: 'isa_bridge_pcidev' undeclared (first use in this function) This is happening since floppy.o is enabled by BLK_DEV_FD which depends on ARCH_MAY_HAVE_PC_FDC which is in-turn enabled if PPC_PSERIES=n. The following commit changes the dependency so that ARCH_MAY_HAVE_PC_FDC is dependent exclusively on PCI since otherwise it will not compile. Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> CC: Andrew Morton <akpm@linux-foundation.org> --- arch/powerpc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index a577609f..9c1aa77 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -182,7 +182,7 @@ config SCHED_OMIT_FRAME_POINTER config ARCH_MAY_HAVE_PC_FDC bool - default !PPC_PSERIES || PCI + default PCI config PPC_OF def_bool y -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] powerpc: Fix build error for vga16fb 2014-08-18 21:13 ` Pranith Kumar @ 2014-08-18 21:13 ` Pranith Kumar -1 siblings, 0 replies; 10+ messages in thread From: Pranith Kumar @ 2014-08-18 21:13 UTC (permalink / raw) To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, Arnd Bergmann, Peter Griffin, Alexander Shiyan, Jean Delvare, Kukjin Kim, Mark Brown, open list:FRAMEBUFFER LAYER, open list Cc: geert, Andrew Morton Fix a build error caused by drivers/built-in.o: In function `vga16fb_probe': drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base' drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base' make: *** [vmlinux] Error 1 This is occuring as vgacon_remap_base is exported only when CONFIG_VGA_CONSOLE=y. Fix the error by making FB_VBA16 depend on CONFIG_VGA_CONSOLE. Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> CC: Andrew Morton <akpm@linux-foundation.org> --- drivers/video/fbdev/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index e911b9c..09df564 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -547,7 +547,7 @@ config FB_IMSTT config FB_VGA16 tristate "VGA 16-color graphics support" - depends on FB && (X86 || PPC) + depends on FB && (X86 || PPC) && CONFIG_VGA_CONSOLE select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] powerpc: Fix build error for vga16fb @ 2014-08-18 21:13 ` Pranith Kumar 0 siblings, 0 replies; 10+ messages in thread From: Pranith Kumar @ 2014-08-18 21:13 UTC (permalink / raw) To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, Arnd Bergmann, Peter Griffin, Alexander Shiyan, Jean Delvare, Kukjin Kim, Mark Brown, open list:FRAMEBUFFER LAYER, open list Cc: geert, Andrew Morton Fix a build error caused by drivers/built-in.o: In function `vga16fb_probe': drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base' drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base' make: *** [vmlinux] Error 1 This is occuring as vgacon_remap_base is exported only when CONFIG_VGA_CONSOLE=y. Fix the error by making FB_VBA16 depend on CONFIG_VGA_CONSOLE. Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> CC: Andrew Morton <akpm@linux-foundation.org> --- drivers/video/fbdev/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index e911b9c..09df564 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -547,7 +547,7 @@ config FB_IMSTT config FB_VGA16 tristate "VGA 16-color graphics support" - depends on FB && (X86 || PPC) + depends on FB && (X86 || PPC) && CONFIG_VGA_CONSOLE select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: Fix build error for vga16fb 2014-08-18 21:13 ` Pranith Kumar @ 2014-08-18 21:28 ` Geert Uytterhoeven -1 siblings, 0 replies; 10+ messages in thread From: Geert Uytterhoeven @ 2014-08-18 21:28 UTC (permalink / raw) To: Pranith Kumar Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, Arnd Bergmann, Peter Griffin, Alexander Shiyan, Jean Delvare, Kukjin Kim, Mark Brown, open list:FRAMEBUFFER LAYER, open list, Andrew Morton Hi Pranith, On Mon, Aug 18, 2014 at 11:13 PM, Pranith Kumar <bobby.prani@gmail.com> wrote: > Fix a build error caused by > > drivers/built-in.o: In function `vga16fb_probe': > drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base' > drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base' > make: *** [vmlinux] Error 1 > > This is occuring as vgacon_remap_base is exported only when > CONFIG_VGA_CONSOLE=y. Fix the error by making FB_VBA16 depend on > CONFIG_VGA_CONSOLE. > > Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > CC: Andrew Morton <akpm@linux-foundation.org> > --- > drivers/video/fbdev/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index e911b9c..09df564 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -547,7 +547,7 @@ config FB_IMSTT > > config FB_VGA16 > tristate "VGA 16-color graphics support" > - depends on FB && (X86 || PPC) > + depends on FB && (X86 || PPC) && CONFIG_VGA_CONSOLE The dependency on CONFIG_VGA_CONSOLE only exists on PPC, not on x86. So this is not correct. Digging a bit deeper: There's no code left in arch/powerpc that actually sets vgacon_remap_base, so it's not gonna work anyway. It seems vga16 support on PPC died with the removal of arch/ppc/. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: Fix build error for vga16fb @ 2014-08-18 21:28 ` Geert Uytterhoeven 0 siblings, 0 replies; 10+ messages in thread From: Geert Uytterhoeven @ 2014-08-18 21:28 UTC (permalink / raw) To: Pranith Kumar Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, Arnd Bergmann, Peter Griffin, Alexander Shiyan, Jean Delvare, Kukjin Kim, Mark Brown, open list:FRAMEBUFFER LAYER, open list, Andrew Morton Hi Pranith, On Mon, Aug 18, 2014 at 11:13 PM, Pranith Kumar <bobby.prani@gmail.com> wrote: > Fix a build error caused by > > drivers/built-in.o: In function `vga16fb_probe': > drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base' > drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base' > make: *** [vmlinux] Error 1 > > This is occuring as vgacon_remap_base is exported only when > CONFIG_VGA_CONSOLE=y. Fix the error by making FB_VBA16 depend on > CONFIG_VGA_CONSOLE. > > Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > CC: Andrew Morton <akpm@linux-foundation.org> > --- > drivers/video/fbdev/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index e911b9c..09df564 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -547,7 +547,7 @@ config FB_IMSTT > > config FB_VGA16 > tristate "VGA 16-color graphics support" > - depends on FB && (X86 || PPC) > + depends on FB && (X86 || PPC) && CONFIG_VGA_CONSOLE The dependency on CONFIG_VGA_CONSOLE only exists on PPC, not on x86. So this is not correct. Digging a bit deeper: There's no code left in arch/powerpc that actually sets vgacon_remap_base, so it's not gonna work anyway. It seems vga16 support on PPC died with the removal of arch/ppc/. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: Fix build error for vga16fb 2014-08-18 21:28 ` Geert Uytterhoeven @ 2014-08-18 21:34 ` Pranith Kumar -1 siblings, 0 replies; 10+ messages in thread From: Pranith Kumar @ 2014-08-18 21:34 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, Arnd Bergmann, Peter Griffin, Alexander Shiyan, Jean Delvare, Kukjin Kim, Mark Brown, open list:FRAMEBUFFER LAYER, open list, Andrew Morton On Mon, Aug 18, 2014 at 5:28 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Digging a bit deeper: There's no code left in arch/powerpc that actually > sets vgacon_remap_base, so it's not gonna work anyway. > It seems vga16 support on PPC died with the removal of arch/ppc/. OK. I will remove the dependency on PPC for vga16fb. -- Pranith ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: Fix build error for vga16fb @ 2014-08-18 21:34 ` Pranith Kumar 0 siblings, 0 replies; 10+ messages in thread From: Pranith Kumar @ 2014-08-18 21:34 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, Arnd Bergmann, Peter Griffin, Alexander Shiyan, Jean Delvare, Kukjin Kim, Mark Brown, open list:FRAMEBUFFER LAYER, open list, Andrew Morton On Mon, Aug 18, 2014 at 5:28 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Digging a bit deeper: There's no code left in arch/powerpc that actually > sets vgacon_remap_base, so it's not gonna work anyway. > It seems vga16 support on PPC died with the removal of arch/ppc/. OK. I will remove the dependency on PPC for vga16fb. -- Pranith ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: Fix build error for vga16fb 2014-08-18 21:28 ` Geert Uytterhoeven @ 2014-08-26 10:02 ` Tomi Valkeinen -1 siblings, 0 replies; 10+ messages in thread From: Tomi Valkeinen @ 2014-08-26 10:02 UTC (permalink / raw) To: Geert Uytterhoeven, Pranith Kumar, Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman Cc: Jean-Christophe Plagniol-Villard, Arnd Bergmann, Peter Griffin, Alexander Shiyan, Jean Delvare, Kukjin Kim, Mark Brown, FRAMEBUFFER LAYER, open list, Andrew Morton [-- Attachment #1: Type: text/plain, Size: 1801 bytes --] On 19/08/14 00:28, Geert Uytterhoeven wrote: > Hi Pranith, > > On Mon, Aug 18, 2014 at 11:13 PM, Pranith Kumar <bobby.prani@gmail.com> wrote: >> Fix a build error caused by >> >> drivers/built-in.o: In function `vga16fb_probe': >> drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base' >> drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base' >> make: *** [vmlinux] Error 1 >> >> This is occuring as vgacon_remap_base is exported only when >> CONFIG_VGA_CONSOLE=y. Fix the error by making FB_VBA16 depend on >> CONFIG_VGA_CONSOLE. >> >> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> >> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> >> CC: Andrew Morton <akpm@linux-foundation.org> >> --- >> drivers/video/fbdev/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig >> index e911b9c..09df564 100644 >> --- a/drivers/video/fbdev/Kconfig >> +++ b/drivers/video/fbdev/Kconfig >> @@ -547,7 +547,7 @@ config FB_IMSTT >> >> config FB_VGA16 >> tristate "VGA 16-color graphics support" >> - depends on FB && (X86 || PPC) >> + depends on FB && (X86 || PPC) && CONFIG_VGA_CONSOLE > > The dependency on CONFIG_VGA_CONSOLE only exists on PPC, not on x86. > So this is not correct. > > Digging a bit deeper: There's no code left in arch/powerpc that actually > sets vgacon_remap_base, so it's not gonna work anyway. > It seems vga16 support on PPC died with the removal of arch/ppc/. Hmm, so I wonder if vga16fb is supposed to work on ppc or not. Pranith's follow-up patch disables vga16fb for PPC, which obviously fixes the compilation problem, but is that really a correct fix? Tomi [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: Fix build error for vga16fb @ 2014-08-26 10:02 ` Tomi Valkeinen 0 siblings, 0 replies; 10+ messages in thread From: Tomi Valkeinen @ 2014-08-26 10:02 UTC (permalink / raw) To: Geert Uytterhoeven, Pranith Kumar, Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman Cc: Jean-Christophe Plagniol-Villard, Arnd Bergmann, Peter Griffin, Alexander Shiyan, Jean Delvare, Kukjin Kim, Mark Brown, FRAMEBUFFER LAYER, open list, Andrew Morton [-- Attachment #1: Type: text/plain, Size: 1801 bytes --] On 19/08/14 00:28, Geert Uytterhoeven wrote: > Hi Pranith, > > On Mon, Aug 18, 2014 at 11:13 PM, Pranith Kumar <bobby.prani@gmail.com> wrote: >> Fix a build error caused by >> >> drivers/built-in.o: In function `vga16fb_probe': >> drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base' >> drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base' >> make: *** [vmlinux] Error 1 >> >> This is occuring as vgacon_remap_base is exported only when >> CONFIG_VGA_CONSOLE=y. Fix the error by making FB_VBA16 depend on >> CONFIG_VGA_CONSOLE. >> >> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> >> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> >> CC: Andrew Morton <akpm@linux-foundation.org> >> --- >> drivers/video/fbdev/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig >> index e911b9c..09df564 100644 >> --- a/drivers/video/fbdev/Kconfig >> +++ b/drivers/video/fbdev/Kconfig >> @@ -547,7 +547,7 @@ config FB_IMSTT >> >> config FB_VGA16 >> tristate "VGA 16-color graphics support" >> - depends on FB && (X86 || PPC) >> + depends on FB && (X86 || PPC) && CONFIG_VGA_CONSOLE > > The dependency on CONFIG_VGA_CONSOLE only exists on PPC, not on x86. > So this is not correct. > > Digging a bit deeper: There's no code left in arch/powerpc that actually > sets vgacon_remap_base, so it's not gonna work anyway. > It seems vga16 support on PPC died with the removal of arch/ppc/. Hmm, so I wonder if vga16fb is supposed to work on ppc or not. Pranith's follow-up patch disables vga16fb for PPC, which obviously fixes the compilation problem, but is that really a correct fix? Tomi [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-08-26 10:03 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-08-18 21:13 [PATCH v2] ppc: Fix build error with CONFIG_PCI=n Pranith Kumar 2014-08-18 21:13 ` Pranith Kumar 2014-08-18 21:13 ` [PATCH] powerpc: Fix build error for vga16fb Pranith Kumar 2014-08-18 21:13 ` Pranith Kumar 2014-08-18 21:28 ` Geert Uytterhoeven 2014-08-18 21:28 ` Geert Uytterhoeven 2014-08-18 21:34 ` Pranith Kumar 2014-08-18 21:34 ` Pranith Kumar 2014-08-26 10:02 ` Tomi Valkeinen 2014-08-26 10:02 ` Tomi Valkeinen
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.