All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Chen Fan <chen.fan.fnst@cn.fujitsu.com>,
	qemu-devel@nongnu.org,  qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [RESEND v2 0/3] Fix some memory leaks about query memdev
Date: Fri, 29 Aug 2014 20:29:59 +0400	[thread overview]
Message-ID: <5400AA87.5000904@msgid.tls.msk.ru> (raw)
In-Reply-To: <cover.1408344055.git.chen.fan.fnst@cn.fujitsu.com>

18.08.2014 10:46, Chen Fan wrote:
> when using valgrind to test the command "query memdev", I had
> found some memory leaks. the test result:
...

Applied all 3 to -trivial.  Usually these are not really trivial.
Please note that your 2nd patch - "qom/object.c: fix string_output_get_string()
memory leak" - also touches hmp.c (which has a maintainer), but you
didn't mention this in patch description.  I've added it.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Chen Fan <chen.fan.fnst@cn.fujitsu.com>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [RESEND v2 0/3] Fix some memory leaks about query memdev
Date: Fri, 29 Aug 2014 20:29:59 +0400	[thread overview]
Message-ID: <5400AA87.5000904@msgid.tls.msk.ru> (raw)
In-Reply-To: <cover.1408344055.git.chen.fan.fnst@cn.fujitsu.com>

18.08.2014 10:46, Chen Fan wrote:
> when using valgrind to test the command "query memdev", I had
> found some memory leaks. the test result:
...

Applied all 3 to -trivial.  Usually these are not really trivial.
Please note that your 2nd patch - "qom/object.c: fix string_output_get_string()
memory leak" - also touches hmp.c (which has a maintainer), but you
didn't mention this in patch description.  I've added it.

Thanks,

/mjt

  parent reply	other threads:[~2014-08-29 16:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-18  6:46 [Qemu-trivial] [RESEND v2 0/3] Fix some memory leaks about query memdev Chen Fan
2014-08-18  6:46 ` [Qemu-devel] " Chen Fan
2014-08-18  6:46 ` [Qemu-trivial] [RESEND v2 1/3] query-memdev: fix potential memory leaks Chen Fan
2014-08-18  6:46   ` [Qemu-devel] " Chen Fan
2014-08-18  6:46 ` [Qemu-trivial] [RESEND v2 2/3] qom/object.c: fix string_output_get_string() memory leak Chen Fan
2014-08-18  6:46   ` [Qemu-devel] " Chen Fan
2014-08-18  6:46 ` [Qemu-trivial] [RESEND v2 3/3] hmp: fix MemdevList " Chen Fan
2014-08-18  6:46   ` [Qemu-devel] " Chen Fan
2014-08-25  3:37 ` [Qemu-trivial] [Qemu-devel] [RESEND v2 0/3] Fix some memory leaks about query memdev chen.fan.fnst
2014-08-25  3:37   ` chen.fan.fnst
2014-08-28  1:17 ` [Qemu-trivial] " chen.fan.fnst
2014-08-28  1:17   ` chen.fan.fnst
2014-08-29 16:29 ` Michael Tokarev [this message]
2014-08-29 16:29   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-09-01  1:41   ` chen.fan.fnst
2014-09-01  1:41     ` [Qemu-devel] " chen.fan.fnst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5400AA87.5000904@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=chen.fan.fnst@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.