From: Georgi Djakov <gdjakov@mm-sol.com>
To: Stephen Boyd <sboyd@codeaurora.org>,
Chris Ball <chris@printf.net>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Asutosh Das <asutoshd@codeaurora.org>,
Venkat Gopalakrishnan <venkatg@codeaurora.org>
Subject: Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic
Date: Wed, 03 Sep 2014 14:57:40 +0300 [thread overview]
Message-ID: <54070234.30201@mm-sol.com> (raw)
In-Reply-To: <1409702308-3023-1-git-send-email-sboyd@codeaurora.org>
On 09/03/2014 02:58 AM, Stephen Boyd wrote:
> If we're tuning on a big-endian CPU we'll never determine we properly
> tuned the device because we compare the data we received from the
> controller with a table that assumes the CPU is little-endian.
> Change the table to be an array of bytes instead of 32-bit words
> so we can use memcmp() without needing to byte-swap every word
> depending on the endianess of the CPU.
>
> Cc: Asutosh Das <asutoshd@codeaurora.org>
> Cc: Venkat Gopalakrishnan <venkatg@codeaurora.org>
> Cc: Georgi Djakov <gdjakov@mm-sol.com>
> Fixes: 415b5a75da43 "mmc: sdhci-msm: Add platform_execute_tuning implementation"
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
Looks nice. Thanks!
Reviewed-by: Georgi Djakov <gdjakov@mm-sol.com>
WARNING: multiple messages have this Message-ID (diff)
From: gdjakov@mm-sol.com (Georgi Djakov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic
Date: Wed, 03 Sep 2014 14:57:40 +0300 [thread overview]
Message-ID: <54070234.30201@mm-sol.com> (raw)
In-Reply-To: <1409702308-3023-1-git-send-email-sboyd@codeaurora.org>
On 09/03/2014 02:58 AM, Stephen Boyd wrote:
> If we're tuning on a big-endian CPU we'll never determine we properly
> tuned the device because we compare the data we received from the
> controller with a table that assumes the CPU is little-endian.
> Change the table to be an array of bytes instead of 32-bit words
> so we can use memcmp() without needing to byte-swap every word
> depending on the endianess of the CPU.
>
> Cc: Asutosh Das <asutoshd@codeaurora.org>
> Cc: Venkat Gopalakrishnan <venkatg@codeaurora.org>
> Cc: Georgi Djakov <gdjakov@mm-sol.com>
> Fixes: 415b5a75da43 "mmc: sdhci-msm: Add platform_execute_tuning implementation"
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
Looks nice. Thanks!
Reviewed-by: Georgi Djakov <gdjakov@mm-sol.com>
next prev parent reply other threads:[~2014-09-03 11:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 23:58 [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic Stephen Boyd
2014-09-02 23:58 ` Stephen Boyd
2014-09-03 8:36 ` Ulf Hansson
2014-09-03 8:36 ` Ulf Hansson
2014-09-03 13:37 ` Stephen Boyd
2014-09-03 13:37 ` Stephen Boyd
2014-09-03 11:57 ` Georgi Djakov [this message]
2014-09-03 11:57 ` Georgi Djakov
-- strict thread matches above, loose matches on Subject: below --
2014-09-03 13:57 Stephen Boyd
2014-09-03 13:57 ` Stephen Boyd
2014-09-04 5:06 ` Jaehoon Chung
2014-09-04 5:06 ` Jaehoon Chung
2014-09-04 10:53 ` Ulf Hansson
2014-09-04 10:53 ` Ulf Hansson
2014-09-04 21:22 ` Stephen Boyd
2014-09-04 21:22 ` Stephen Boyd
2014-09-04 21:58 ` Jaehoon Chung
2014-09-04 21:58 ` Jaehoon Chung
2014-09-04 22:01 ` Stephen Boyd
2014-09-04 22:01 ` Stephen Boyd
2014-09-15 21:45 ` Stephen Boyd
2014-09-15 21:45 ` Stephen Boyd
2014-09-17 22:36 ` Ulf Hansson
2014-09-17 22:36 ` Ulf Hansson
2014-09-17 22:57 ` Stephen Boyd
2014-09-17 22:57 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54070234.30201@mm-sol.com \
--to=gdjakov@mm-sol.com \
--cc=asutoshd@codeaurora.org \
--cc=chris@printf.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=venkatg@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.