From: Jaehoon Chung <jh80.chung@samsung.com>
To: Stephen Boyd <sboyd@codeaurora.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
Chris Ball <chris@printf.net>, Georgi Djakov <gdjakov@mm-sol.com>,
Asutosh Das <asutoshd@codeaurora.org>,
Venkat Gopalakrishnan <venkatg@codeaurora.org>
Subject: Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic
Date: Fri, 05 Sep 2014 06:58:12 +0900 [thread overview]
Message-ID: <5408E074.7090008@samsung.com> (raw)
In-Reply-To: <5408D81C.7070602@codeaurora.org>
On 09/05/2014 06:22 AM, Stephen Boyd wrote:
> On 09/04/14 03:53, Ulf Hansson wrote:
>> On 4 September 2014 07:06, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>>
>>> In dw-mmc.c, tuning_block values are same.
>>> So I think we can move these value into generic header. how about?
>> Actually, I believe these values comes from the eMMC specification?
>> Shouldn't they be moved to the mmc core instead?
>
> That sounds like good consolidation, but can we do that in a follow-up
> patch? This fixes the driver for me and I was hoping to make something
> minimal to go back to stable trees.
Sure, if my opinion is ok, i will do it after apply your patches.
Best Regards,
Jaehoon Chung
>
WARNING: multiple messages have this Message-ID (diff)
From: jh80.chung@samsung.com (Jaehoon Chung)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic
Date: Fri, 05 Sep 2014 06:58:12 +0900 [thread overview]
Message-ID: <5408E074.7090008@samsung.com> (raw)
In-Reply-To: <5408D81C.7070602@codeaurora.org>
On 09/05/2014 06:22 AM, Stephen Boyd wrote:
> On 09/04/14 03:53, Ulf Hansson wrote:
>> On 4 September 2014 07:06, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>>
>>> In dw-mmc.c, tuning_block values are same.
>>> So I think we can move these value into generic header. how about?
>> Actually, I believe these values comes from the eMMC specification?
>> Shouldn't they be moved to the mmc core instead?
>
> That sounds like good consolidation, but can we do that in a follow-up
> patch? This fixes the driver for me and I was hoping to make something
> minimal to go back to stable trees.
Sure, if my opinion is ok, i will do it after apply your patches.
Best Regards,
Jaehoon Chung
>
next prev parent reply other threads:[~2014-09-04 21:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 13:57 [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic Stephen Boyd
2014-09-03 13:57 ` Stephen Boyd
2014-09-04 5:06 ` Jaehoon Chung
2014-09-04 5:06 ` Jaehoon Chung
2014-09-04 10:53 ` Ulf Hansson
2014-09-04 10:53 ` Ulf Hansson
2014-09-04 21:22 ` Stephen Boyd
2014-09-04 21:22 ` Stephen Boyd
2014-09-04 21:58 ` Jaehoon Chung [this message]
2014-09-04 21:58 ` Jaehoon Chung
2014-09-04 22:01 ` Stephen Boyd
2014-09-04 22:01 ` Stephen Boyd
2014-09-15 21:45 ` Stephen Boyd
2014-09-15 21:45 ` Stephen Boyd
2014-09-17 22:36 ` Ulf Hansson
2014-09-17 22:36 ` Ulf Hansson
2014-09-17 22:57 ` Stephen Boyd
2014-09-17 22:57 ` Stephen Boyd
-- strict thread matches above, loose matches on Subject: below --
2014-09-02 23:58 Stephen Boyd
2014-09-02 23:58 ` Stephen Boyd
2014-09-03 8:36 ` Ulf Hansson
2014-09-03 8:36 ` Ulf Hansson
2014-09-03 13:37 ` Stephen Boyd
2014-09-03 13:37 ` Stephen Boyd
2014-09-03 11:57 ` Georgi Djakov
2014-09-03 11:57 ` Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5408E074.7090008@samsung.com \
--to=jh80.chung@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=chris@printf.net \
--cc=gdjakov@mm-sol.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=venkatg@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.