All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Cc: Tamas K Lengyel <tamas.lengyel@zentific.com>
Subject: Re: [PATCH] x86/HVM: restore parentheses lost by 3d4d4f9336
Date: Wed, 3 Sep 2014 13:53:59 +0100	[thread overview]
Message-ID: <54070F67.4080703@citrix.com> (raw)
In-Reply-To: <54072ADB02000078000304CC@mail.emea.novell.com>


[-- Attachment #1.1: Type: text/plain, Size: 978 bytes --]

On 03/09/14 13:51, Jan Beulich wrote:
> ("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")
>
> Coverity-ID: 1234366
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Ah - I had already posted a patch for this, but as the the change is
identical, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2796,7 +2796,7 @@ int hvm_hap_nested_page_fault(paddr_t gp
>  
>      p2m = p2m_get_hostp2m(v->domain);
>      mfn = get_gfn_type_access(p2m, gfn, &p2mt, &p2ma, 
> -                              P2M_ALLOC | npfec.write_access ? P2M_UNSHARE : 0,
> +                              P2M_ALLOC | (npfec.write_access ? P2M_UNSHARE : 0),
>                                NULL);
>  
>      /* Check access permissions first, then handle faults */
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel


[-- Attachment #1.2: Type: text/html, Size: 1888 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2014-09-03 12:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-03 12:51 [PATCH] x86/HVM: restore parentheses lost by 3d4d4f9336 Jan Beulich
2014-09-03 12:53 ` Andrew Cooper [this message]
2014-09-03 12:57   ` Jan Beulich
2014-09-03 12:56 ` Don Slutz
2014-09-03 15:42 ` Tamas K Lengyel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54070F67.4080703@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=tamas.lengyel@zentific.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.