From: Don Slutz <dslutz@verizon.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Tamas K Lengyel <tamas.lengyel@zentific.com>
Subject: Re: [PATCH] x86/HVM: restore parentheses lost by 3d4d4f9336
Date: Wed, 03 Sep 2014 08:56:51 -0400 [thread overview]
Message-ID: <54071013.6040308@terremark.com> (raw)
In-Reply-To: <54072ADB02000078000304CC@mail.emea.novell.com>
On 09/03/14 08:51, Jan Beulich wrote:
> ("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")
>
> Coverity-ID: 1234366
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Looks good.
Reviewed-by: Don Slutz <dslutz@verizon.com>
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2796,7 +2796,7 @@ int hvm_hap_nested_page_fault(paddr_t gp
>
> p2m = p2m_get_hostp2m(v->domain);
> mfn = get_gfn_type_access(p2m, gfn, &p2mt, &p2ma,
> - P2M_ALLOC | npfec.write_access ? P2M_UNSHARE : 0,
> + P2M_ALLOC | (npfec.write_access ? P2M_UNSHARE : 0),
> NULL);
>
> /* Check access permissions first, then handle faults */
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-09-03 12:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 12:51 [PATCH] x86/HVM: restore parentheses lost by 3d4d4f9336 Jan Beulich
2014-09-03 12:53 ` Andrew Cooper
2014-09-03 12:57 ` Jan Beulich
2014-09-03 12:56 ` Don Slutz [this message]
2014-09-03 15:42 ` Tamas K Lengyel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54071013.6040308@terremark.com \
--to=dslutz@verizon.com \
--cc=JBeulich@suse.com \
--cc=tamas.lengyel@zentific.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.