* [PATCH] x86/HVM: restore parentheses lost by 3d4d4f9336
@ 2014-09-03 12:51 Jan Beulich
2014-09-03 12:53 ` Andrew Cooper
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jan Beulich @ 2014-09-03 12:51 UTC (permalink / raw)
To: xen-devel; +Cc: Tamas K Lengyel
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")
Coverity-ID: 1234366
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -2796,7 +2796,7 @@ int hvm_hap_nested_page_fault(paddr_t gp
p2m = p2m_get_hostp2m(v->domain);
mfn = get_gfn_type_access(p2m, gfn, &p2mt, &p2ma,
- P2M_ALLOC | npfec.write_access ? P2M_UNSHARE : 0,
+ P2M_ALLOC | (npfec.write_access ? P2M_UNSHARE : 0),
NULL);
/* Check access permissions first, then handle faults */
[-- Attachment #2: CID1234633.patch --]
[-- Type: text/plain, Size: 695 bytes --]
x86/HVM: restore parentheses lost by 3d4d4f9336
("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")
Coverity-ID: 1234366
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -2796,7 +2796,7 @@ int hvm_hap_nested_page_fault(paddr_t gp
p2m = p2m_get_hostp2m(v->domain);
mfn = get_gfn_type_access(p2m, gfn, &p2mt, &p2ma,
- P2M_ALLOC | npfec.write_access ? P2M_UNSHARE : 0,
+ P2M_ALLOC | (npfec.write_access ? P2M_UNSHARE : 0),
NULL);
/* Check access permissions first, then handle faults */
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86/HVM: restore parentheses lost by 3d4d4f9336
2014-09-03 12:51 [PATCH] x86/HVM: restore parentheses lost by 3d4d4f9336 Jan Beulich
@ 2014-09-03 12:53 ` Andrew Cooper
2014-09-03 12:57 ` Jan Beulich
2014-09-03 12:56 ` Don Slutz
2014-09-03 15:42 ` Tamas K Lengyel
2 siblings, 1 reply; 5+ messages in thread
From: Andrew Cooper @ 2014-09-03 12:53 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Tamas K Lengyel
[-- Attachment #1.1: Type: text/plain, Size: 978 bytes --]
On 03/09/14 13:51, Jan Beulich wrote:
> ("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")
>
> Coverity-ID: 1234366
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Ah - I had already posted a patch for this, but as the the change is
identical, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2796,7 +2796,7 @@ int hvm_hap_nested_page_fault(paddr_t gp
>
> p2m = p2m_get_hostp2m(v->domain);
> mfn = get_gfn_type_access(p2m, gfn, &p2mt, &p2ma,
> - P2M_ALLOC | npfec.write_access ? P2M_UNSHARE : 0,
> + P2M_ALLOC | (npfec.write_access ? P2M_UNSHARE : 0),
> NULL);
>
> /* Check access permissions first, then handle faults */
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 1888 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86/HVM: restore parentheses lost by 3d4d4f9336
2014-09-03 12:51 [PATCH] x86/HVM: restore parentheses lost by 3d4d4f9336 Jan Beulich
2014-09-03 12:53 ` Andrew Cooper
@ 2014-09-03 12:56 ` Don Slutz
2014-09-03 15:42 ` Tamas K Lengyel
2 siblings, 0 replies; 5+ messages in thread
From: Don Slutz @ 2014-09-03 12:56 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Tamas K Lengyel
On 09/03/14 08:51, Jan Beulich wrote:
> ("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")
>
> Coverity-ID: 1234366
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Looks good.
Reviewed-by: Don Slutz <dslutz@verizon.com>
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2796,7 +2796,7 @@ int hvm_hap_nested_page_fault(paddr_t gp
>
> p2m = p2m_get_hostp2m(v->domain);
> mfn = get_gfn_type_access(p2m, gfn, &p2mt, &p2ma,
> - P2M_ALLOC | npfec.write_access ? P2M_UNSHARE : 0,
> + P2M_ALLOC | (npfec.write_access ? P2M_UNSHARE : 0),
> NULL);
>
> /* Check access permissions first, then handle faults */
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86/HVM: restore parentheses lost by 3d4d4f9336
2014-09-03 12:53 ` Andrew Cooper
@ 2014-09-03 12:57 ` Jan Beulich
0 siblings, 0 replies; 5+ messages in thread
From: Jan Beulich @ 2014-09-03 12:57 UTC (permalink / raw)
To: Andrew Cooper; +Cc: xen-devel, Tamas K Lengyel
>>> On 03.09.14 at 14:53, <andrew.cooper3@citrix.com> wrote:
> On 03/09/14 13:51, Jan Beulich wrote:
>> ("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")
>>
>> Coverity-ID: 1234366
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Ah - I had already posted a patch for this, but as the the change is
> identical, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Yeah, I should probably have checked before sending.
Jan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86/HVM: restore parentheses lost by 3d4d4f9336
2014-09-03 12:51 [PATCH] x86/HVM: restore parentheses lost by 3d4d4f9336 Jan Beulich
2014-09-03 12:53 ` Andrew Cooper
2014-09-03 12:56 ` Don Slutz
@ 2014-09-03 15:42 ` Tamas K Lengyel
2 siblings, 0 replies; 5+ messages in thread
From: Tamas K Lengyel @ 2014-09-03 15:42 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 784 bytes --]
On Wed, Sep 3, 2014 at 2:51 PM, Jan Beulich <JBeulich@suse.com> wrote:
> ("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")
>
>
Coverity-ID: 1234366
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2796,7 +2796,7 @@ int hvm_hap_nested_page_fault(paddr_t gp
>
> p2m = p2m_get_hostp2m(v->domain);
> mfn = get_gfn_type_access(p2m, gfn, &p2mt, &p2ma,
> - P2M_ALLOC | npfec.write_access ?
> P2M_UNSHARE : 0,
> + P2M_ALLOC | (npfec.write_access ?
> P2M_UNSHARE : 0),
> NULL);
>
> /* Check access permissions first, then handle faults */
>
>
Whops, that's my mistake. Sorry about that.
Tamas
[-- Attachment #1.2: Type: text/html, Size: 1356 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-03 15:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-03 12:51 [PATCH] x86/HVM: restore parentheses lost by 3d4d4f9336 Jan Beulich
2014-09-03 12:53 ` Andrew Cooper
2014-09-03 12:57 ` Jan Beulich
2014-09-03 12:56 ` Don Slutz
2014-09-03 15:42 ` Tamas K Lengyel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.