From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Greg KH <greg@kroah.com>, <linux-mips@linux-mips.org>,
<linux-next@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
<linux-serial@vger.kernel.org>
Subject: Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions
Date: Wed, 10 Sep 2014 10:14:36 +0100 [thread overview]
Message-ID: <5410167C.2070305@imgtec.com> (raw)
In-Reply-To: <CAPybu_03BDC5+d5-Wmwz+x==5sbKHgU8Rr0JimK16yRnN65x8Q@mail.gmail.com>
On 09/10/2014 10:05 AM, Ricardo Ribalda Delgado wrote:
> Hello Markos
>
> Sorry for the mess. I have already send a new patch for mips using the
> _IO* macros
>
> Just to put things a bit into context:
>
> I did made the patch for serial and tested it only in x86. I wrongly
> infer that the IOCTLS were defined for all the arches (sorry :S)
>
> Then when the patch was applied on tty-next the build-bot throw some
> errors for xtensa, that I fixed without using the IO_ macros
>
> Then you came with your patch,
>
> I realized that this could be wrong for mor arches, so I check the
> rest and make patches for them.
>
> Greg then pointed out that I should use _IO instead of numbers, so I
> remade my patches using the _IO macros. I did not want to step into
> your patch so I did not prepare a new one for mips
>
> All the _IO patches (except mips) are now merged into tty-next.
>
> Hopefully that one also get merged soon :)
>
>
> Thanks for your help and sorry for any disturbance.
>
>
Hi Ricardo,
No problem :) Thanks for taking care of that
--
markos
WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Greg KH <greg@kroah.com>,
linux-mips@linux-mips.org, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions
Date: Wed, 10 Sep 2014 10:14:36 +0100 [thread overview]
Message-ID: <5410167C.2070305@imgtec.com> (raw)
Message-ID: <20140910091436.ReWzF0auG-mt8XF25tMKVjD8HgbYpVcLqVKHZMiPuLY@z> (raw)
In-Reply-To: <CAPybu_03BDC5+d5-Wmwz+x==5sbKHgU8Rr0JimK16yRnN65x8Q@mail.gmail.com>
On 09/10/2014 10:05 AM, Ricardo Ribalda Delgado wrote:
> Hello Markos
>
> Sorry for the mess. I have already send a new patch for mips using the
> _IO* macros
>
> Just to put things a bit into context:
>
> I did made the patch for serial and tested it only in x86. I wrongly
> infer that the IOCTLS were defined for all the arches (sorry :S)
>
> Then when the patch was applied on tty-next the build-bot throw some
> errors for xtensa, that I fixed without using the IO_ macros
>
> Then you came with your patch,
>
> I realized that this could be wrong for mor arches, so I check the
> rest and make patches for them.
>
> Greg then pointed out that I should use _IO instead of numbers, so I
> remade my patches using the _IO macros. I did not want to step into
> your patch so I did not prepare a new one for mips
>
> All the _IO patches (except mips) are now merged into tty-next.
>
> Hopefully that one also get merged soon :)
>
>
> Thanks for your help and sorry for any disturbance.
>
>
Hi Ricardo,
No problem :) Thanks for taking care of that
--
markos
next prev parent reply other threads:[~2014-09-10 9:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 11:52 [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions Markos Chandras
2014-09-09 11:52 ` Markos Chandras
2014-09-09 19:17 ` Greg KH
2014-09-10 8:25 ` Markos Chandras
2014-09-10 8:25 ` Markos Chandras
2014-09-10 8:39 ` Ricardo Ribalda Delgado
2014-09-10 8:45 ` Markos Chandras
2014-09-10 8:45 ` Markos Chandras
2014-09-10 9:05 ` Ricardo Ribalda Delgado
2014-09-10 9:14 ` Markos Chandras [this message]
2014-09-10 9:14 ` Markos Chandras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5410167C.2070305@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.