From: Chris Mason <clm@fb.com>
To: behanw@converseincode.com, agk@redhat.com, davem@davemloft.net,
dm-devel@redhat.com, fabf@skynet.be, herbert@gondor.apana.org.au,
jbacik@fb.com, snitzer@redhat.com, tadeusz.struk@intel.com
Cc: akpm@linux-foundation.org, bruce.w.allan@intel.com,
d.kasatkin@samsung.com, james.l.morris@oracle.com,
john.griffin@intel.com, linux-btrfs@vger.kernel.org,
linux-crypto@vger.kernel.org,
linux-ima-devel@lists.sourceforge.net,
linux-ima-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
linux-security-module@vger.kernel.org, neilb@suse.de,
qat-linux@intel.com, serge@hallyn.com, thomas.lendacky@amd.com,
zohar@linux.vnet.ibm.com, torvalds@linux-foundation.org,
"Vinícius Tinti" <viniciustinti@gmail.com>
Subject: Re: [PATCH v3 02/12] btrfs: LLVMLinux: Remove VLAIS
Date: Wed, 17 Sep 2014 09:49:20 -0400 [thread overview]
Message-ID: <54199160.7090401@fb.com> (raw)
In-Reply-To: <1410766234-1634-3-git-send-email-behanw@converseincode.com>
On 09/15/2014 03:30 AM, behanw@converseincode.com wrote:
> From: Vinícius Tinti <viniciustinti@gmail.com>
>
> Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99
> compliant equivalent. This is the original VLAIS struct.
>
> struct {
> struct shash_desc shash;
> char ctx[crypto_shash_descsize(tfm)];
> } desc;
>
> This patch instead allocates the appropriate amount of memory using a
> char array using the SHASH_DESC_ON_STACK macro.
>
> The new code can be compiled with both gcc and clang.
>
> Signed-off-by: Vinícius Tinti <viniciustinti@gmail.com>
> Reviewed-by: Jan-Simon Möller <dl9pf@gmx.de>
> Reviewed-by: Mark Charlebois <charlebm@gmail.com>
> Signed-off-by: Behan Webster <behanw@converseincode.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Chris Mason <clm@fb.com>
On the btrfs bits. Thanks for the v3.
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Chris Mason <clm@fb.com>
To: <behanw@converseincode.com>, <agk@redhat.com>,
<davem@davemloft.net>, <dm-devel@redhat.com>, <fabf@skynet.be>,
<herbert@gondor.apana.org.au>, <jbacik@fb.com>,
<snitzer@redhat.com>, <tadeusz.struk@intel.com>
Cc: akpm@linux-foundation.org, bruce.w.allan@intel.com,
d.kasatkin@samsung.com, james.l.morris@oracle.com,
john.griffin@intel.com, linux-btrfs@vger.kernel.org,
linux-crypto@vger.kernel.org,
linux-ima-devel@lists.sourceforge.net,
linux-ima-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
linux-security-module@vger.kernel.org, neilb@suse.de,
qat-linux@intel.com, serge@hallyn.com, thomas.lendacky@amd.com,
zohar@linux.vnet.ibm.com, torvalds@linux-foundation.org,
"Vinícius Tinti" <viniciustinti@gmail.com>
Subject: Re: [PATCH v3 02/12] btrfs: LLVMLinux: Remove VLAIS
Date: Wed, 17 Sep 2014 09:49:20 -0400 [thread overview]
Message-ID: <54199160.7090401@fb.com> (raw)
In-Reply-To: <1410766234-1634-3-git-send-email-behanw@converseincode.com>
On 09/15/2014 03:30 AM, behanw@converseincode.com wrote:
> From: Vinícius Tinti <viniciustinti@gmail.com>
>
> Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99
> compliant equivalent. This is the original VLAIS struct.
>
> struct {
> struct shash_desc shash;
> char ctx[crypto_shash_descsize(tfm)];
> } desc;
>
> This patch instead allocates the appropriate amount of memory using a
> char array using the SHASH_DESC_ON_STACK macro.
>
> The new code can be compiled with both gcc and clang.
>
> Signed-off-by: Vinícius Tinti <viniciustinti@gmail.com>
> Reviewed-by: Jan-Simon Möller <dl9pf@gmx.de>
> Reviewed-by: Mark Charlebois <charlebm@gmail.com>
> Signed-off-by: Behan Webster <behanw@converseincode.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Chris Mason <clm@fb.com>
On the btrfs bits. Thanks for the v3.
-chris
WARNING: multiple messages have this Message-ID (diff)
From: Chris Mason <clm@fb.com>
To: <behanw@converseincode.com>, <agk@redhat.com>,
<davem@davemloft.net>, <dm-devel@redhat.com>, <fabf@skynet.be>,
<herbert@gondor.apana.org.au>, <jbacik@fb.com>,
<snitzer@redhat.com>, <tadeusz.struk@intel.com>
Cc: akpm@linux-foundation.org, bruce.w.allan@intel.com,
d.kasatkin@samsung.com, james.l.morris@oracle.com,
john.griffin@intel.com, linux-btrfs@vger.kernel.org,
linux-crypto@vger.kernel.org,
linux-ima-devel@lists.sourceforge.net,
linux-ima-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
linux-security-module@vger.kernel.org, neilb@suse.de,
qat-linux@intel.com, serge@hallyn.com, thomas.lendacky@amd.com,
zohar@linux.vnet.ibm.com, torvalds@linux-foundation.org,
"Vinícius Tinti" <viniciustinti@gmail.com>
Subject: Re: [PATCH v3 02/12] btrfs: LLVMLinux: Remove VLAIS
Date: Wed, 17 Sep 2014 09:49:20 -0400 [thread overview]
Message-ID: <54199160.7090401@fb.com> (raw)
In-Reply-To: <1410766234-1634-3-git-send-email-behanw@converseincode.com>
On 09/15/2014 03:30 AM, behanw@converseincode.com wrote:
> From: Vinícius Tinti <viniciustinti@gmail.com>
>
> Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99
> compliant equivalent. This is the original VLAIS struct.
>
> struct {
> struct shash_desc shash;
> char ctx[crypto_shash_descsize(tfm)];
> } desc;
>
> This patch instead allocates the appropriate amount of memory using a
> char array using the SHASH_DESC_ON_STACK macro.
>
> The new code can be compiled with both gcc and clang.
>
> Signed-off-by: Vinícius Tinti <viniciustinti@gmail.com>
> Reviewed-by: Jan-Simon Möller <dl9pf@gmx.de>
> Reviewed-by: Mark Charlebois <charlebm@gmail.com>
> Signed-off-by: Behan Webster <behanw@converseincode.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Chris Mason <clm@fb.com>
On the btrfs bits. Thanks for the v3.
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-09-17 13:49 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 7:30 [PATCH v3 00/12] LLVMLinux: Patches to enable the kernel to be compiled with clang/LLVM behanw
2014-09-15 7:30 ` behanw
2014-09-15 7:30 ` [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code behanw
2014-09-15 7:30 ` behanw
2014-09-15 8:06 ` [dm-devel] " Michał Mirosław
2014-09-15 8:37 ` Behan Webster
2014-09-15 8:37 ` Behan Webster
2014-09-17 9:22 ` Herbert Xu
2014-09-17 11:15 ` Dmitry Kasatkin
2014-09-17 11:30 ` Herbert Xu
2014-09-17 15:26 ` Behan Webster
2014-09-17 15:26 ` Behan Webster
2014-09-15 7:30 ` [PATCH v3 02/12] btrfs: LLVMLinux: Remove VLAIS behanw
2014-09-15 7:30 ` behanw
2014-09-17 13:49 ` Chris Mason [this message]
2014-09-17 13:49 ` Chris Mason
2014-09-17 13:49 ` Chris Mason
2014-09-15 7:30 ` [PATCH v3 03/12] crypto: LLVMLinux: Remove VLAIS from crypto/ccp/ccp-crypto-sha.c behanw
2014-09-15 7:30 ` behanw
2014-09-15 7:30 ` [PATCH v3 04/12] crypto: LLVMLinux: Remove VLAIS from crypto/mv_cesa.c behanw
2014-09-15 7:30 ` behanw
2014-09-15 7:30 ` [PATCH v3 05/12] crypto: LLVMLinux: Remove VLAIS from crypto/n2_core.c behanw
2014-09-15 7:30 ` [PATCH v3 06/12] crypto: LLVMLinux: Remove VLAIS from crypto/omap_sham.c behanw
2014-09-15 7:30 ` [PATCH v3 07/12] crypto: LLVMLinux: Remove VLAIS from crypto/.../qat_algs.c behanw
2014-09-15 7:30 ` behanw
2014-09-15 7:30 ` [PATCH v3 08/12] crypto, dm: LLVMLinux: Remove VLAIS usage from dm-crypt behanw
2014-09-15 7:30 ` [PATCH v3 09/12] crypto: LLVMLinux: Remove VLAIS usage from crypto/hmac.c behanw
2014-09-15 7:30 ` [PATCH v3 10/12] crypto: LLVMLinux: Remove VLAIS usage from libcrc32c.c behanw
2014-09-15 7:30 ` [PATCH v3 11/12] security, crypto: LLVMLinux: Remove VLAIS from ima_crypto.c behanw
2014-09-15 7:30 ` behanw
2014-09-15 14:21 ` Linus Torvalds
2014-09-15 14:21 ` Linus Torvalds
2014-09-15 14:25 ` Behan Webster
2014-09-15 14:25 ` Behan Webster
2014-09-15 7:30 ` [PATCH v3 12/12] crypto: LLVMLinux: Remove VLAIS usage from crypto/testmgr.c behanw
2014-09-15 7:30 ` behanw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54199160.7090401@fb.com \
--to=clm@fb.com \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=behanw@converseincode.com \
--cc=bruce.w.allan@intel.com \
--cc=d.kasatkin@samsung.com \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=fabf@skynet.be \
--cc=herbert@gondor.apana.org.au \
--cc=james.l.morris@oracle.com \
--cc=jbacik@fb.com \
--cc=john.griffin@intel.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-ima-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=neilb@suse.de \
--cc=qat-linux@intel.com \
--cc=serge@hallyn.com \
--cc=snitzer@redhat.com \
--cc=tadeusz.struk@intel.com \
--cc=thomas.lendacky@amd.com \
--cc=torvalds@linux-foundation.org \
--cc=viniciustinti@gmail.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.