All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Doug Anderson <dianders@chromium.org>
Cc: "Kukjin Kim" <kgene.kim@samsung.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Daniel Drake" <drake@endlessm.com>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"Andreas Färber" <afaerber@suse.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] ARM: dts: Add rtc_src clk for s3c-rtc on exynos5250-snow
Date: Thu, 18 Sep 2014 08:48:49 +0200	[thread overview]
Message-ID: <541A8051.20207@collabora.co.uk> (raw)
In-Reply-To: <CAD=FV=W7xJ01m2oLtuDnogOmrpwpztbir=59oSWU6oojFYUWKw@mail.gmail.com>

Hello Doug, Andreas,

On 09/17/2014 05:47 PM, Doug Anderson wrote:
>>
>>         rtc@101E0000 {
>>                 status = "okay";
>> +               clocks = <&clock CLK_RTC>, <&max77686 MAX77686_CLK_AP>;
>> +               clock-names = "rtc", "rtc_src";
> 
> Wait, seriously?  Snow is still using the "rtc@101E0000" syntax?
> Whatever happened to the series that Andreas worked so hard on,
> including <https://patchwork.kernel.org/patch/4664801/>?
>

Andreas, I completely forgot about your series when writing this patch even
though I've on my TO-DO to sync the downstream and upstream Snow DTS once your
patches land. Sorry about that.

> 
> In any case, there's nothing wrong with Javier's patch other than the
> fact that it will eventually need to get merged with Andreas's, so:
> 
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> 

Thanks, I'll re-spin and post again once Kukjin merges Andreas series.

Best regards,
Javier

WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: Add rtc_src clk for s3c-rtc on exynos5250-snow
Date: Thu, 18 Sep 2014 08:48:49 +0200	[thread overview]
Message-ID: <541A8051.20207@collabora.co.uk> (raw)
In-Reply-To: <CAD=FV=W7xJ01m2oLtuDnogOmrpwpztbir=59oSWU6oojFYUWKw@mail.gmail.com>

Hello Doug, Andreas,

On 09/17/2014 05:47 PM, Doug Anderson wrote:
>>
>>         rtc at 101E0000 {
>>                 status = "okay";
>> +               clocks = <&clock CLK_RTC>, <&max77686 MAX77686_CLK_AP>;
>> +               clock-names = "rtc", "rtc_src";
> 
> Wait, seriously?  Snow is still using the "rtc at 101E0000" syntax?
> Whatever happened to the series that Andreas worked so hard on,
> including <https://patchwork.kernel.org/patch/4664801/>?
>

Andreas, I completely forgot about your series when writing this patch even
though I've on my TO-DO to sync the downstream and upstream Snow DTS once your
patches land. Sorry about that.

> 
> In any case, there's nothing wrong with Javier's patch other than the
> fact that it will eventually need to get merged with Andreas's, so:
> 
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> 

Thanks, I'll re-spin and post again once Kukjin merges Andreas series.

Best regards,
Javier

WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Doug Anderson <dianders@chromium.org>
Cc: "Kukjin Kim" <kgene.kim@samsung.com>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Daniel Drake" <drake@endlessm.com>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [PATCH 2/2] ARM: dts: Add rtc_src clk for s3c-rtc on exynos5250-snow
Date: Thu, 18 Sep 2014 08:48:49 +0200	[thread overview]
Message-ID: <541A8051.20207@collabora.co.uk> (raw)
In-Reply-To: <CAD=FV=W7xJ01m2oLtuDnogOmrpwpztbir=59oSWU6oojFYUWKw@mail.gmail.com>

Hello Doug, Andreas,

On 09/17/2014 05:47 PM, Doug Anderson wrote:
>>
>>         rtc@101E0000 {
>>                 status = "okay";
>> +               clocks = <&clock CLK_RTC>, <&max77686 MAX77686_CLK_AP>;
>> +               clock-names = "rtc", "rtc_src";
> 
> Wait, seriously?  Snow is still using the "rtc@101E0000" syntax?
> Whatever happened to the series that Andreas worked so hard on,
> including <https://patchwork.kernel.org/patch/4664801/>?
>

Andreas, I completely forgot about your series when writing this patch even
though I've on my TO-DO to sync the downstream and upstream Snow DTS once your
patches land. Sorry about that.

> 
> In any case, there's nothing wrong with Javier's patch other than the
> fact that it will eventually need to get merged with Andreas's, so:
> 
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> 

Thanks, I'll re-spin and post again once Kukjin merges Andreas series.

Best regards,
Javier

  parent reply	other threads:[~2014-09-18  6:48 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17 11:50 [PATCH 0/2] s3c RTC fix for Exynos Chromebooks Javier Martinez Canillas
2014-09-17 11:50 ` Javier Martinez Canillas
2014-09-17 11:50 ` [PATCH 1/2] ARM: dts: Add rtc_src clk for s3c-rtc on exynos Peach boards Javier Martinez Canillas
2014-09-17 11:50   ` Javier Martinez Canillas
2014-09-17 15:24   ` Doug Anderson
2014-09-17 15:24     ` Doug Anderson
2014-09-22  6:41   ` Chanwoo Choi
2014-09-22  6:41     ` Chanwoo Choi
2014-09-17 11:50 ` [PATCH 2/2] ARM: dts: Add rtc_src clk for s3c-rtc on exynos5250-snow Javier Martinez Canillas
2014-09-17 11:50   ` Javier Martinez Canillas
2014-09-17 15:47   ` Doug Anderson
2014-09-17 15:47     ` Doug Anderson
2014-09-17 15:51     ` Andreas Färber
2014-09-17 15:51       ` Andreas Färber
2014-09-22 12:09       ` Kukjin Kim
2014-09-22 12:09         ` Kukjin Kim
2014-09-23  6:17       ` Kukjin Kim
2014-09-23  6:17         ` Kukjin Kim
2014-09-23 16:00         ` Kukjin Kim
2014-09-23 16:00           ` Kukjin Kim
2014-09-23 16:00           ` Kukjin Kim
2014-09-23 16:18           ` Javier Martinez Canillas
2014-09-23 16:18             ` Javier Martinez Canillas
2014-09-23 16:18             ` Javier Martinez Canillas
2014-09-24 21:41             ` Javier Martinez Canillas
2014-09-24 21:41               ` Javier Martinez Canillas
2014-09-24 23:27               ` Kukjin Kim
2014-09-24 23:27                 ` Kukjin Kim
2014-09-25  7:18                 ` Javier Martinez Canillas
2014-09-25  7:18                   ` Javier Martinez Canillas
2014-09-18  6:48     ` Javier Martinez Canillas [this message]
2014-09-18  6:48       ` Javier Martinez Canillas
2014-09-18  6:48       ` Javier Martinez Canillas
2014-09-22  6:44   ` Chanwoo Choi
2014-09-22  6:44     ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541A8051.20207@collabora.co.uk \
    --to=javier.martinez@collabora.co.uk \
    --cc=afaerber@suse.de \
    --cc=cw00.choi@samsung.com \
    --cc=dianders@chromium.org \
    --cc=drake@endlessm.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.