From: bhuvanchandra.dv@toradex.com (Bhuvanchandra DV)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: dts: vf610-colibri: Add PWM support
Date: Mon, 22 Sep 2014 10:08:33 +0530 [thread overview]
Message-ID: <541FA7C9.30509@toradex.com> (raw)
In-Reply-To: <e63381e2dd14625e5395f892928b38f2@agner.ch>
On Friday 19 September 2014 09:30 PM, Stefan Agner wrote:
> Am 2014-09-19 15:38, schrieb Bhuvanchandra DV:
>> The Colibri standard defines four pins as PWM outputs, two of them (PWM
>> A and C) are routed to FTM instance 0 and the other two (PWM B and D)
>> are routed to FTM instance 1. Hence enable both FTM instances for the
>> Colibri module and mux the four pins accordingly.
>>
>> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
>> ---
>> arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 8 +++++++
>> arch/arm/boot/dts/vf610-colibri.dtsi | 31 +++++++++++++++++++++++----
>> 2 files changed, 35 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> index 7fb3066..00f63d9 100644
>> --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> @@ -33,6 +33,14 @@
>> status = "okay";
>> };
>>
>> +&pwm0 {
>> + status = "okay";
>> +};
>> +
>> +&pwm1 {
>> + status = "okay";
>> +};
>> +
>> &uart0 {
>> status = "okay";
>> };
>> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi
>> b/arch/arm/boot/dts/vf610-colibri.dtsi
>> index 0cd8343..560cd69 100644
>> --- a/arch/arm/boot/dts/vf610-colibri.dtsi
>> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi
>> @@ -13,10 +13,6 @@
>> model = "Toradex Colibri VF61 COM";
>> compatible = "toradex,vf610-colibri_vf61", "fsl,vf610";
>>
>> - memory {
>> - reg = <0x80000000 0x10000000>;
>> - };
>> -
>> clocks {
>> enet_ext {
>> compatible = "fixed-clock";
>> @@ -25,6 +21,9 @@
>> };
>> };
>>
>> + memory {
>> + reg = <0x80000000 0x10000000>;
>> + };
> Memory is a bit an exception here: In almost all device tree this is the
> first node after model/compatible. Also, it's generally not allowed to
> make changes outside of the topic (PWM in this case)... Hence I would
> drop this change.
>
> The rest
> Acked-By: Stefan Agner <stefan@agner.ch>
OK. Will drop the change.
>> };
>>
>> &esdhc1 {
>> @@ -44,6 +43,16 @@
>> arm,tag-latency = <3 2 3>;
>> };
>>
>> +&pwm0 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_pwm0>;
>> +};
>> +
>> +&pwm1 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_pwm1>;
>> +};
>> +
>> &uart0 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_uart0>;
>> @@ -97,6 +106,20 @@
>> >;
>> };
>>
>> + pinctrl_pwm0: pwm0grp {
>> + fsl,pins = <
>> + VF610_PAD_PTB0__FTM0_CH0 0x1182
>> + VF610_PAD_PTB1__FTM0_CH1 0x1182
>> + >;
>> + };
>> +
>> + pinctrl_pwm1: pwm1grp {
>> + fsl,pins = <
>> + VF610_PAD_PTB8__FTM1_CH0 0x1182
>> + VF610_PAD_PTB9__FTM1_CH1 0x1182
>> + >;
>> + };
>> +
>> pinctrl_uart0: uart0grp {
>> fsl,pins = <
>> VF610_PAD_PTB10__UART0_TX 0x21a2
WARNING: multiple messages have this Message-ID (diff)
From: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
To: Stefan Agner <stefan@agner.ch>
Cc: <shawn.guo@freescale.com>, <linux@arm.linux.org.uk>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] ARM: dts: vf610-colibri: Add PWM support
Date: Mon, 22 Sep 2014 10:08:33 +0530 [thread overview]
Message-ID: <541FA7C9.30509@toradex.com> (raw)
In-Reply-To: <e63381e2dd14625e5395f892928b38f2@agner.ch>
On Friday 19 September 2014 09:30 PM, Stefan Agner wrote:
> Am 2014-09-19 15:38, schrieb Bhuvanchandra DV:
>> The Colibri standard defines four pins as PWM outputs, two of them (PWM
>> A and C) are routed to FTM instance 0 and the other two (PWM B and D)
>> are routed to FTM instance 1. Hence enable both FTM instances for the
>> Colibri module and mux the four pins accordingly.
>>
>> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
>> ---
>> arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 8 +++++++
>> arch/arm/boot/dts/vf610-colibri.dtsi | 31 +++++++++++++++++++++++----
>> 2 files changed, 35 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> index 7fb3066..00f63d9 100644
>> --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> @@ -33,6 +33,14 @@
>> status = "okay";
>> };
>>
>> +&pwm0 {
>> + status = "okay";
>> +};
>> +
>> +&pwm1 {
>> + status = "okay";
>> +};
>> +
>> &uart0 {
>> status = "okay";
>> };
>> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi
>> b/arch/arm/boot/dts/vf610-colibri.dtsi
>> index 0cd8343..560cd69 100644
>> --- a/arch/arm/boot/dts/vf610-colibri.dtsi
>> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi
>> @@ -13,10 +13,6 @@
>> model = "Toradex Colibri VF61 COM";
>> compatible = "toradex,vf610-colibri_vf61", "fsl,vf610";
>>
>> - memory {
>> - reg = <0x80000000 0x10000000>;
>> - };
>> -
>> clocks {
>> enet_ext {
>> compatible = "fixed-clock";
>> @@ -25,6 +21,9 @@
>> };
>> };
>>
>> + memory {
>> + reg = <0x80000000 0x10000000>;
>> + };
> Memory is a bit an exception here: In almost all device tree this is the
> first node after model/compatible. Also, it's generally not allowed to
> make changes outside of the topic (PWM in this case)... Hence I would
> drop this change.
>
> The rest
> Acked-By: Stefan Agner <stefan@agner.ch>
OK. Will drop the change.
>> };
>>
>> &esdhc1 {
>> @@ -44,6 +43,16 @@
>> arm,tag-latency = <3 2 3>;
>> };
>>
>> +&pwm0 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_pwm0>;
>> +};
>> +
>> +&pwm1 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_pwm1>;
>> +};
>> +
>> &uart0 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_uart0>;
>> @@ -97,6 +106,20 @@
>> >;
>> };
>>
>> + pinctrl_pwm0: pwm0grp {
>> + fsl,pins = <
>> + VF610_PAD_PTB0__FTM0_CH0 0x1182
>> + VF610_PAD_PTB1__FTM0_CH1 0x1182
>> + >;
>> + };
>> +
>> + pinctrl_pwm1: pwm1grp {
>> + fsl,pins = <
>> + VF610_PAD_PTB8__FTM1_CH0 0x1182
>> + VF610_PAD_PTB9__FTM1_CH1 0x1182
>> + >;
>> + };
>> +
>> pinctrl_uart0: uart0grp {
>> fsl,pins = <
>> VF610_PAD_PTB10__UART0_TX 0x21a2
next prev parent reply other threads:[~2014-09-22 4:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 13:38 [PATCH v2 0/2] Add PWM and backlight support for Colibri VF61 modules Bhuvanchandra DV
2014-09-19 13:38 ` Bhuvanchandra DV
2014-09-19 13:38 ` [PATCH v2 1/2] ARM: dts: vf610-colibri: Add PWM support Bhuvanchandra DV
2014-09-19 13:38 ` Bhuvanchandra DV
2014-09-19 16:00 ` Stefan Agner
2014-09-19 16:00 ` Stefan Agner
2014-09-22 4:38 ` Bhuvanchandra DV [this message]
2014-09-22 4:38 ` Bhuvanchandra DV
2014-09-19 13:38 ` [PATCH v2 2/2] ARM: dts: vf610-colibri: Add backlight support Bhuvanchandra DV
2014-09-19 13:38 ` Bhuvanchandra DV
2014-09-19 16:03 ` Stefan Agner
2014-09-19 16:03 ` Stefan Agner
2014-09-22 4:49 ` Bhuvanchandra DV
2014-09-22 4:49 ` Bhuvanchandra DV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541FA7C9.30509@toradex.com \
--to=bhuvanchandra.dv@toradex.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.