* [PATCH v2 0/2] Add PWM and backlight support for Colibri VF61 modules @ 2014-09-19 13:38 ` Bhuvanchandra DV 0 siblings, 0 replies; 14+ messages in thread From: Bhuvanchandra DV @ 2014-09-19 13:38 UTC (permalink / raw) To: linux-arm-kernel Changes since v1: [1] Sorted the node names alphabetically. [2] Updated the node name 'bl: backlight' to 'backlight: bl'. [3] Dropped the leading space in 'pwm-names' property of backlight. Bhuvanchandra DV (2): ARM: dts: vf610-colibri: Add PWM support ARM: dts: vf610-colibri: Add backlight support arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 14 ++++++++++++ arch/arm/boot/dts/vf610-colibri.dtsi | 33 +++++++++++++++++++++++++-- 2 files changed, 45 insertions(+), 2 deletions(-) -- 1.7.9.5 ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 0/2] Add PWM and backlight support for Colibri VF61 modules @ 2014-09-19 13:38 ` Bhuvanchandra DV 0 siblings, 0 replies; 14+ messages in thread From: Bhuvanchandra DV @ 2014-09-19 13:38 UTC (permalink / raw) To: shawn.guo; +Cc: stefan, linux, linux-arm-kernel, linux-kernel, Bhuvanchandra DV Changes since v1: [1] Sorted the node names alphabetically. [2] Updated the node name 'bl: backlight' to 'backlight: bl'. [3] Dropped the leading space in 'pwm-names' property of backlight. Bhuvanchandra DV (2): ARM: dts: vf610-colibri: Add PWM support ARM: dts: vf610-colibri: Add backlight support arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 14 ++++++++++++ arch/arm/boot/dts/vf610-colibri.dtsi | 33 +++++++++++++++++++++++++-- 2 files changed, 45 insertions(+), 2 deletions(-) -- 1.7.9.5 ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 1/2] ARM: dts: vf610-colibri: Add PWM support 2014-09-19 13:38 ` Bhuvanchandra DV @ 2014-09-19 13:38 ` Bhuvanchandra DV -1 siblings, 0 replies; 14+ messages in thread From: Bhuvanchandra DV @ 2014-09-19 13:38 UTC (permalink / raw) To: linux-arm-kernel The Colibri standard defines four pins as PWM outputs, two of them (PWM A and C) are routed to FTM instance 0 and the other two (PWM B and D) are routed to FTM instance 1. Hence enable both FTM instances for the Colibri module and mux the four pins accordingly. Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> --- arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 8 +++++++ arch/arm/boot/dts/vf610-colibri.dtsi | 31 +++++++++++++++++++++++---- 2 files changed, 35 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts index 7fb3066..00f63d9 100644 --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts @@ -33,6 +33,14 @@ status = "okay"; }; +&pwm0 { + status = "okay"; +}; + +&pwm1 { + status = "okay"; +}; + &uart0 { status = "okay"; }; diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi index 0cd8343..560cd69 100644 --- a/arch/arm/boot/dts/vf610-colibri.dtsi +++ b/arch/arm/boot/dts/vf610-colibri.dtsi @@ -13,10 +13,6 @@ model = "Toradex Colibri VF61 COM"; compatible = "toradex,vf610-colibri_vf61", "fsl,vf610"; - memory { - reg = <0x80000000 0x10000000>; - }; - clocks { enet_ext { compatible = "fixed-clock"; @@ -25,6 +21,9 @@ }; }; + memory { + reg = <0x80000000 0x10000000>; + }; }; &esdhc1 { @@ -44,6 +43,16 @@ arm,tag-latency = <3 2 3>; }; +&pwm0 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm0>; +}; + +&pwm1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm1>; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart0>; @@ -97,6 +106,20 @@ >; }; + pinctrl_pwm0: pwm0grp { + fsl,pins = < + VF610_PAD_PTB0__FTM0_CH0 0x1182 + VF610_PAD_PTB1__FTM0_CH1 0x1182 + >; + }; + + pinctrl_pwm1: pwm1grp { + fsl,pins = < + VF610_PAD_PTB8__FTM1_CH0 0x1182 + VF610_PAD_PTB9__FTM1_CH1 0x1182 + >; + }; + pinctrl_uart0: uart0grp { fsl,pins = < VF610_PAD_PTB10__UART0_TX 0x21a2 -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 1/2] ARM: dts: vf610-colibri: Add PWM support @ 2014-09-19 13:38 ` Bhuvanchandra DV 0 siblings, 0 replies; 14+ messages in thread From: Bhuvanchandra DV @ 2014-09-19 13:38 UTC (permalink / raw) To: shawn.guo; +Cc: stefan, linux, linux-arm-kernel, linux-kernel, Bhuvanchandra DV The Colibri standard defines four pins as PWM outputs, two of them (PWM A and C) are routed to FTM instance 0 and the other two (PWM B and D) are routed to FTM instance 1. Hence enable both FTM instances for the Colibri module and mux the four pins accordingly. Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> --- arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 8 +++++++ arch/arm/boot/dts/vf610-colibri.dtsi | 31 +++++++++++++++++++++++---- 2 files changed, 35 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts index 7fb3066..00f63d9 100644 --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts @@ -33,6 +33,14 @@ status = "okay"; }; +&pwm0 { + status = "okay"; +}; + +&pwm1 { + status = "okay"; +}; + &uart0 { status = "okay"; }; diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi index 0cd8343..560cd69 100644 --- a/arch/arm/boot/dts/vf610-colibri.dtsi +++ b/arch/arm/boot/dts/vf610-colibri.dtsi @@ -13,10 +13,6 @@ model = "Toradex Colibri VF61 COM"; compatible = "toradex,vf610-colibri_vf61", "fsl,vf610"; - memory { - reg = <0x80000000 0x10000000>; - }; - clocks { enet_ext { compatible = "fixed-clock"; @@ -25,6 +21,9 @@ }; }; + memory { + reg = <0x80000000 0x10000000>; + }; }; &esdhc1 { @@ -44,6 +43,16 @@ arm,tag-latency = <3 2 3>; }; +&pwm0 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm0>; +}; + +&pwm1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm1>; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart0>; @@ -97,6 +106,20 @@ >; }; + pinctrl_pwm0: pwm0grp { + fsl,pins = < + VF610_PAD_PTB0__FTM0_CH0 0x1182 + VF610_PAD_PTB1__FTM0_CH1 0x1182 + >; + }; + + pinctrl_pwm1: pwm1grp { + fsl,pins = < + VF610_PAD_PTB8__FTM1_CH0 0x1182 + VF610_PAD_PTB9__FTM1_CH1 0x1182 + >; + }; + pinctrl_uart0: uart0grp { fsl,pins = < VF610_PAD_PTB10__UART0_TX 0x21a2 -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 1/2] ARM: dts: vf610-colibri: Add PWM support 2014-09-19 13:38 ` Bhuvanchandra DV @ 2014-09-19 16:00 ` Stefan Agner -1 siblings, 0 replies; 14+ messages in thread From: Stefan Agner @ 2014-09-19 16:00 UTC (permalink / raw) To: linux-arm-kernel Am 2014-09-19 15:38, schrieb Bhuvanchandra DV: > The Colibri standard defines four pins as PWM outputs, two of them (PWM > A and C) are routed to FTM instance 0 and the other two (PWM B and D) > are routed to FTM instance 1. Hence enable both FTM instances for the > Colibri module and mux the four pins accordingly. > > Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> > --- > arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 8 +++++++ > arch/arm/boot/dts/vf610-colibri.dtsi | 31 +++++++++++++++++++++++---- > 2 files changed, 35 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > index 7fb3066..00f63d9 100644 > --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > @@ -33,6 +33,14 @@ > status = "okay"; > }; > > +&pwm0 { > + status = "okay"; > +}; > + > +&pwm1 { > + status = "okay"; > +}; > + > &uart0 { > status = "okay"; > }; > diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi > b/arch/arm/boot/dts/vf610-colibri.dtsi > index 0cd8343..560cd69 100644 > --- a/arch/arm/boot/dts/vf610-colibri.dtsi > +++ b/arch/arm/boot/dts/vf610-colibri.dtsi > @@ -13,10 +13,6 @@ > model = "Toradex Colibri VF61 COM"; > compatible = "toradex,vf610-colibri_vf61", "fsl,vf610"; > > - memory { > - reg = <0x80000000 0x10000000>; > - }; > - > clocks { > enet_ext { > compatible = "fixed-clock"; > @@ -25,6 +21,9 @@ > }; > }; > > + memory { > + reg = <0x80000000 0x10000000>; > + }; Memory is a bit an exception here: In almost all device tree this is the first node after model/compatible. Also, it's generally not allowed to make changes outside of the topic (PWM in this case)... Hence I would drop this change. The rest Acked-By: Stefan Agner <stefan@agner.ch> > }; > > &esdhc1 { > @@ -44,6 +43,16 @@ > arm,tag-latency = <3 2 3>; > }; > > +&pwm0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pwm0>; > +}; > + > +&pwm1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pwm1>; > +}; > + > &uart0 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_uart0>; > @@ -97,6 +106,20 @@ > >; > }; > > + pinctrl_pwm0: pwm0grp { > + fsl,pins = < > + VF610_PAD_PTB0__FTM0_CH0 0x1182 > + VF610_PAD_PTB1__FTM0_CH1 0x1182 > + >; > + }; > + > + pinctrl_pwm1: pwm1grp { > + fsl,pins = < > + VF610_PAD_PTB8__FTM1_CH0 0x1182 > + VF610_PAD_PTB9__FTM1_CH1 0x1182 > + >; > + }; > + > pinctrl_uart0: uart0grp { > fsl,pins = < > VF610_PAD_PTB10__UART0_TX 0x21a2 ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: vf610-colibri: Add PWM support @ 2014-09-19 16:00 ` Stefan Agner 0 siblings, 0 replies; 14+ messages in thread From: Stefan Agner @ 2014-09-19 16:00 UTC (permalink / raw) To: Bhuvanchandra DV; +Cc: shawn.guo, linux, linux-arm-kernel, linux-kernel Am 2014-09-19 15:38, schrieb Bhuvanchandra DV: > The Colibri standard defines four pins as PWM outputs, two of them (PWM > A and C) are routed to FTM instance 0 and the other two (PWM B and D) > are routed to FTM instance 1. Hence enable both FTM instances for the > Colibri module and mux the four pins accordingly. > > Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> > --- > arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 8 +++++++ > arch/arm/boot/dts/vf610-colibri.dtsi | 31 +++++++++++++++++++++++---- > 2 files changed, 35 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > index 7fb3066..00f63d9 100644 > --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > @@ -33,6 +33,14 @@ > status = "okay"; > }; > > +&pwm0 { > + status = "okay"; > +}; > + > +&pwm1 { > + status = "okay"; > +}; > + > &uart0 { > status = "okay"; > }; > diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi > b/arch/arm/boot/dts/vf610-colibri.dtsi > index 0cd8343..560cd69 100644 > --- a/arch/arm/boot/dts/vf610-colibri.dtsi > +++ b/arch/arm/boot/dts/vf610-colibri.dtsi > @@ -13,10 +13,6 @@ > model = "Toradex Colibri VF61 COM"; > compatible = "toradex,vf610-colibri_vf61", "fsl,vf610"; > > - memory { > - reg = <0x80000000 0x10000000>; > - }; > - > clocks { > enet_ext { > compatible = "fixed-clock"; > @@ -25,6 +21,9 @@ > }; > }; > > + memory { > + reg = <0x80000000 0x10000000>; > + }; Memory is a bit an exception here: In almost all device tree this is the first node after model/compatible. Also, it's generally not allowed to make changes outside of the topic (PWM in this case)... Hence I would drop this change. The rest Acked-By: Stefan Agner <stefan@agner.ch> > }; > > &esdhc1 { > @@ -44,6 +43,16 @@ > arm,tag-latency = <3 2 3>; > }; > > +&pwm0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pwm0>; > +}; > + > +&pwm1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pwm1>; > +}; > + > &uart0 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_uart0>; > @@ -97,6 +106,20 @@ > >; > }; > > + pinctrl_pwm0: pwm0grp { > + fsl,pins = < > + VF610_PAD_PTB0__FTM0_CH0 0x1182 > + VF610_PAD_PTB1__FTM0_CH1 0x1182 > + >; > + }; > + > + pinctrl_pwm1: pwm1grp { > + fsl,pins = < > + VF610_PAD_PTB8__FTM1_CH0 0x1182 > + VF610_PAD_PTB9__FTM1_CH1 0x1182 > + >; > + }; > + > pinctrl_uart0: uart0grp { > fsl,pins = < > VF610_PAD_PTB10__UART0_TX 0x21a2 ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 1/2] ARM: dts: vf610-colibri: Add PWM support 2014-09-19 16:00 ` Stefan Agner @ 2014-09-22 4:38 ` Bhuvanchandra DV -1 siblings, 0 replies; 14+ messages in thread From: Bhuvanchandra DV @ 2014-09-22 4:38 UTC (permalink / raw) To: linux-arm-kernel On Friday 19 September 2014 09:30 PM, Stefan Agner wrote: > Am 2014-09-19 15:38, schrieb Bhuvanchandra DV: >> The Colibri standard defines four pins as PWM outputs, two of them (PWM >> A and C) are routed to FTM instance 0 and the other two (PWM B and D) >> are routed to FTM instance 1. Hence enable both FTM instances for the >> Colibri module and mux the four pins accordingly. >> >> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> >> --- >> arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 8 +++++++ >> arch/arm/boot/dts/vf610-colibri.dtsi | 31 +++++++++++++++++++++++---- >> 2 files changed, 35 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> index 7fb3066..00f63d9 100644 >> --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> @@ -33,6 +33,14 @@ >> status = "okay"; >> }; >> >> +&pwm0 { >> + status = "okay"; >> +}; >> + >> +&pwm1 { >> + status = "okay"; >> +}; >> + >> &uart0 { >> status = "okay"; >> }; >> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi >> b/arch/arm/boot/dts/vf610-colibri.dtsi >> index 0cd8343..560cd69 100644 >> --- a/arch/arm/boot/dts/vf610-colibri.dtsi >> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi >> @@ -13,10 +13,6 @@ >> model = "Toradex Colibri VF61 COM"; >> compatible = "toradex,vf610-colibri_vf61", "fsl,vf610"; >> >> - memory { >> - reg = <0x80000000 0x10000000>; >> - }; >> - >> clocks { >> enet_ext { >> compatible = "fixed-clock"; >> @@ -25,6 +21,9 @@ >> }; >> }; >> >> + memory { >> + reg = <0x80000000 0x10000000>; >> + }; > Memory is a bit an exception here: In almost all device tree this is the > first node after model/compatible. Also, it's generally not allowed to > make changes outside of the topic (PWM in this case)... Hence I would > drop this change. > > The rest > Acked-By: Stefan Agner <stefan@agner.ch> OK. Will drop the change. >> }; >> >> &esdhc1 { >> @@ -44,6 +43,16 @@ >> arm,tag-latency = <3 2 3>; >> }; >> >> +&pwm0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_pwm0>; >> +}; >> + >> +&pwm1 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_pwm1>; >> +}; >> + >> &uart0 { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_uart0>; >> @@ -97,6 +106,20 @@ >> >; >> }; >> >> + pinctrl_pwm0: pwm0grp { >> + fsl,pins = < >> + VF610_PAD_PTB0__FTM0_CH0 0x1182 >> + VF610_PAD_PTB1__FTM0_CH1 0x1182 >> + >; >> + }; >> + >> + pinctrl_pwm1: pwm1grp { >> + fsl,pins = < >> + VF610_PAD_PTB8__FTM1_CH0 0x1182 >> + VF610_PAD_PTB9__FTM1_CH1 0x1182 >> + >; >> + }; >> + >> pinctrl_uart0: uart0grp { >> fsl,pins = < >> VF610_PAD_PTB10__UART0_TX 0x21a2 ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: vf610-colibri: Add PWM support @ 2014-09-22 4:38 ` Bhuvanchandra DV 0 siblings, 0 replies; 14+ messages in thread From: Bhuvanchandra DV @ 2014-09-22 4:38 UTC (permalink / raw) To: Stefan Agner; +Cc: shawn.guo, linux, linux-arm-kernel, linux-kernel On Friday 19 September 2014 09:30 PM, Stefan Agner wrote: > Am 2014-09-19 15:38, schrieb Bhuvanchandra DV: >> The Colibri standard defines four pins as PWM outputs, two of them (PWM >> A and C) are routed to FTM instance 0 and the other two (PWM B and D) >> are routed to FTM instance 1. Hence enable both FTM instances for the >> Colibri module and mux the four pins accordingly. >> >> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> >> --- >> arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 8 +++++++ >> arch/arm/boot/dts/vf610-colibri.dtsi | 31 +++++++++++++++++++++++---- >> 2 files changed, 35 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> index 7fb3066..00f63d9 100644 >> --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> @@ -33,6 +33,14 @@ >> status = "okay"; >> }; >> >> +&pwm0 { >> + status = "okay"; >> +}; >> + >> +&pwm1 { >> + status = "okay"; >> +}; >> + >> &uart0 { >> status = "okay"; >> }; >> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi >> b/arch/arm/boot/dts/vf610-colibri.dtsi >> index 0cd8343..560cd69 100644 >> --- a/arch/arm/boot/dts/vf610-colibri.dtsi >> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi >> @@ -13,10 +13,6 @@ >> model = "Toradex Colibri VF61 COM"; >> compatible = "toradex,vf610-colibri_vf61", "fsl,vf610"; >> >> - memory { >> - reg = <0x80000000 0x10000000>; >> - }; >> - >> clocks { >> enet_ext { >> compatible = "fixed-clock"; >> @@ -25,6 +21,9 @@ >> }; >> }; >> >> + memory { >> + reg = <0x80000000 0x10000000>; >> + }; > Memory is a bit an exception here: In almost all device tree this is the > first node after model/compatible. Also, it's generally not allowed to > make changes outside of the topic (PWM in this case)... Hence I would > drop this change. > > The rest > Acked-By: Stefan Agner <stefan@agner.ch> OK. Will drop the change. >> }; >> >> &esdhc1 { >> @@ -44,6 +43,16 @@ >> arm,tag-latency = <3 2 3>; >> }; >> >> +&pwm0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_pwm0>; >> +}; >> + >> +&pwm1 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_pwm1>; >> +}; >> + >> &uart0 { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_uart0>; >> @@ -97,6 +106,20 @@ >> >; >> }; >> >> + pinctrl_pwm0: pwm0grp { >> + fsl,pins = < >> + VF610_PAD_PTB0__FTM0_CH0 0x1182 >> + VF610_PAD_PTB1__FTM0_CH1 0x1182 >> + >; >> + }; >> + >> + pinctrl_pwm1: pwm1grp { >> + fsl,pins = < >> + VF610_PAD_PTB8__FTM1_CH0 0x1182 >> + VF610_PAD_PTB9__FTM1_CH1 0x1182 >> + >; >> + }; >> + >> pinctrl_uart0: uart0grp { >> fsl,pins = < >> VF610_PAD_PTB10__UART0_TX 0x21a2 ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] ARM: dts: vf610-colibri: Add backlight support 2014-09-19 13:38 ` Bhuvanchandra DV @ 2014-09-19 13:38 ` Bhuvanchandra DV -1 siblings, 0 replies; 14+ messages in thread From: Bhuvanchandra DV @ 2014-09-19 13:38 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> --- arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 6 ++++++ arch/arm/boot/dts/vf610-colibri.dtsi | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts index 00f63d9..711cf82 100644 --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts @@ -19,6 +19,12 @@ }; }; +&bl { + brightness-levels = <0 4 8 16 32 64 128 255>; + default-brightness-level = <6>; + status = "okay"; +}; + &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>; diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi index 560cd69..20b1c15 100644 --- a/arch/arm/boot/dts/vf610-colibri.dtsi +++ b/arch/arm/boot/dts/vf610-colibri.dtsi @@ -13,6 +13,12 @@ model = "Toradex Colibri VF61 COM"; compatible = "toradex,vf610-colibri_vf61", "fsl,vf610"; + bl: backlight { + compitable = "pwm-backlight"; + pwms = <&pwm0 0 5000000 0>; + status = "disabled"; + }; + clocks { enet_ext { compatible = "fixed-clock"; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] ARM: dts: vf610-colibri: Add backlight support @ 2014-09-19 13:38 ` Bhuvanchandra DV 0 siblings, 0 replies; 14+ messages in thread From: Bhuvanchandra DV @ 2014-09-19 13:38 UTC (permalink / raw) To: shawn.guo; +Cc: stefan, linux, linux-arm-kernel, linux-kernel, Bhuvanchandra DV Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> --- arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 6 ++++++ arch/arm/boot/dts/vf610-colibri.dtsi | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts index 00f63d9..711cf82 100644 --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts @@ -19,6 +19,12 @@ }; }; +&bl { + brightness-levels = <0 4 8 16 32 64 128 255>; + default-brightness-level = <6>; + status = "okay"; +}; + &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>; diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi index 560cd69..20b1c15 100644 --- a/arch/arm/boot/dts/vf610-colibri.dtsi +++ b/arch/arm/boot/dts/vf610-colibri.dtsi @@ -13,6 +13,12 @@ model = "Toradex Colibri VF61 COM"; compatible = "toradex,vf610-colibri_vf61", "fsl,vf610"; + bl: backlight { + compitable = "pwm-backlight"; + pwms = <&pwm0 0 5000000 0>; + status = "disabled"; + }; + clocks { enet_ext { compatible = "fixed-clock"; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] ARM: dts: vf610-colibri: Add backlight support 2014-09-19 13:38 ` Bhuvanchandra DV @ 2014-09-19 16:03 ` Stefan Agner -1 siblings, 0 replies; 14+ messages in thread From: Stefan Agner @ 2014-09-19 16:03 UTC (permalink / raw) To: linux-arm-kernel Am 2014-09-19 15:38, schrieb Bhuvanchandra DV: > Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> > --- > arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 6 ++++++ > arch/arm/boot/dts/vf610-colibri.dtsi | 6 ++++++ > 2 files changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > index 00f63d9..711cf82 100644 > --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > @@ -19,6 +19,12 @@ > }; > }; > > +&bl { > + brightness-levels = <0 4 8 16 32 64 128 255>; > + default-brightness-level = <6>; > + status = "okay"; > +}; > + > &esdhc1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_esdhc1>; > diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi > b/arch/arm/boot/dts/vf610-colibri.dtsi > index 560cd69..20b1c15 100644 > --- a/arch/arm/boot/dts/vf610-colibri.dtsi > +++ b/arch/arm/boot/dts/vf610-colibri.dtsi > @@ -13,6 +13,12 @@ > model = "Toradex Colibri VF61 COM"; > compatible = "toradex,vf610-colibri_vf61", "fsl,vf610"; > > + bl: backlight { > + compitable = "pwm-backlight"; > + pwms = <&pwm0 0 5000000 0>; > + status = "disabled"; > + }; > + Typo, "compitable" is not a valid property... When this is fixed, Acked-By: Stefan Agner <stefan@agner.ch> > clocks { > enet_ext { > compatible = "fixed-clock"; ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: vf610-colibri: Add backlight support @ 2014-09-19 16:03 ` Stefan Agner 0 siblings, 0 replies; 14+ messages in thread From: Stefan Agner @ 2014-09-19 16:03 UTC (permalink / raw) To: Bhuvanchandra DV; +Cc: shawn.guo, linux, linux-arm-kernel, linux-kernel Am 2014-09-19 15:38, schrieb Bhuvanchandra DV: > Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> > --- > arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 6 ++++++ > arch/arm/boot/dts/vf610-colibri.dtsi | 6 ++++++ > 2 files changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > index 00f63d9..711cf82 100644 > --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts > @@ -19,6 +19,12 @@ > }; > }; > > +&bl { > + brightness-levels = <0 4 8 16 32 64 128 255>; > + default-brightness-level = <6>; > + status = "okay"; > +}; > + > &esdhc1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_esdhc1>; > diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi > b/arch/arm/boot/dts/vf610-colibri.dtsi > index 560cd69..20b1c15 100644 > --- a/arch/arm/boot/dts/vf610-colibri.dtsi > +++ b/arch/arm/boot/dts/vf610-colibri.dtsi > @@ -13,6 +13,12 @@ > model = "Toradex Colibri VF61 COM"; > compatible = "toradex,vf610-colibri_vf61", "fsl,vf610"; > > + bl: backlight { > + compitable = "pwm-backlight"; > + pwms = <&pwm0 0 5000000 0>; > + status = "disabled"; > + }; > + Typo, "compitable" is not a valid property... When this is fixed, Acked-By: Stefan Agner <stefan@agner.ch> > clocks { > enet_ext { > compatible = "fixed-clock"; ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] ARM: dts: vf610-colibri: Add backlight support 2014-09-19 16:03 ` Stefan Agner @ 2014-09-22 4:49 ` Bhuvanchandra DV -1 siblings, 0 replies; 14+ messages in thread From: Bhuvanchandra DV @ 2014-09-22 4:49 UTC (permalink / raw) To: linux-arm-kernel On Friday 19 September 2014 09:33 PM, Stefan Agner wrote: > Am 2014-09-19 15:38, schrieb Bhuvanchandra DV: >> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> >> --- >> arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 6 ++++++ >> arch/arm/boot/dts/vf610-colibri.dtsi | 6 ++++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> index 00f63d9..711cf82 100644 >> --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> @@ -19,6 +19,12 @@ >> }; >> }; >> >> +&bl { >> + brightness-levels = <0 4 8 16 32 64 128 255>; >> + default-brightness-level = <6>; >> + status = "okay"; >> +}; >> + >> &esdhc1 { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_esdhc1>; >> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi >> b/arch/arm/boot/dts/vf610-colibri.dtsi >> index 560cd69..20b1c15 100644 >> --- a/arch/arm/boot/dts/vf610-colibri.dtsi >> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi >> @@ -13,6 +13,12 @@ >> model = "Toradex Colibri VF61 COM"; >> compatible = "toradex,vf610-colibri_vf61", "fsl,vf610"; >> >> + bl: backlight { >> + compitable = "pwm-backlight"; >> + pwms = <&pwm0 0 5000000 0>; >> + status = "disabled"; >> + }; >> + > Typo, "compitable" is not a valid property... > > When this is fixed, > Acked-By: Stefan Agner <stefan@agner.ch> Thanks for pointing it out. Will update accordingly. >> clocks { >> enet_ext { >> compatible = "fixed-clock"; ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: vf610-colibri: Add backlight support @ 2014-09-22 4:49 ` Bhuvanchandra DV 0 siblings, 0 replies; 14+ messages in thread From: Bhuvanchandra DV @ 2014-09-22 4:49 UTC (permalink / raw) To: Stefan Agner; +Cc: shawn.guo, linux, linux-arm-kernel, linux-kernel On Friday 19 September 2014 09:33 PM, Stefan Agner wrote: > Am 2014-09-19 15:38, schrieb Bhuvanchandra DV: >> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> >> --- >> arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 6 ++++++ >> arch/arm/boot/dts/vf610-colibri.dtsi | 6 ++++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> index 00f63d9..711cf82 100644 >> --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts >> @@ -19,6 +19,12 @@ >> }; >> }; >> >> +&bl { >> + brightness-levels = <0 4 8 16 32 64 128 255>; >> + default-brightness-level = <6>; >> + status = "okay"; >> +}; >> + >> &esdhc1 { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_esdhc1>; >> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi >> b/arch/arm/boot/dts/vf610-colibri.dtsi >> index 560cd69..20b1c15 100644 >> --- a/arch/arm/boot/dts/vf610-colibri.dtsi >> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi >> @@ -13,6 +13,12 @@ >> model = "Toradex Colibri VF61 COM"; >> compatible = "toradex,vf610-colibri_vf61", "fsl,vf610"; >> >> + bl: backlight { >> + compitable = "pwm-backlight"; >> + pwms = <&pwm0 0 5000000 0>; >> + status = "disabled"; >> + }; >> + > Typo, "compitable" is not a valid property... > > When this is fixed, > Acked-By: Stefan Agner <stefan@agner.ch> Thanks for pointing it out. Will update accordingly. >> clocks { >> enet_ext { >> compatible = "fixed-clock"; ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2014-09-22 4:50 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-09-19 13:38 [PATCH v2 0/2] Add PWM and backlight support for Colibri VF61 modules Bhuvanchandra DV 2014-09-19 13:38 ` Bhuvanchandra DV 2014-09-19 13:38 ` [PATCH v2 1/2] ARM: dts: vf610-colibri: Add PWM support Bhuvanchandra DV 2014-09-19 13:38 ` Bhuvanchandra DV 2014-09-19 16:00 ` Stefan Agner 2014-09-19 16:00 ` Stefan Agner 2014-09-22 4:38 ` Bhuvanchandra DV 2014-09-22 4:38 ` Bhuvanchandra DV 2014-09-19 13:38 ` [PATCH v2 2/2] ARM: dts: vf610-colibri: Add backlight support Bhuvanchandra DV 2014-09-19 13:38 ` Bhuvanchandra DV 2014-09-19 16:03 ` Stefan Agner 2014-09-19 16:03 ` Stefan Agner 2014-09-22 4:49 ` Bhuvanchandra DV 2014-09-22 4:49 ` Bhuvanchandra DV
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.