From: Zefan Li <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
keescook@chromium.org,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Subject: Re: [PATCH 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant
Date: Mon, 22 Sep 2014 12:44:51 +0800 [thread overview]
Message-ID: <541FA943.5070009@huawei.com> (raw)
In-Reply-To: <20140922040214.GE23583@htj.dyndns.org>
On 2014/9/22 12:02, Tejun Heo wrote:
> On Mon, Sep 22, 2014 at 11:50:46AM +0800, Zefan Li wrote:
>> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
>>
>> Commit 1d4457f99928 ("sched: move no_new_privs into new atomic flags")
>> defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing
>> because it is used as bit number. Redefine it as decimal bit number.
>
> It's also changing the bit position, which is fine but should be
> mentioned in the description.
>
I've resent the patch with changelog updated.
WARNING: multiple messages have this Message-ID (diff)
From: Zefan Li <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>, <keescook@chromium.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Subject: Re: [PATCH 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant
Date: Mon, 22 Sep 2014 12:44:51 +0800 [thread overview]
Message-ID: <541FA943.5070009@huawei.com> (raw)
In-Reply-To: <20140922040214.GE23583@htj.dyndns.org>
On 2014/9/22 12:02, Tejun Heo wrote:
> On Mon, Sep 22, 2014 at 11:50:46AM +0800, Zefan Li wrote:
>> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
>>
>> Commit 1d4457f99928 ("sched: move no_new_privs into new atomic flags")
>> defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing
>> because it is used as bit number. Redefine it as decimal bit number.
>
> It's also changing the bit position, which is fine but should be
> mentioned in the description.
>
I've resent the patch with changelog updated.
next prev parent reply other threads:[~2014-09-22 4:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 3:50 [PATCH 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant Zefan Li
2014-09-22 3:50 ` Zefan Li
[not found] ` <541F9C96.10705-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-09-22 3:51 ` [PATCH 2/3] sched: add a macro to define bitops for task atomic flags Zefan Li
2014-09-22 3:51 ` Zefan Li
[not found] ` <541F9CD4.5040407-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-09-22 11:45 ` Peter Zijlstra
2014-09-22 11:45 ` Peter Zijlstra
2014-09-22 4:02 ` [PATCH 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant Tejun Heo
2014-09-22 4:02 ` Tejun Heo
2014-09-22 4:44 ` Zefan Li [this message]
2014-09-22 4:44 ` Zefan Li
2014-09-22 3:52 ` [PATCH 3/3] cpuset: PF_SPREAD_PAGE and PF_SPREAD_SLAB should be atomic flags Zefan Li
2014-09-22 3:52 ` Zefan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541FA943.5070009@huawei.com \
--to=lizefan@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.