From: Guenter Roeck <linux@roeck-us.net>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: "wim@iguana.be" <wim@iguana.be>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] watchdog: dw_wdt: add restart handler support
Date: Tue, 23 Sep 2014 18:40:51 -0700 [thread overview]
Message-ID: <54222123.2050703@roeck-us.net> (raw)
In-Reply-To: <20140924091101.60e065cd@xhacker>
On 09/23/2014 06:11 PM, Jisheng Zhang wrote:
[ ... ]
>>> + dw_wdt.restart_handler.notifier_call = dw_wdt_restart_handle;
>>> + dw_wdt.restart_handler.priority = 128;
>>> + ret = register_restart_handler(&dw_wdt.restart_handler);
>>> + if (ret)
>>> + pr_warn("cannot register restart handler\n");
>>
>> Please use dev_warn(&pdev->dev, ...).
>
> Yep, that's what I thought when patching the code. But the original source is
> using pr_*(), so I use pr_warn() to keep unification. Is there any better
> solution?
>
Good point. Makes sense, then, to leave that as cleanup.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] watchdog: dw_wdt: add restart handler support
Date: Tue, 23 Sep 2014 18:40:51 -0700 [thread overview]
Message-ID: <54222123.2050703@roeck-us.net> (raw)
In-Reply-To: <20140924091101.60e065cd@xhacker>
On 09/23/2014 06:11 PM, Jisheng Zhang wrote:
[ ... ]
>>> + dw_wdt.restart_handler.notifier_call = dw_wdt_restart_handle;
>>> + dw_wdt.restart_handler.priority = 128;
>>> + ret = register_restart_handler(&dw_wdt.restart_handler);
>>> + if (ret)
>>> + pr_warn("cannot register restart handler\n");
>>
>> Please use dev_warn(&pdev->dev, ...).
>
> Yep, that's what I thought when patching the code. But the original source is
> using pr_*(), so I use pr_warn() to keep unification. Is there any better
> solution?
>
Good point. Makes sense, then, to leave that as cleanup.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
next prev parent reply other threads:[~2014-09-24 1:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 7:42 [PATCH v2 0/2] watchdog: dw_wdt: one bug fix and restart handler support Jisheng Zhang
2014-09-23 7:42 ` Jisheng Zhang
2014-09-23 7:42 ` [PATCH v2 1/2] watchdog: dw_wdt: initialise TOP_INIT in dw_wdt_set_top() Jisheng Zhang
2014-09-23 7:42 ` Jisheng Zhang
2014-09-23 18:27 ` Guenter Roeck
2014-09-23 18:27 ` Guenter Roeck
2014-09-23 7:42 ` [PATCH v2 2/2] watchdog: dw_wdt: add restart handler support Jisheng Zhang
2014-09-23 7:42 ` Jisheng Zhang
2014-09-23 18:31 ` Guenter Roeck
2014-09-23 18:31 ` Guenter Roeck
2014-09-24 1:11 ` Jisheng Zhang
2014-09-24 1:11 ` Jisheng Zhang
2014-09-24 1:40 ` Guenter Roeck [this message]
2014-09-24 1:40 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54222123.2050703@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.