From: Tanya Brokhman <tlinder@codeaurora.org>
To: Richard Weinberger <richard@nod.at>,
Artem Bityutskiy <dedekind1@gmail.com>
Cc: linux-arm-msm@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: ubi: Extend UBI layer debug/messaging capabilities
Date: Sun, 28 Sep 2014 11:24:36 +0300 [thread overview]
Message-ID: <5427C5C4.40508@codeaurora.org> (raw)
In-Reply-To: <5427C046.5030608@nod.at>
On 9/28/2014 11:01 AM, Richard Weinberger wrote:
> Tanya,
>
> Am 28.09.2014 08:36, schrieb Tanya Brokhman:
>> If there is more then one UBI device mounted, there is no way to
>> distinguish between messages from different UBI devices.
>> Add device number to all ubi layer message types.
>>
>>
>> Signed-off-by: Tanya Brokhman <tlinder@codeaurora.org>
>
> Artem's mail is dedekind1@ not dedeking1@. :)
oops.... sorry about that. thanks for the fix.
> Anyway, instead of passing ubi->ubi_num down to every log function you can
> just pass the ubi object itself and let the log function access ->ubi_num.
This is how I first implemented this patch. But then I cam across some
ubi_err prints during the init process (in build.c ubi_init()) when we
still don't have the ubi structure, so we need to pass some number to
the message. I overcame this by using UBI_MAX_DEVICES.
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: Tanya Brokhman <tlinder@codeaurora.org>
To: Richard Weinberger <richard@nod.at>,
Artem Bityutskiy <dedekind1@gmail.com>
Cc: linux-arm-msm@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: ubi: Extend UBI layer debug/messaging capabilities
Date: Sun, 28 Sep 2014 11:24:36 +0300 [thread overview]
Message-ID: <5427C5C4.40508@codeaurora.org> (raw)
In-Reply-To: <5427C046.5030608@nod.at>
On 9/28/2014 11:01 AM, Richard Weinberger wrote:
> Tanya,
>
> Am 28.09.2014 08:36, schrieb Tanya Brokhman:
>> If there is more then one UBI device mounted, there is no way to
>> distinguish between messages from different UBI devices.
>> Add device number to all ubi layer message types.
>>
>>
>> Signed-off-by: Tanya Brokhman <tlinder@codeaurora.org>
>
> Artem's mail is dedekind1@ not dedeking1@. :)
oops.... sorry about that. thanks for the fix.
> Anyway, instead of passing ubi->ubi_num down to every log function you can
> just pass the ubi object itself and let the log function access ->ubi_num.
This is how I first implemented this patch. But then I cam across some
ubi_err prints during the init process (in build.c ubi_init()) when we
still don't have the ubi structure, so we need to pass some number to
the message. I overcame this by using UBI_MAX_DEVICES.
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-09-28 8:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-28 6:36 [PATCH] mtd: ubi: Extend UBI layer debug/messaging capabilities Tanya Brokhman
2014-09-28 6:36 ` Tanya Brokhman
2014-09-28 6:36 ` Tanya Brokhman
2014-09-28 8:01 ` Richard Weinberger
2014-09-28 8:01 ` Richard Weinberger
2014-09-28 8:01 ` Richard Weinberger
2014-09-28 8:24 ` Tanya Brokhman [this message]
2014-09-28 8:24 ` Tanya Brokhman
2014-09-28 12:15 ` Artem Bityutskiy
2014-09-28 12:15 ` Artem Bityutskiy
2014-09-28 12:14 ` Artem Bityutskiy
2014-09-28 12:14 ` Artem Bityutskiy
2014-09-28 12:01 ` Artem Bityutskiy
2014-09-28 12:01 ` Artem Bityutskiy
2014-09-30 8:02 ` Tanya Brokhman
2014-09-30 8:02 ` Tanya Brokhman
2014-09-29 10:50 ` Kiran Padwal
2014-09-29 10:50 ` Kiran Padwal
2014-09-29 12:01 ` Richard Weinberger
2014-09-29 12:01 ` Richard Weinberger
2014-09-29 12:32 ` Kiran Padwal
2014-09-29 12:32 ` Kiran Padwal
2014-09-29 12:37 ` Richard Weinberger
2014-09-29 12:37 ` Richard Weinberger
2014-09-30 7:30 ` Tanya Brokhman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5427C5C4.40508@codeaurora.org \
--to=tlinder@codeaurora.org \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.