Re: [PATCH] mtd: ubi: Extend UBI layer debug/messaging capabilities

From: Tanya Brokhman <tlinder@codeaurora.org>
To: Richard Weinberger <richard@nod.at>,
	Kiran Padwal <kiran.padwal@smartplayin.com>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
	linux-arm-msm@vger.kernel.org,
	open list <linux-kernel@vger.kernel.org>,
	linux-mtd@lists.infradead.org,
	Kiran Padwal <kiran.padwal21@gmail.com>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: ubi: Extend UBI layer debug/messaging capabilities
Date: Tue, 30 Sep 2014 10:30:00 +0300	[thread overview]
Message-ID: <542A5BF8.3030103@codeaurora.org> (raw)
In-Reply-To: <54295274.4020805@nod.at>

On 9/29/2014 3:37 PM, Richard Weinberger wrote:
> Am 29.09.2014 14:32, schrieb Kiran Padwal:
>> On Monday 29 September 2014 05:31 PM, Richard Weinberger wrote:
>>> Am 29.09.2014 12:50, schrieb Kiran Padwal:
>>>> Hi Tanya,
>>>>
>>>> On Sunday 28 September 2014 12:06 PM, Tanya Brokhman wrote:
>>>>> If there is more then one UBI device mounted, there is no way to
>>>>> distinguish between messages from different UBI devices.
>>>>> Add device number to all ubi layer message types.
>>>>>
>>>>>
>>>>> Signed-off-by: Tanya Brokhman <tlinder@codeaurora.org>
>>>>>
>>>>> ---
>>>>>   drivers/mtd/ubi/attach.c  | 138 ++++++++++++++++++++----------------
>>>>>   drivers/mtd/ubi/build.c   | 130 ++++++++++++++++++++--------------
>>>>>   drivers/mtd/ubi/cdev.c    |  37 +++++-----
>>>>>   drivers/mtd/ubi/debug.c   |   9 +--
>>>>>   drivers/mtd/ubi/eba.c     |  54 +++++++-------
>>>>>   drivers/mtd/ubi/fastmap.c | 108 ++++++++++++++++------------
>>>>>   drivers/mtd/ubi/io.c      | 177 +++++++++++++++++++++++++++-------------------
>>>>>   drivers/mtd/ubi/kapi.c    |   6 +-
>>>>>   drivers/mtd/ubi/misc.c    |   6 +-
>>>>>   drivers/mtd/ubi/ubi.h     |  13 ++--
>>>>>   drivers/mtd/ubi/vmt.c     |  76 +++++++++++---------
>>>>>   drivers/mtd/ubi/vtbl.c    |  54 ++++++++------
>>>>>   drivers/mtd/ubi/wl.c      |  87 +++++++++++++++--------
>>>>>   13 files changed, 521 insertions(+), 374 deletions(-)
>>>>
>>>> Compilation breaks while I try to compile with this patch.
>>>> May be you need to update remaining ubi layer messages also.
>>>
>>> Please always share the errors you face.
>>> Maybe you have a different config.
>>
>> Sure, I will take care of this next time.
>>
>> Macros have been changed but some instances of older macros still remained, which caused many errors like,
>>
>> drivers/mtd/ubi/build.c: In function ‘ubi_init’:
>> drivers/mtd/ubi/build.c:1322:49: error: expected ‘)’ before ‘err’
>>     ubi_err("block: cannot initialize, error %d", err);
>
> Ohh. :(
> Tanya, did you test your patch?
>

Of course I did. I used nandsimulator on a virtual machine to test all 
patches. Perhaps my error was testing them all together (with 
read-disturb) and this got lost somehow. It's very strange you got 
compilation errors. I'm sorry for the inconvenience. Will look into this 
today and upload a new version ASAP. (with all previous comments 
addressed as well)

> Thanks,
> //richard
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation