All of lore.kernel.org
 help / color / mirror / Atom feed
From: kever.yang@rock-chips.com (Kever Yang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: rockchip: rk3288: i2s_frac adds flag to set parent's rate
Date: Tue, 30 Sep 2014 11:38:56 +0800	[thread overview]
Message-ID: <542A25D0.1030900@rock-chips.com> (raw)
In-Reply-To: <1412046724-28069-1-git-send-email-jay.xu@rock-chips.com>

Hi Jianqun,

     pls add linux-rockchip at lists.infradead.org next time.

On 09/30/2014 11:12 AM, Jianqun wrote:
> The relation of i2s nodes as follows:
>            i2s_src               0           0            594000000  0
>               i2s_frac           0           0            11289600   0
>                  i2s_pre         0           0            11289600   0
>                     sclk_i2s0    0           0            11289600   0
>                     i2s0_clkout  0           0            11289600   0
>                        hclk_i2s0 1           1            99000000   0
I always got the result as following when I set sclk_i2s0 to 11289600,
any one knows the reason?

       gpll                     6           6            594000000 0
           sclk_emmc             1           1            99000000 0
           i2s_src               0           0            11207548 0
              i2s_pre            0           0            11207548 0
                 sclk_i2s0       0           0            11207548 0
                 i2s0_clkout     0           0            11207548 0
              i2s_frac           0           0            646456897 0
> sclk_i2s0 is the master clock, when to set rate of sclk_i2s0, should
> allow to set its parent's rate, by add flag CLK_SET_RATE_PARENT for
> "i2s_frac", "i2s_pre", "i2s0_clkout" and "sclk_i2s0".
>
> Tested on rk3288 board using max98090, with command "aplay <music.wav>"
>
> Change-Id: I12faad082566532b65a7de8c0a6845e1c17870e6
> Signed-off-by: Jianqun <jay.xu@rock-chips.com>
> ---
>   drivers/clk/rockchip/clk-rk3288.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip/clk-rk3288.c
> index c770de0..baf19b4 100644
> --- a/drivers/clk/rockchip/clk-rk3288.c
> +++ b/drivers/clk/rockchip/clk-rk3288.c
> @@ -301,15 +301,15 @@ static struct rockchip_clk_branch rk3288_clk_branches[] __initdata = {
>   	COMPOSITE(0, "i2s_src", mux_pll_src_cpll_gpll_p, 0,
>   			RK3288_CLKSEL_CON(4), 15, 1, MFLAGS, 0, 7, DFLAGS,
>   			RK3288_CLKGATE_CON(4), 1, GFLAGS),
> -	COMPOSITE_FRAC(0, "i2s_frac", "i2s_src", 0,
> +	COMPOSITE_FRAC(0, "i2s_frac", "i2s_src", CLK_SET_RATE_PARENT,
>   			RK3288_CLKSEL_CON(8), 0,
>   			RK3288_CLKGATE_CON(4), 2, GFLAGS),
> -	MUX(0, "i2s_pre", mux_i2s_pre_p, 0,
> +	MUX(0, "i2s_pre", mux_i2s_pre_p, CLK_SET_RATE_PARENT,
>   			RK3288_CLKSEL_CON(4), 8, 2, MFLAGS),
> -	COMPOSITE_NODIV(0, "i2s0_clkout", mux_i2s_clkout_p, 0,
> +	COMPOSITE_NODIV(0, "i2s0_clkout", mux_i2s_clkout_p, CLK_SET_RATE_PARENT,
>   			RK3288_CLKSEL_CON(4), 12, 1, MFLAGS,
>   			RK3288_CLKGATE_CON(4), 0, GFLAGS),
> -	GATE(SCLK_I2S0, "sclk_i2s0", "i2s_pre", 0,
> +	GATE(SCLK_I2S0, "sclk_i2s0", "i2s_pre", CLK_SET_RATE_PARENT,
>   			RK3288_CLKGATE_CON(4), 3, GFLAGS),
>   
>   	MUX(0, "spdif_src", mux_pll_src_cpll_gpll_p, 0,

WARNING: multiple messages have this Message-ID (diff)
From: Kever Yang <kever.yang@rock-chips.com>
To: Jianqun <jay.xu@rock-chips.com>,
	mturquette@linaro.org, dianders@chromium.org, heiko@sntech.de,
	dbasehore@chromium.org, mark.yao@rock-chips.com
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, huangtao@rock-chips.com,
	cf@rock-chips.com
Subject: Re: [PATCH] clk: rockchip: rk3288: i2s_frac adds flag to set parent's rate
Date: Tue, 30 Sep 2014 11:38:56 +0800	[thread overview]
Message-ID: <542A25D0.1030900@rock-chips.com> (raw)
In-Reply-To: <1412046724-28069-1-git-send-email-jay.xu@rock-chips.com>

Hi Jianqun,

     pls add linux-rockchip@lists.infradead.org next time.

On 09/30/2014 11:12 AM, Jianqun wrote:
> The relation of i2s nodes as follows:
>            i2s_src               0           0            594000000  0
>               i2s_frac           0           0            11289600   0
>                  i2s_pre         0           0            11289600   0
>                     sclk_i2s0    0           0            11289600   0
>                     i2s0_clkout  0           0            11289600   0
>                        hclk_i2s0 1           1            99000000   0
I always got the result as following when I set sclk_i2s0 to 11289600,
any one knows the reason?

       gpll                     6           6            594000000 0
           sclk_emmc             1           1            99000000 0
           i2s_src               0           0            11207548 0
              i2s_pre            0           0            11207548 0
                 sclk_i2s0       0           0            11207548 0
                 i2s0_clkout     0           0            11207548 0
              i2s_frac           0           0            646456897 0
> sclk_i2s0 is the master clock, when to set rate of sclk_i2s0, should
> allow to set its parent's rate, by add flag CLK_SET_RATE_PARENT for
> "i2s_frac", "i2s_pre", "i2s0_clkout" and "sclk_i2s0".
>
> Tested on rk3288 board using max98090, with command "aplay <music.wav>"
>
> Change-Id: I12faad082566532b65a7de8c0a6845e1c17870e6
> Signed-off-by: Jianqun <jay.xu@rock-chips.com>
> ---
>   drivers/clk/rockchip/clk-rk3288.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip/clk-rk3288.c
> index c770de0..baf19b4 100644
> --- a/drivers/clk/rockchip/clk-rk3288.c
> +++ b/drivers/clk/rockchip/clk-rk3288.c
> @@ -301,15 +301,15 @@ static struct rockchip_clk_branch rk3288_clk_branches[] __initdata = {
>   	COMPOSITE(0, "i2s_src", mux_pll_src_cpll_gpll_p, 0,
>   			RK3288_CLKSEL_CON(4), 15, 1, MFLAGS, 0, 7, DFLAGS,
>   			RK3288_CLKGATE_CON(4), 1, GFLAGS),
> -	COMPOSITE_FRAC(0, "i2s_frac", "i2s_src", 0,
> +	COMPOSITE_FRAC(0, "i2s_frac", "i2s_src", CLK_SET_RATE_PARENT,
>   			RK3288_CLKSEL_CON(8), 0,
>   			RK3288_CLKGATE_CON(4), 2, GFLAGS),
> -	MUX(0, "i2s_pre", mux_i2s_pre_p, 0,
> +	MUX(0, "i2s_pre", mux_i2s_pre_p, CLK_SET_RATE_PARENT,
>   			RK3288_CLKSEL_CON(4), 8, 2, MFLAGS),
> -	COMPOSITE_NODIV(0, "i2s0_clkout", mux_i2s_clkout_p, 0,
> +	COMPOSITE_NODIV(0, "i2s0_clkout", mux_i2s_clkout_p, CLK_SET_RATE_PARENT,
>   			RK3288_CLKSEL_CON(4), 12, 1, MFLAGS,
>   			RK3288_CLKGATE_CON(4), 0, GFLAGS),
> -	GATE(SCLK_I2S0, "sclk_i2s0", "i2s_pre", 0,
> +	GATE(SCLK_I2S0, "sclk_i2s0", "i2s_pre", CLK_SET_RATE_PARENT,
>   			RK3288_CLKGATE_CON(4), 3, GFLAGS),
>   
>   	MUX(0, "spdif_src", mux_pll_src_cpll_gpll_p, 0,



  reply	other threads:[~2014-09-30  3:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30  3:12 [PATCH] clk: rockchip: rk3288: i2s_frac adds flag to set parent's rate Jianqun
2014-09-30  3:12 ` Jianqun
2014-09-30  3:38 ` Kever Yang [this message]
2014-09-30  3:38   ` Kever Yang
2014-09-30  3:44   ` Jianqun
2014-09-30  3:44     ` Jianqun
2014-10-11 18:54 ` Heiko Stübner
2014-10-11 18:54   ` Heiko Stübner
2014-10-13  0:32   ` Jianqun
2014-10-13  0:32     ` Jianqun
2014-10-13  0:44 ` [PATCH v2] " Jianqun
2014-10-13  0:44   ` Jianqun
2014-10-16 19:17   ` Heiko Stübner
2014-10-16 19:17     ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542A25D0.1030900@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.