From: Prarit Bhargava <prarit@redhat.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: herbert@gondor.apana.org.au, bruce.w.allan@intel.com,
qat-linux@intel.com, john.griffin@intel.com,
linux-crypto@vger.kernel.org, naleksan@redhat.com,
davem@davemloft.net
Subject: Re: [PATCH 2/2] crypto: qat - Enforce valid numa configuration.
Date: Wed, 08 Oct 2014 15:01:26 -0400 [thread overview]
Message-ID: <54358A06.2080605@redhat.com> (raw)
In-Reply-To: <54358918.7030808@intel.com>
On 10/08/2014 02:57 PM, Tadeusz Struk wrote:
> On 10/08/2014 11:35 AM, Prarit Bhargava wrote:
>>> But then how do I know which node I'm physically connected to?
>> The pci_dev maps to the bus which maps to a numa node. The pci_dev's numa value
>> is copied directly from the bus (or busses depending on how deep it is).
>>
>> I'd argue (strongly) that the pci_dev's numa ID better be correct o/w that is a
>> FW bug (and a bad one at that these days).
>>
>> dev_to_node() should return the correct value.
>
> I'm not saying that the dev_to_node() returns incorrect value. It will
> always return the closest numa node for the given device.
No that isn't correct. dev_to_node() will return the node the device is
connected to.
> What we want to enforce is that the closest numa node is the node that
> the device is physically connected to. In case if the closest numa node
> is the remote node we don't want to use this accelerator.
>
P.
next prev parent reply other threads:[~2014-10-08 19:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 17:38 [PATCH 0/2] crypto: qat - Fix for invalid dma mapping and numa Tadeusz Struk
2014-10-08 17:38 ` [PATCH 1/2] crypto: qat - Prevent dma mapping zero length assoc data Tadeusz Struk
2014-10-08 17:38 ` [PATCH 2/2] crypto: qat - Enforce valid numa configuration Tadeusz Struk
2014-10-08 17:57 ` Prarit Bhargava
2014-10-08 18:11 ` Tadeusz Struk
2014-10-08 18:35 ` Prarit Bhargava
2014-10-08 18:57 ` Tadeusz Struk
2014-10-08 19:01 ` Prarit Bhargava [this message]
2014-10-08 19:25 ` Tadeusz Struk
2014-10-09 11:23 ` Prarit Bhargava
2014-10-09 16:14 ` Tadeusz Struk
2014-10-09 17:32 ` Prarit Bhargava
2014-10-09 19:55 ` Tadeusz Struk
2014-10-09 21:42 ` Prarit Bhargava
2014-10-09 23:12 ` Tadeusz Struk
2014-10-10 11:23 ` Prarit Bhargava
2014-10-10 13:25 ` Tadeusz Struk
2014-10-10 22:15 ` Prarit Bhargava
2014-10-11 17:05 ` Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54358A06.2080605@redhat.com \
--to=prarit@redhat.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=john.griffin@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=naleksan@redhat.com \
--cc=qat-linux@intel.com \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.