From: Prarit Bhargava <prarit@redhat.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: herbert@gondor.apana.org.au, bruce.w.allan@intel.com,
qat-linux@intel.com, john.griffin@intel.com,
linux-crypto@vger.kernel.org, naleksan@redhat.com,
davem@davemloft.net
Subject: Re: [PATCH 2/2] crypto: qat - Enforce valid numa configuration.
Date: Thu, 09 Oct 2014 07:23:02 -0400 [thread overview]
Message-ID: <54367016.3070709@redhat.com> (raw)
In-Reply-To: <54358FC6.8060500@intel.com>
[sorry ... accidentally hit reply instead of reply all ... resending to everyone]
On 10/08/2014 03:25 PM, Tadeusz Struk wrote:
> On 10/08/2014 12:01 PM, Prarit Bhargava wrote:
>> No that isn't correct. dev_to_node() will return the node the device is
>> connected to.
>
> include/linux/device.h:
>
> static inline int dev_to_node(struct device *dev)
> {
> return dev->numa_node;
> }
>
> struct device {
> .....
> int numa_node; /* NUMA node this device is close to */
> ...
That's just bad english. The numa node value (for pci devices) is
read from the ACPI tables on the system and represents the node that
the pci_dev is connected to.
> };
>
> In case when there are two nodes and only node 0 has memory,
> dev->numa_node will be 0 even though the device will be connected to the
> pci root port of node 1.
Your calculation completely falls apart and returns incorrect values when
cpu hotplug is used or if there are multi-socket nodes (as was the case
on the system that panicked), or if one uses the new cluster-on-die mode.
P.
next prev parent reply other threads:[~2014-10-09 11:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 17:38 [PATCH 0/2] crypto: qat - Fix for invalid dma mapping and numa Tadeusz Struk
2014-10-08 17:38 ` [PATCH 1/2] crypto: qat - Prevent dma mapping zero length assoc data Tadeusz Struk
2014-10-08 17:38 ` [PATCH 2/2] crypto: qat - Enforce valid numa configuration Tadeusz Struk
2014-10-08 17:57 ` Prarit Bhargava
2014-10-08 18:11 ` Tadeusz Struk
2014-10-08 18:35 ` Prarit Bhargava
2014-10-08 18:57 ` Tadeusz Struk
2014-10-08 19:01 ` Prarit Bhargava
2014-10-08 19:25 ` Tadeusz Struk
2014-10-09 11:23 ` Prarit Bhargava [this message]
2014-10-09 16:14 ` Tadeusz Struk
2014-10-09 17:32 ` Prarit Bhargava
2014-10-09 19:55 ` Tadeusz Struk
2014-10-09 21:42 ` Prarit Bhargava
2014-10-09 23:12 ` Tadeusz Struk
2014-10-10 11:23 ` Prarit Bhargava
2014-10-10 13:25 ` Tadeusz Struk
2014-10-10 22:15 ` Prarit Bhargava
2014-10-11 17:05 ` Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54367016.3070709@redhat.com \
--to=prarit@redhat.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=john.griffin@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=naleksan@redhat.com \
--cc=qat-linux@intel.com \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.