From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Steve French <smfrench@gmail.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: xfstests and linux nfs testing
Date: Thu, 9 Oct 2014 08:41:54 -0400 [thread overview]
Message-ID: <54368292.8060209@Netapp.com> (raw)
In-Reply-To: <CAH2r5mt8EfVraedY2Gi31E4xQG=p=YqtAXEoH2a+FYHdmBzbqA@mail.gmail.com>
I think this is a bug in xfstests. This fixes it for me, but I'm not sure what needs to be checked in the NFS case:
Anna
diff --git a/common/rc b/common/rc
index 34d7c19..e86bbfb 100644
--- a/common/rc
+++ b/common/rc
@@ -1085,9 +1085,9 @@ _require_scratch()
_require_test()
{
case "$FSTYP" in
- nfs*)
- _notrun "requires a test device"
- ;;
+ #nfs*)
+ # _notrun "requires a test device"
+ # ;;
cifs)
echo $TEST_DEV | grep -q "//" > /dev/null 2>&1
if [ -z "$TEST_DEV" -o "$?" != "0" ]; then
@@ -1097,7 +1097,7 @@ _require_test()
_notrun "this test requires a valid \$TEST_DIR"
fi
;;
- tmpfs)
+ tmpfs|nfs*)
if [ -z "$TEST_DEV" -o ! -d "$TEST_DIR" ];
then
_notrun "this test requires a valid \$TEST_DIR and unique $TEST_DEV"
On 10/08/14 23:09, Steve French wrote:
> Was running into a strange error with xfstests over nfs - must be
> missing something obvious since I have run it various times before.
>
> Tried the following local.config file (placed in root of xfstests directory)
>
> FSTYP=nfs
> TEST_DEV=192.168.93.152:/share-1
> TEST_DIR=/mnt/test
> NFS_MOUNT_OPTIONS='-ov3'
>
> and did
> ./check -nfs generic/001
>
> which should have worked fine, but it and the various other nfs
> capable xfstests returned
>
> [not run] requires a test device
>
> which is weird because even setting the TEST_DEV as an environment
> variable xfstests still thought it wasn't set.
>
> Anyone have a sample NFS local.config file for xfstests which works?
>
WARNING: multiple messages have this Message-ID (diff)
From: Anna Schumaker <Anna.Schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-fsdevel
<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: xfstests and linux nfs testing
Date: Thu, 9 Oct 2014 08:41:54 -0400 [thread overview]
Message-ID: <54368292.8060209@Netapp.com> (raw)
In-Reply-To: <CAH2r5mt8EfVraedY2Gi31E4xQG=p=YqtAXEoH2a+FYHdmBzbqA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
I think this is a bug in xfstests. This fixes it for me, but I'm not sure what needs to be checked in the NFS case:
Anna
diff --git a/common/rc b/common/rc
index 34d7c19..e86bbfb 100644
--- a/common/rc
+++ b/common/rc
@@ -1085,9 +1085,9 @@ _require_scratch()
_require_test()
{
case "$FSTYP" in
- nfs*)
- _notrun "requires a test device"
- ;;
+ #nfs*)
+ # _notrun "requires a test device"
+ # ;;
cifs)
echo $TEST_DEV | grep -q "//" > /dev/null 2>&1
if [ -z "$TEST_DEV" -o "$?" != "0" ]; then
@@ -1097,7 +1097,7 @@ _require_test()
_notrun "this test requires a valid \$TEST_DIR"
fi
;;
- tmpfs)
+ tmpfs|nfs*)
if [ -z "$TEST_DEV" -o ! -d "$TEST_DIR" ];
then
_notrun "this test requires a valid \$TEST_DIR and unique $TEST_DEV"
On 10/08/14 23:09, Steve French wrote:
> Was running into a strange error with xfstests over nfs - must be
> missing something obvious since I have run it various times before.
>
> Tried the following local.config file (placed in root of xfstests directory)
>
> FSTYP=nfs
> TEST_DEV=192.168.93.152:/share-1
> TEST_DIR=/mnt/test
> NFS_MOUNT_OPTIONS='-ov3'
>
> and did
> ./check -nfs generic/001
>
> which should have worked fine, but it and the various other nfs
> capable xfstests returned
>
> [not run] requires a test device
>
> which is weird because even setting the TEST_DEV as an environment
> variable xfstests still thought it wasn't set.
>
> Anyone have a sample NFS local.config file for xfstests which works?
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-10-09 12:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 3:09 xfstests and linux nfs testing Steve French
2014-10-09 3:09 ` Steve French
2014-10-09 12:41 ` Anna Schumaker [this message]
2014-10-09 12:41 ` Anna Schumaker
2014-10-09 16:21 ` Christoph Hellwig
2014-10-09 16:21 ` Christoph Hellwig
2014-10-09 17:36 ` Anna Schumaker
2014-10-09 17:36 ` Anna Schumaker
2014-10-09 17:36 ` Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54368292.8060209@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.