From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Steve French <smfrench@gmail.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
fstests@vger.kernel.org, Lukas Czerner <lczerner@redhat.com>
Subject: Re: xfstests and linux nfs testing
Date: Thu, 9 Oct 2014 13:36:53 -0400 [thread overview]
Message-ID: <5436C7B5.7040700@Netapp.com> (raw)
In-Reply-To: <20141009162127.GA12500@infradead.org>
On 10/09/14 12:21, Christoph Hellwig wrote:
> On Thu, Oct 09, 2014 at 08:41:54AM -0400, Anna Schumaker wrote:
>> I think this is a bug in xfstests. This fixes it for me, but I'm not sure what needs to be checked in the NFS case:
>
> Lukas broke this with:
> common: Check fs consistency on TEST_DEV only when needed
>
> as far as I can tell it blindly copied the _require_scratch code
> to _require_test, which is bad for two reasons:
>
> a) due to lots of code duplication
> b) because it broke filesystems that don't support a scratch dev
> like nfs.
>
> Anna fix should work, can you resend it to the fstests lists with a
> proper signoff? Even better would be some validation that the
> passed in "device" is a valid format for a nfs export, but that's not
> strictly required.
Sure! I'll fix up the patch so it doesn't have commented out lines while I'm at it :). I'll take a stab at server format validation, and then send something out!
Anna
>
WARNING: multiple messages have this Message-ID (diff)
From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Steve French <smfrench@gmail.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
<fstests@vger.kernel.org>, Lukas Czerner <lczerner@redhat.com>
Subject: Re: xfstests and linux nfs testing
Date: Thu, 9 Oct 2014 13:36:53 -0400 [thread overview]
Message-ID: <5436C7B5.7040700@Netapp.com> (raw)
In-Reply-To: <20141009162127.GA12500@infradead.org>
On 10/09/14 12:21, Christoph Hellwig wrote:
> On Thu, Oct 09, 2014 at 08:41:54AM -0400, Anna Schumaker wrote:
>> I think this is a bug in xfstests. This fixes it for me, but I'm not sure what needs to be checked in the NFS case:
>
> Lukas broke this with:
> common: Check fs consistency on TEST_DEV only when needed
>
> as far as I can tell it blindly copied the _require_scratch code
> to _require_test, which is bad for two reasons:
>
> a) due to lots of code duplication
> b) because it broke filesystems that don't support a scratch dev
> like nfs.
>
> Anna fix should work, can you resend it to the fstests lists with a
> proper signoff? Even better would be some validation that the
> passed in "device" is a valid format for a nfs export, but that's not
> strictly required.
Sure! I'll fix up the patch so it doesn't have commented out lines while I'm at it :). I'll take a stab at server format validation, and then send something out!
Anna
>
WARNING: multiple messages have this Message-ID (diff)
From: Anna Schumaker <Anna.Schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-fsdevel
<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<fstests-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Lukas Czerner <lczerner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: xfstests and linux nfs testing
Date: Thu, 9 Oct 2014 13:36:53 -0400 [thread overview]
Message-ID: <5436C7B5.7040700@Netapp.com> (raw)
In-Reply-To: <20141009162127.GA12500-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
On 10/09/14 12:21, Christoph Hellwig wrote:
> On Thu, Oct 09, 2014 at 08:41:54AM -0400, Anna Schumaker wrote:
>> I think this is a bug in xfstests. This fixes it for me, but I'm not sure what needs to be checked in the NFS case:
>
> Lukas broke this with:
> common: Check fs consistency on TEST_DEV only when needed
>
> as far as I can tell it blindly copied the _require_scratch code
> to _require_test, which is bad for two reasons:
>
> a) due to lots of code duplication
> b) because it broke filesystems that don't support a scratch dev
> like nfs.
>
> Anna fix should work, can you resend it to the fstests lists with a
> proper signoff? Even better would be some validation that the
> passed in "device" is a valid format for a nfs export, but that's not
> strictly required.
Sure! I'll fix up the patch so it doesn't have commented out lines while I'm at it :). I'll take a stab at server format validation, and then send something out!
Anna
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-10-09 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 3:09 xfstests and linux nfs testing Steve French
2014-10-09 3:09 ` Steve French
2014-10-09 12:41 ` Anna Schumaker
2014-10-09 12:41 ` Anna Schumaker
2014-10-09 16:21 ` Christoph Hellwig
2014-10-09 16:21 ` Christoph Hellwig
2014-10-09 17:36 ` Anna Schumaker [this message]
2014-10-09 17:36 ` Anna Schumaker
2014-10-09 17:36 ` Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5436C7B5.7040700@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=lczerner@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.