All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Keir Fraser <keir@xen.org>,
	ufimtseva@gmail.com, Tim Deegan <tim@xen.org>
Subject: Re: [PATCH] move XENMEM_get_vnumainfo out of tools-only section of public/memory.h
Date: Mon, 13 Oct 2014 11:14:55 +0100	[thread overview]
Message-ID: <543BA61F.8010206@citrix.com> (raw)
In-Reply-To: <5438031A020000780003DC67@mail.emea.novell.com>


[-- Attachment #1.1: Type: text/plain, Size: 1483 bytes --]

On 10/10/14 15:02, Jan Beulich wrote:
> After all this interface specifically exists for guest kernels to learn
> about their (virtual) topology. I'm sure I made a comment to this
> effect during review, but apparently I then didn't notice that this
> never got carried out.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/include/public/memory.h
> +++ b/xen/include/public/memory.h
> @@ -521,6 +521,14 @@ DEFINE_XEN_GUEST_HANDLE(xen_mem_sharing_
>   * The zero value is appropiate.
>   */
>  
> +#endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */
> +
> +/*
> + * XENMEM_get_vnumainfo used by guest to get
> + * vNUMA topology from hypervisor.
> + */
> +#define XENMEM_get_vnumainfo                26
> +
>  /* vNUMA node memory ranges */
>  struct vmemrange {
>      uint64_t start, end;
> @@ -565,14 +573,6 @@ struct vnuma_topology_info {
>  typedef struct vnuma_topology_info vnuma_topology_info_t;
>  DEFINE_XEN_GUEST_HANDLE(vnuma_topology_info_t);
>  
> -/*
> - * XENMEM_get_vnumainfo used by guest to get
> - * vNUMA topology from hypervisor.
> - */
> -#define XENMEM_get_vnumainfo               26
> -
> -#endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */
> -
>  /* Next available subop number is 27 */
>  
>  #endif /* __XEN_PUBLIC_MEMORY_H__ */
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel


[-- Attachment #1.2: Type: text/html, Size: 2329 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

      reply	other threads:[~2014-10-13 10:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-10 14:02 [PATCH] move XENMEM_get_vnumainfo out of tools-only section of public/memory.h Jan Beulich
2014-10-13 10:14 ` Andrew Cooper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=543BA61F.8010206@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir@xen.org \
    --cc=tim@xen.org \
    --cc=ufimtseva@gmail.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.