* [PATCH] move XENMEM_get_vnumainfo out of tools-only section of public/memory.h
@ 2014-10-10 14:02 Jan Beulich
2014-10-13 10:14 ` Andrew Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2014-10-10 14:02 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Campbell, Keir Fraser, Ian Jackson, ufimtseva, Tim Deegan
[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]
After all this interface specifically exists for guest kernels to learn
about their (virtual) topology. I'm sure I made a comment to this
effect during review, but apparently I then didn't notice that this
never got carried out.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/include/public/memory.h
+++ b/xen/include/public/memory.h
@@ -521,6 +521,14 @@ DEFINE_XEN_GUEST_HANDLE(xen_mem_sharing_
* The zero value is appropiate.
*/
+#endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */
+
+/*
+ * XENMEM_get_vnumainfo used by guest to get
+ * vNUMA topology from hypervisor.
+ */
+#define XENMEM_get_vnumainfo 26
+
/* vNUMA node memory ranges */
struct vmemrange {
uint64_t start, end;
@@ -565,14 +573,6 @@ struct vnuma_topology_info {
typedef struct vnuma_topology_info vnuma_topology_info_t;
DEFINE_XEN_GUEST_HANDLE(vnuma_topology_info_t);
-/*
- * XENMEM_get_vnumainfo used by guest to get
- * vNUMA topology from hypervisor.
- */
-#define XENMEM_get_vnumainfo 26
-
-#endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */
-
/* Next available subop number is 27 */
#endif /* __XEN_PUBLIC_MEMORY_H__ */
[-- Attachment #2: memop-vNUMA-non-tools.patch --]
[-- Type: text/plain, Size: 1280 bytes --]
move XENMEM_get_vnumainfo out of tools-only section of public/memory.h
After all this interface specifically exists for guest kernels to learn
about their (virtual) topology. I'm sure I made a comment to this
effect during review, but apparently I then didn't notice that this
never got carried out.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/include/public/memory.h
+++ b/xen/include/public/memory.h
@@ -521,6 +521,14 @@ DEFINE_XEN_GUEST_HANDLE(xen_mem_sharing_
* The zero value is appropiate.
*/
+#endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */
+
+/*
+ * XENMEM_get_vnumainfo used by guest to get
+ * vNUMA topology from hypervisor.
+ */
+#define XENMEM_get_vnumainfo 26
+
/* vNUMA node memory ranges */
struct vmemrange {
uint64_t start, end;
@@ -565,14 +573,6 @@ struct vnuma_topology_info {
typedef struct vnuma_topology_info vnuma_topology_info_t;
DEFINE_XEN_GUEST_HANDLE(vnuma_topology_info_t);
-/*
- * XENMEM_get_vnumainfo used by guest to get
- * vNUMA topology from hypervisor.
- */
-#define XENMEM_get_vnumainfo 26
-
-#endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */
-
/* Next available subop number is 27 */
#endif /* __XEN_PUBLIC_MEMORY_H__ */
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] move XENMEM_get_vnumainfo out of tools-only section of public/memory.h
2014-10-10 14:02 [PATCH] move XENMEM_get_vnumainfo out of tools-only section of public/memory.h Jan Beulich
@ 2014-10-13 10:14 ` Andrew Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2014-10-13 10:14 UTC (permalink / raw)
To: Jan Beulich, xen-devel
Cc: Ian Campbell, Ian Jackson, Keir Fraser, ufimtseva, Tim Deegan
[-- Attachment #1.1: Type: text/plain, Size: 1483 bytes --]
On 10/10/14 15:02, Jan Beulich wrote:
> After all this interface specifically exists for guest kernels to learn
> about their (virtual) topology. I'm sure I made a comment to this
> effect during review, but apparently I then didn't notice that this
> never got carried out.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/include/public/memory.h
> +++ b/xen/include/public/memory.h
> @@ -521,6 +521,14 @@ DEFINE_XEN_GUEST_HANDLE(xen_mem_sharing_
> * The zero value is appropiate.
> */
>
> +#endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */
> +
> +/*
> + * XENMEM_get_vnumainfo used by guest to get
> + * vNUMA topology from hypervisor.
> + */
> +#define XENMEM_get_vnumainfo 26
> +
> /* vNUMA node memory ranges */
> struct vmemrange {
> uint64_t start, end;
> @@ -565,14 +573,6 @@ struct vnuma_topology_info {
> typedef struct vnuma_topology_info vnuma_topology_info_t;
> DEFINE_XEN_GUEST_HANDLE(vnuma_topology_info_t);
>
> -/*
> - * XENMEM_get_vnumainfo used by guest to get
> - * vNUMA topology from hypervisor.
> - */
> -#define XENMEM_get_vnumainfo 26
> -
> -#endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */
> -
> /* Next available subop number is 27 */
>
> #endif /* __XEN_PUBLIC_MEMORY_H__ */
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 2329 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-13 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-10 14:02 [PATCH] move XENMEM_get_vnumainfo out of tools-only section of public/memory.h Jan Beulich
2014-10-13 10:14 ` Andrew Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.