From: Tero Kristo <t-kristo@ti.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: Mike Turquette <mturquette@linaro.org>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CLK: TI: Remove unused includes of linux/clk-private.h
Date: Mon, 13 Oct 2014 15:07:13 +0300 [thread overview]
Message-ID: <543BC071.2090905@ti.com> (raw)
In-Reply-To: <1412351519-29214-1-git-send-email-tomeu.vizoso@collabora.com>
Hi Tomeu,
Please add a changelog to this patch. Also, just replace the
clk-private.h includes with clk-provider.h, do not add the include to
the generic header. Rest of the kernel does that where needed.
Other than that, looks good to me.
-Tero
On 10/03/2014 06:51 PM, Tomeu Vizoso wrote:
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
> drivers/clk/ti/clk-44xx.c | 1 -
> drivers/clk/ti/clk-54xx.c | 1 -
> drivers/clk/ti/clk-7xx.c | 1 -
> include/linux/clk/ti.h | 1 +
> 4 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/clk/ti/clk-44xx.c b/drivers/clk/ti/clk-44xx.c
> index 02517a8..8ea705e 100644
> --- a/drivers/clk/ti/clk-44xx.c
> +++ b/drivers/clk/ti/clk-44xx.c
> @@ -12,7 +12,6 @@
>
> #include <linux/kernel.h>
> #include <linux/list.h>
> -#include <linux/clk-private.h>
> #include <linux/clkdev.h>
> #include <linux/clk/ti.h>
>
> diff --git a/drivers/clk/ti/clk-54xx.c b/drivers/clk/ti/clk-54xx.c
> index 5e18399..e823d0b 100644
> --- a/drivers/clk/ti/clk-54xx.c
> +++ b/drivers/clk/ti/clk-54xx.c
> @@ -12,7 +12,6 @@
>
> #include <linux/kernel.h>
> #include <linux/list.h>
> -#include <linux/clk-private.h>
> #include <linux/clkdev.h>
> #include <linux/io.h>
> #include <linux/clk/ti.h>
> diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
> index 62ac8f6..afd61a6 100644
> --- a/drivers/clk/ti/clk-7xx.c
> +++ b/drivers/clk/ti/clk-7xx.c
> @@ -12,7 +12,6 @@
>
> #include <linux/kernel.h>
> #include <linux/list.h>
> -#include <linux/clk-private.h>
> #include <linux/clkdev.h>
> #include <linux/clk/ti.h>
>
> diff --git a/include/linux/clk/ti.h b/include/linux/clk/ti.h
> index e8d8a35..ced953a 100644
> --- a/include/linux/clk/ti.h
> +++ b/include/linux/clk/ti.h
> @@ -16,6 +16,7 @@
> #define __LINUX_CLK_TI_H__
>
> #include <linux/clkdev.h>
> +#include <linux/clk-provider.h>
>
> /**
> * struct dpll_data - DPLL registers and integration data
>
WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: Mike Turquette <mturquette@linaro.org>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] CLK: TI: Remove unused includes of linux/clk-private.h
Date: Mon, 13 Oct 2014 15:07:13 +0300 [thread overview]
Message-ID: <543BC071.2090905@ti.com> (raw)
In-Reply-To: <1412351519-29214-1-git-send-email-tomeu.vizoso@collabora.com>
Hi Tomeu,
Please add a changelog to this patch. Also, just replace the
clk-private.h includes with clk-provider.h, do not add the include to
the generic header. Rest of the kernel does that where needed.
Other than that, looks good to me.
-Tero
On 10/03/2014 06:51 PM, Tomeu Vizoso wrote:
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
> drivers/clk/ti/clk-44xx.c | 1 -
> drivers/clk/ti/clk-54xx.c | 1 -
> drivers/clk/ti/clk-7xx.c | 1 -
> include/linux/clk/ti.h | 1 +
> 4 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/clk/ti/clk-44xx.c b/drivers/clk/ti/clk-44xx.c
> index 02517a8..8ea705e 100644
> --- a/drivers/clk/ti/clk-44xx.c
> +++ b/drivers/clk/ti/clk-44xx.c
> @@ -12,7 +12,6 @@
>
> #include <linux/kernel.h>
> #include <linux/list.h>
> -#include <linux/clk-private.h>
> #include <linux/clkdev.h>
> #include <linux/clk/ti.h>
>
> diff --git a/drivers/clk/ti/clk-54xx.c b/drivers/clk/ti/clk-54xx.c
> index 5e18399..e823d0b 100644
> --- a/drivers/clk/ti/clk-54xx.c
> +++ b/drivers/clk/ti/clk-54xx.c
> @@ -12,7 +12,6 @@
>
> #include <linux/kernel.h>
> #include <linux/list.h>
> -#include <linux/clk-private.h>
> #include <linux/clkdev.h>
> #include <linux/io.h>
> #include <linux/clk/ti.h>
> diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
> index 62ac8f6..afd61a6 100644
> --- a/drivers/clk/ti/clk-7xx.c
> +++ b/drivers/clk/ti/clk-7xx.c
> @@ -12,7 +12,6 @@
>
> #include <linux/kernel.h>
> #include <linux/list.h>
> -#include <linux/clk-private.h>
> #include <linux/clkdev.h>
> #include <linux/clk/ti.h>
>
> diff --git a/include/linux/clk/ti.h b/include/linux/clk/ti.h
> index e8d8a35..ced953a 100644
> --- a/include/linux/clk/ti.h
> +++ b/include/linux/clk/ti.h
> @@ -16,6 +16,7 @@
> #define __LINUX_CLK_TI_H__
>
> #include <linux/clkdev.h>
> +#include <linux/clk-provider.h>
>
> /**
> * struct dpll_data - DPLL registers and integration data
>
next prev parent reply other threads:[~2014-10-13 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 15:51 [PATCH] CLK: TI: Remove unused includes of linux/clk-private.h Tomeu Vizoso
2014-10-03 15:51 ` Tomeu Vizoso
2014-10-13 12:07 ` Tero Kristo [this message]
2014-10-13 12:07 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543BC071.2090905@ti.com \
--to=t-kristo@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.