* [PATCH] CLK: TI: Remove unused includes of linux/clk-private.h
@ 2014-10-03 15:51 ` Tomeu Vizoso
0 siblings, 0 replies; 4+ messages in thread
From: Tomeu Vizoso @ 2014-10-03 15:51 UTC (permalink / raw)
Cc: Mike Turquette, Tomeu Vizoso, Tero Kristo, linux-omap,
linux-kernel
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
drivers/clk/ti/clk-44xx.c | 1 -
drivers/clk/ti/clk-54xx.c | 1 -
drivers/clk/ti/clk-7xx.c | 1 -
include/linux/clk/ti.h | 1 +
4 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/ti/clk-44xx.c b/drivers/clk/ti/clk-44xx.c
index 02517a8..8ea705e 100644
--- a/drivers/clk/ti/clk-44xx.c
+++ b/drivers/clk/ti/clk-44xx.c
@@ -12,7 +12,6 @@
#include <linux/kernel.h>
#include <linux/list.h>
-#include <linux/clk-private.h>
#include <linux/clkdev.h>
#include <linux/clk/ti.h>
diff --git a/drivers/clk/ti/clk-54xx.c b/drivers/clk/ti/clk-54xx.c
index 5e18399..e823d0b 100644
--- a/drivers/clk/ti/clk-54xx.c
+++ b/drivers/clk/ti/clk-54xx.c
@@ -12,7 +12,6 @@
#include <linux/kernel.h>
#include <linux/list.h>
-#include <linux/clk-private.h>
#include <linux/clkdev.h>
#include <linux/io.h>
#include <linux/clk/ti.h>
diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
index 62ac8f6..afd61a6 100644
--- a/drivers/clk/ti/clk-7xx.c
+++ b/drivers/clk/ti/clk-7xx.c
@@ -12,7 +12,6 @@
#include <linux/kernel.h>
#include <linux/list.h>
-#include <linux/clk-private.h>
#include <linux/clkdev.h>
#include <linux/clk/ti.h>
diff --git a/include/linux/clk/ti.h b/include/linux/clk/ti.h
index e8d8a35..ced953a 100644
--- a/include/linux/clk/ti.h
+++ b/include/linux/clk/ti.h
@@ -16,6 +16,7 @@
#define __LINUX_CLK_TI_H__
#include <linux/clkdev.h>
+#include <linux/clk-provider.h>
/**
* struct dpll_data - DPLL registers and integration data
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] CLK: TI: Remove unused includes of linux/clk-private.h
@ 2014-10-03 15:51 ` Tomeu Vizoso
0 siblings, 0 replies; 4+ messages in thread
From: Tomeu Vizoso @ 2014-10-03 15:51 UTC (permalink / raw)
Cc: Mike Turquette, Tomeu Vizoso, Tero Kristo, linux-omap,
linux-kernel
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
drivers/clk/ti/clk-44xx.c | 1 -
drivers/clk/ti/clk-54xx.c | 1 -
drivers/clk/ti/clk-7xx.c | 1 -
include/linux/clk/ti.h | 1 +
4 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/ti/clk-44xx.c b/drivers/clk/ti/clk-44xx.c
index 02517a8..8ea705e 100644
--- a/drivers/clk/ti/clk-44xx.c
+++ b/drivers/clk/ti/clk-44xx.c
@@ -12,7 +12,6 @@
#include <linux/kernel.h>
#include <linux/list.h>
-#include <linux/clk-private.h>
#include <linux/clkdev.h>
#include <linux/clk/ti.h>
diff --git a/drivers/clk/ti/clk-54xx.c b/drivers/clk/ti/clk-54xx.c
index 5e18399..e823d0b 100644
--- a/drivers/clk/ti/clk-54xx.c
+++ b/drivers/clk/ti/clk-54xx.c
@@ -12,7 +12,6 @@
#include <linux/kernel.h>
#include <linux/list.h>
-#include <linux/clk-private.h>
#include <linux/clkdev.h>
#include <linux/io.h>
#include <linux/clk/ti.h>
diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
index 62ac8f6..afd61a6 100644
--- a/drivers/clk/ti/clk-7xx.c
+++ b/drivers/clk/ti/clk-7xx.c
@@ -12,7 +12,6 @@
#include <linux/kernel.h>
#include <linux/list.h>
-#include <linux/clk-private.h>
#include <linux/clkdev.h>
#include <linux/clk/ti.h>
diff --git a/include/linux/clk/ti.h b/include/linux/clk/ti.h
index e8d8a35..ced953a 100644
--- a/include/linux/clk/ti.h
+++ b/include/linux/clk/ti.h
@@ -16,6 +16,7 @@
#define __LINUX_CLK_TI_H__
#include <linux/clkdev.h>
+#include <linux/clk-provider.h>
/**
* struct dpll_data - DPLL registers and integration data
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] CLK: TI: Remove unused includes of linux/clk-private.h
2014-10-03 15:51 ` Tomeu Vizoso
@ 2014-10-13 12:07 ` Tero Kristo
-1 siblings, 0 replies; 4+ messages in thread
From: Tero Kristo @ 2014-10-13 12:07 UTC (permalink / raw)
To: Tomeu Vizoso; +Cc: Mike Turquette, linux-omap, linux-kernel
Hi Tomeu,
Please add a changelog to this patch. Also, just replace the
clk-private.h includes with clk-provider.h, do not add the include to
the generic header. Rest of the kernel does that where needed.
Other than that, looks good to me.
-Tero
On 10/03/2014 06:51 PM, Tomeu Vizoso wrote:
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
> drivers/clk/ti/clk-44xx.c | 1 -
> drivers/clk/ti/clk-54xx.c | 1 -
> drivers/clk/ti/clk-7xx.c | 1 -
> include/linux/clk/ti.h | 1 +
> 4 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/clk/ti/clk-44xx.c b/drivers/clk/ti/clk-44xx.c
> index 02517a8..8ea705e 100644
> --- a/drivers/clk/ti/clk-44xx.c
> +++ b/drivers/clk/ti/clk-44xx.c
> @@ -12,7 +12,6 @@
>
> #include <linux/kernel.h>
> #include <linux/list.h>
> -#include <linux/clk-private.h>
> #include <linux/clkdev.h>
> #include <linux/clk/ti.h>
>
> diff --git a/drivers/clk/ti/clk-54xx.c b/drivers/clk/ti/clk-54xx.c
> index 5e18399..e823d0b 100644
> --- a/drivers/clk/ti/clk-54xx.c
> +++ b/drivers/clk/ti/clk-54xx.c
> @@ -12,7 +12,6 @@
>
> #include <linux/kernel.h>
> #include <linux/list.h>
> -#include <linux/clk-private.h>
> #include <linux/clkdev.h>
> #include <linux/io.h>
> #include <linux/clk/ti.h>
> diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
> index 62ac8f6..afd61a6 100644
> --- a/drivers/clk/ti/clk-7xx.c
> +++ b/drivers/clk/ti/clk-7xx.c
> @@ -12,7 +12,6 @@
>
> #include <linux/kernel.h>
> #include <linux/list.h>
> -#include <linux/clk-private.h>
> #include <linux/clkdev.h>
> #include <linux/clk/ti.h>
>
> diff --git a/include/linux/clk/ti.h b/include/linux/clk/ti.h
> index e8d8a35..ced953a 100644
> --- a/include/linux/clk/ti.h
> +++ b/include/linux/clk/ti.h
> @@ -16,6 +16,7 @@
> #define __LINUX_CLK_TI_H__
>
> #include <linux/clkdev.h>
> +#include <linux/clk-provider.h>
>
> /**
> * struct dpll_data - DPLL registers and integration data
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] CLK: TI: Remove unused includes of linux/clk-private.h
@ 2014-10-13 12:07 ` Tero Kristo
0 siblings, 0 replies; 4+ messages in thread
From: Tero Kristo @ 2014-10-13 12:07 UTC (permalink / raw)
To: Tomeu Vizoso; +Cc: Mike Turquette, linux-omap, linux-kernel
Hi Tomeu,
Please add a changelog to this patch. Also, just replace the
clk-private.h includes with clk-provider.h, do not add the include to
the generic header. Rest of the kernel does that where needed.
Other than that, looks good to me.
-Tero
On 10/03/2014 06:51 PM, Tomeu Vizoso wrote:
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
> drivers/clk/ti/clk-44xx.c | 1 -
> drivers/clk/ti/clk-54xx.c | 1 -
> drivers/clk/ti/clk-7xx.c | 1 -
> include/linux/clk/ti.h | 1 +
> 4 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/clk/ti/clk-44xx.c b/drivers/clk/ti/clk-44xx.c
> index 02517a8..8ea705e 100644
> --- a/drivers/clk/ti/clk-44xx.c
> +++ b/drivers/clk/ti/clk-44xx.c
> @@ -12,7 +12,6 @@
>
> #include <linux/kernel.h>
> #include <linux/list.h>
> -#include <linux/clk-private.h>
> #include <linux/clkdev.h>
> #include <linux/clk/ti.h>
>
> diff --git a/drivers/clk/ti/clk-54xx.c b/drivers/clk/ti/clk-54xx.c
> index 5e18399..e823d0b 100644
> --- a/drivers/clk/ti/clk-54xx.c
> +++ b/drivers/clk/ti/clk-54xx.c
> @@ -12,7 +12,6 @@
>
> #include <linux/kernel.h>
> #include <linux/list.h>
> -#include <linux/clk-private.h>
> #include <linux/clkdev.h>
> #include <linux/io.h>
> #include <linux/clk/ti.h>
> diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
> index 62ac8f6..afd61a6 100644
> --- a/drivers/clk/ti/clk-7xx.c
> +++ b/drivers/clk/ti/clk-7xx.c
> @@ -12,7 +12,6 @@
>
> #include <linux/kernel.h>
> #include <linux/list.h>
> -#include <linux/clk-private.h>
> #include <linux/clkdev.h>
> #include <linux/clk/ti.h>
>
> diff --git a/include/linux/clk/ti.h b/include/linux/clk/ti.h
> index e8d8a35..ced953a 100644
> --- a/include/linux/clk/ti.h
> +++ b/include/linux/clk/ti.h
> @@ -16,6 +16,7 @@
> #define __LINUX_CLK_TI_H__
>
> #include <linux/clkdev.h>
> +#include <linux/clk-provider.h>
>
> /**
> * struct dpll_data - DPLL registers and integration data
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-13 12:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-03 15:51 [PATCH] CLK: TI: Remove unused includes of linux/clk-private.h Tomeu Vizoso
2014-10-03 15:51 ` Tomeu Vizoso
2014-10-13 12:07 ` Tero Kristo
2014-10-13 12:07 ` Tero Kristo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.