get_maintainers.pl doesn't actually get the real MAINTAINERS?

get_maintainers.pl doesn't actually get the real MAINTAINERS?

[Scott Branden]

Hello,

I try running scripts/get_maintainers.pl but it doesn't seem to get the 
real maintainers properly.  Please note this is run against the current 
MAINTAINERS file.

One Example:  I would expect drivers/mmc/host/sdhci-bcm2835.c to be 
maintained by Stephen Warren based on drivers/*/*bcm2835* below.  But 
the get_maintainers.pl script does not seem to process the information 
in such a way.  So what needs to be corrected - the script or the syntax 
used in the MAINTAINERS file?

BROADCOM BCM2835 ARM ARCHICTURE
M:	Stephen Warren <swarren@wwwdotorg.org>
L:	linux-rpi-kernel@lists.infradead.org (moderated for non-subscribers)
T:	git git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-rpi.git
S:	Maintained
F:	arch/arm/mach-bcm/board_bcm2835.c
F:	arch/arm/boot/dts/bcm2835*
F:	arch/arm/configs/bcm2835_defconfig
F:	drivers/*/*bcm2835*

Regards,
Scott

Re: get_maintainers.pl doesn't actually get the real MAINTAINERS?

[Joe Perches]

On Tue, 2014-10-14 at 19:18 -0700, Scott Branden wrote:
> Hello,
> 
> I try running scripts/get_maintainers.pl but it doesn't seem to get the 
> real maintainers properly.  Please note this is run against the current 
> MAINTAINERS file.
> 
> One Example:  I would expect drivers/mmc/host/sdhci-bcm2835.c to be 
> maintained by Stephen Warren based on drivers/*/*bcm2835* below.

get_maintainers doesn't use * as a depth wildcard

*/ matches a single top level directory level
*/*/ matches one level below the top directory level.

>   But 
> the get_maintainers.pl script does not seem to process the information 
> in such a way.  So what needs to be corrected - the script or the syntax 
> used in the MAINTAINERS file?
> 
> BROADCOM BCM2835 ARM ARCHICTURE
> M:	Stephen Warren <swarren@wwwdotorg.org>
> L:	linux-rpi-kernel@lists.infradead.org (moderated for non-subscribers)
> T:	git git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-rpi.git
> S:	Maintained
> F:	arch/arm/mach-bcm/board_bcm2835.c
> F:	arch/arm/boot/dts/bcm2835*
> F:	arch/arm/configs/bcm2835_defconfig
> F:	drivers/*/*bcm2835*

F:	drivers/*/*/*bmc2835*

Re: get_maintainers.pl doesn't actually get the real MAINTAINERS?

[Scott Branden]

On 14-10-14 07:26 PM, Joe Perches wrote:
> On Tue, 2014-10-14 at 19:18 -0700, Scott Branden wrote:
>> Hello,
>>
>> I try running scripts/get_maintainers.pl but it doesn't seem to get the
>> real maintainers properly.  Please note this is run against the current
>> MAINTAINERS file.
>>
>> One Example:  I would expect drivers/mmc/host/sdhci-bcm2835.c to be
>> maintained by Stephen Warren based on drivers/*/*bcm2835* below.
>
> get_maintainers doesn't use * as a depth wildcard
>
> */ matches a single top level directory level
> */*/ matches one level below the top directory level.
>
>>    But
>> the get_maintainers.pl script does not seem to process the information
>> in such a way.  So what needs to be corrected - the script or the syntax
>> used in the MAINTAINERS file?
>>
>> BROADCOM BCM2835 ARM ARCHICTURE
>> M:	Stephen Warren <swarren@wwwdotorg.org>
>> L:	linux-rpi-kernel@lists.infradead.org (moderated for non-subscribers)
>> T:	git git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-rpi.git
>> S:	Maintained
>> F:	arch/arm/mach-bcm/board_bcm2835.c
>> F:	arch/arm/boot/dts/bcm2835*
>> F:	arch/arm/configs/bcm2835_defconfig
>> F:	drivers/*/*bcm2835*
>
> F:	drivers/*/*/*bmc2835*
Thanks for the explanation.  So somebody should really do the following 
to maintain any files no matter where they are located?
F:	*/*bcm2835*
F:	*/*/*bcm2835*
F:	*/*/*/*bcm2835*
F:	*/*/*/*/*bcm2835*
F:	*/*/*/*/*/*bcm2835*
F:	*/*/*/*/*/*/*bcm2835*
F:	*/*/*/*/*/*/*/*bcm2835*

Or, can a recursive option be added in the script?
>
>

Re: get_maintainers.pl doesn't actually get the real MAINTAINERS?

[Joe Perches]

On Tue, 2014-10-14 at 19:31 -0700, Scott Branden wrote:
> On 14-10-14 07:26 PM, Joe Perches wrote:
> > On Tue, 2014-10-14 at 19:18 -0700, Scott Branden wrote:
> >> Hello,
> >>
> >> I try running scripts/get_maintainers.pl but it doesn't seem to get the
> >> real maintainers properly.  Please note this is run against the current
> >> MAINTAINERS file.
> >>
> >> One Example:  I would expect drivers/mmc/host/sdhci-bcm2835.c to be
> >> maintained by Stephen Warren based on drivers/*/*bcm2835* below.
> >
> > get_maintainers doesn't use * as a depth wildcard
> >
> > */ matches a single top level directory level
> > */*/ matches one level below the top directory level.
> >
> >>    But
> >> the get_maintainers.pl script does not seem to process the information
> >> in such a way.  So what needs to be corrected - the script or the syntax
> >> used in the MAINTAINERS file?
> >>
> >> BROADCOM BCM2835 ARM ARCHICTURE
> >> M:	Stephen Warren <swarren@wwwdotorg.org>
> >> L:	linux-rpi-kernel@lists.infradead.org (moderated for non-subscribers)
> >> T:	git git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-rpi.git
> >> S:	Maintained
> >> F:	arch/arm/mach-bcm/board_bcm2835.c
> >> F:	arch/arm/boot/dts/bcm2835*
> >> F:	arch/arm/configs/bcm2835_defconfig
> >> F:	drivers/*/*bcm2835*
> >
> > F:	drivers/*/*/*bmc2835*
> Thanks for the explanation.  So somebody should really do the following 
> to maintain any files no matter where they are located?
> F:	*/*bcm2835*
> F:	*/*/*bcm2835*
> F:	*/*/*/*bcm2835*
> F:	*/*/*/*/*bcm2835*
> F:	*/*/*/*/*/*bcm2835*
> F:	*/*/*/*/*/*/*bcm2835*
> F:	*/*/*/*/*/*/*/*bcm2835*
> 
> Or, can a recursive option be added in the script?

Hasn't been much of a need for that but knock yourself
out if you think something like a ... might be useful.

Look for function "file_match_pattern" if you want
to extend it.

There is a file name matching option "N:" that
does something similar.

Difference is that F: patterns matches do not
use git history by default to find other people
that have submitted patches, N: does.