All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Chen Gang <gang.chen.5i5j@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-ppc@nongnu.org, kvm@vger.kernel.org,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2] target-ppc: kvm: Fix memory overflow issue about strncat()
Date: Wed, 15 Oct 2014 15:52:41 +0200	[thread overview]
Message-ID: <543E7C29.2030507@suse.de> (raw)
In-Reply-To: <543E7B17.1050902@gmail.com>



On 15.10.14 15:48, Chen Gang wrote:
> strncat() will append additional '\0' to destination buffer, so need
> additional 1 byte for it, or may cause memory overflow, just like other
> area within QEMU have done.
> 
> And can use g_strdup_printf() instead of strncat(), which may be more
> easier understanding.
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>

Thanks, applied to ppc-next. And sorry for not replying earlier.


Alex

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Chen Gang <gang.chen.5i5j@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-ppc@nongnu.org, qemu-devel <qemu-devel@nongnu.org>,
	kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH v2] target-ppc: kvm: Fix memory overflow issue about strncat()
Date: Wed, 15 Oct 2014 15:52:41 +0200	[thread overview]
Message-ID: <543E7C29.2030507@suse.de> (raw)
In-Reply-To: <543E7B17.1050902@gmail.com>



On 15.10.14 15:48, Chen Gang wrote:
> strncat() will append additional '\0' to destination buffer, so need
> additional 1 byte for it, or may cause memory overflow, just like other
> area within QEMU have done.
> 
> And can use g_strdup_printf() instead of strncat(), which may be more
> easier understanding.
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>

Thanks, applied to ppc-next. And sorry for not replying earlier.


Alex

  reply	other threads:[~2014-10-15 13:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-15 13:48 [PATCH v2] target-ppc: kvm: Fix memory overflow issue about strncat() Chen Gang
2014-10-15 13:48 ` [Qemu-devel] " Chen Gang
2014-10-15 13:52 ` Alexander Graf [this message]
2014-10-15 13:52   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=543E7C29.2030507@suse.de \
    --to=agraf@suse.de \
    --cc=gang.chen.5i5j@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.