From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH for-4.5] tools/libxl: Fix building against libxl for LIBXL_API_VERSION < 0x040500
Date: Fri, 17 Oct 2014 12:01:54 +0100 [thread overview]
Message-ID: <5440F722.4090209@citrix.com> (raw)
In-Reply-To: <21568.63163.931343.323308@mariner.uk.xensource.com>
On 17/10/14 12:00, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH for-4.5] tools/libxl: Fix building against libxl for LIBXL_API_VERSION < 0x040500"):
>> c/s 6276f66ebe "libxl: libxl_uuid_copy now takes a ctx argument" introduces
>> API compatibiltiy for libxl_uuid_copy() which sadly is not valid C. Fix it.
> ...
>> #if defined(LIBXL_API_VERSION) && LIBXL_API_VERSION < 0x040500
>> -void libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, dst, src)
> I think this was intended to read
> #define libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, dst, src)
> but should in fact read
> #define libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, (dst), (src))
Does this even work?
Won't the parser complain about passing 3 parameters to a two-parameter
macro?
~Andrew
next prev parent reply other threads:[~2014-10-17 11:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 8:56 [PATCH for-4.5] tools/libxl: Fix building against libxl for LIBXL_API_VERSION < 0x040500 Andrew Cooper
2014-10-17 10:01 ` Wei Liu
2014-10-17 11:00 ` Ian Jackson
2014-10-17 11:01 ` Andrew Cooper [this message]
2014-10-17 11:05 ` Ian Jackson
2014-10-17 11:08 ` Ian Jackson
2014-10-17 14:19 ` Andrew Cooper
2014-10-20 14:46 ` Ian Campbell
2014-10-23 12:19 ` Andrew Cooper
2014-10-23 12:22 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5440F722.4090209@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.