From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH for-4.5] tools/libxl: Fix building against libxl for LIBXL_API_VERSION < 0x040500
Date: Fri, 17 Oct 2014 15:19:46 +0100 [thread overview]
Message-ID: <54412582.8050203@citrix.com> (raw)
In-Reply-To: <21568.63641.51091.765530@mariner.uk.xensource.com>
On 17/10/14 12:08, Ian Jackson wrote:
> Ian Jackson writes ("Re: [PATCH for-4.5] tools/libxl: Fix building against libxl for LIBXL_API_VERSION < 0x040500"):
>> Andrew Cooper writes ("Re: [PATCH for-4.5] tools/libxl: Fix building against libxl for LIBXL_API_VERSION < 0x040500"):
>>> On 17/10/14 12:00, Ian Jackson wrote:
>>>> I think this was intended to read
>>>> #define libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, dst, src)
>>>> but should in fact read
>>>> #define libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, (dst), (src))
> Having checked the rules, for C++ this might conceivably have to be
> #define libxl_uuid_copy(dst, src) (libxl_uuid_copy(NULL, (dst), (src)))
>
> Ian.
Fundamentally, I am not really fussed how this is fixed, although I have
confirmed my patch fixes the libvirt build in the XenServer branch I am
attempting to test Xen-4.5 under.
~Andrew
next prev parent reply other threads:[~2014-10-17 14:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 8:56 [PATCH for-4.5] tools/libxl: Fix building against libxl for LIBXL_API_VERSION < 0x040500 Andrew Cooper
2014-10-17 10:01 ` Wei Liu
2014-10-17 11:00 ` Ian Jackson
2014-10-17 11:01 ` Andrew Cooper
2014-10-17 11:05 ` Ian Jackson
2014-10-17 11:08 ` Ian Jackson
2014-10-17 14:19 ` Andrew Cooper [this message]
2014-10-20 14:46 ` Ian Campbell
2014-10-23 12:19 ` Andrew Cooper
2014-10-23 12:22 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54412582.8050203@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.