From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Doug Anderson <dianders@chromium.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Mark Brown <broonie@kernel.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions
Date: Mon, 20 Oct 2014 23:47:40 +0200 [thread overview]
Message-ID: <544582FC.9010005@collabora.co.uk> (raw)
In-Reply-To: <CAD=FV=XnBWWKbrey1zmxtAzGYviJJad4pWOC4=bbf2e2OBgaeQ@mail.gmail.com>
Hello Doug,
On 10/20/2014 11:40 PM, Doug Anderson wrote:
> Javier,
>
> On Mon, Oct 20, 2014 at 2:05 PM, Javier Martinez Canillas
> <javier.martinez@collabora.co.uk> wrote:
>> The regulator framework has a set of helpers functions to be used when
>> the system is entering and leaving from suspend but these are not called
>> on Exynos platforms. This means that the .set_suspend_* function handlers
>> defined by regulator drivers are not called when the system is suspended.
>>
>> Suggested-by: Doug Anderson <dianders@chromium.org>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>
> I think you forgot to carry Chanwoo's review:
>
> Reviewed-by: Chanwoo Choi<cw00.choi@samsung.com>
>
> I don't think you've made any changes that would need to invalidate his review.
>
Yes, I forgot to add the tag to my local branch so it was missed when generating
the patch for the new version, sorry about that...
Best regards,
Javier
WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions
Date: Mon, 20 Oct 2014 23:47:40 +0200 [thread overview]
Message-ID: <544582FC.9010005@collabora.co.uk> (raw)
In-Reply-To: <CAD=FV=XnBWWKbrey1zmxtAzGYviJJad4pWOC4=bbf2e2OBgaeQ@mail.gmail.com>
Hello Doug,
On 10/20/2014 11:40 PM, Doug Anderson wrote:
> Javier,
>
> On Mon, Oct 20, 2014 at 2:05 PM, Javier Martinez Canillas
> <javier.martinez@collabora.co.uk> wrote:
>> The regulator framework has a set of helpers functions to be used when
>> the system is entering and leaving from suspend but these are not called
>> on Exynos platforms. This means that the .set_suspend_* function handlers
>> defined by regulator drivers are not called when the system is suspended.
>>
>> Suggested-by: Doug Anderson <dianders@chromium.org>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>
> I think you forgot to carry Chanwoo's review:
>
> Reviewed-by: Chanwoo Choi<cw00.choi@samsung.com>
>
> I don't think you've made any changes that would need to invalidate his review.
>
Yes, I forgot to add the tag to my local branch so it was missed when generating
the patch for the new version, sorry about that...
Best regards,
Javier
next prev parent reply other threads:[~2014-10-20 21:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 21:05 [PATCH v3 0/2] ARM: EXYNOS: Call regulator suspend prepare/finish Javier Martinez Canillas
2014-10-20 21:05 ` Javier Martinez Canillas
2014-10-20 21:05 ` [PATCH v3 1/2] Revert "mfd: sec-core: Prepare regulators for suspend state to reduce power-consumption" Javier Martinez Canillas
2014-10-20 21:05 ` Javier Martinez Canillas
2014-10-20 21:41 ` Doug Anderson
2014-10-20 21:41 ` Doug Anderson
2014-10-20 23:41 ` Chanwoo Choi
2014-10-20 23:41 ` Chanwoo Choi
2014-10-21 11:56 ` Lee Jones
2014-10-21 11:56 ` Lee Jones
2014-10-20 21:05 ` [PATCH v3 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions Javier Martinez Canillas
2014-10-20 21:05 ` Javier Martinez Canillas
2014-10-20 21:40 ` Doug Anderson
2014-10-20 21:40 ` Doug Anderson
2014-10-20 21:47 ` Javier Martinez Canillas [this message]
2014-10-20 21:47 ` Javier Martinez Canillas
2014-10-30 10:06 ` Javier Martinez Canillas
2014-10-30 10:06 ` Javier Martinez Canillas
2014-11-11 10:23 ` Javier Martinez Canillas
2014-11-11 10:23 ` Javier Martinez Canillas
2014-11-12 17:02 ` Olof Johansson
2014-11-12 17:02 ` Olof Johansson
2014-11-13 2:12 ` Kukjin Kim
2014-11-13 2:12 ` Kukjin Kim
2014-11-13 8:36 ` Javier Martinez Canillas
2014-11-13 8:36 ` Javier Martinez Canillas
2014-10-21 7:24 ` [PATCH v3 0/2] ARM: EXYNOS: Call regulator suspend prepare/finish Krzysztof Kozłowski
2014-10-21 7:24 ` Krzysztof Kozłowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544582FC.9010005@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.