Fwd: [OPW PATCH 1/4] tools/xl: Calling _init and _dispose function for libxl types

Fwd: [OPW PATCH 1/4] tools/xl: Calling _init and _dispose function for libxl types

[Uma Sharma]

Hi all,

This series of patches will contain added calls to _init and _dispose
function for IDL generated libxl types in tools/libxl/xl_cmdimpl.c.

IDL generated libxl types should be used only after calling the init function.

Summary of the patches:

[PATCH 1/4] Calling _init and _dispose function for libxl types
[PATCH 2/4] Call init function for libxl_domain_sched_params
[PATCH 3/4] Call init function for libxl_bitmap
[PATCH 4/4] Call init and dispose function for libxl_dominfo

Regards,
Uma Sharma

Re: Fwd: [OPW PATCH 1/4] tools/xl: Calling _init and _dispose function for libxl types

[George Dunlap]

On Mon, Oct 20, 2014 at 10:41 PM, Uma Sharma <uma.sharma523@gmail.com> wrote:
> Hi all,
>
> This series of patches will contain added calls to _init and _dispose
> function for IDL generated libxl types in tools/libxl/xl_cmdimpl.c.
>
> IDL generated libxl types should be used only after calling the init function.
>
> Summary of the patches:
>
> [PATCH 1/4] Calling _init and _dispose function for libxl types
> [PATCH 2/4] Call init function for libxl_domain_sched_params
> [PATCH 3/4] Call init function for libxl_bitmap
> [PATCH 4/4] Call init and dispose function for libxl_dominfo

Almost there. :-)

What you want is to have the "cover letter" be "0/N".  A couple of
ways to do this; one simple way is like this:

git format-patch --subject-prefix="OPW PATCH vX" --cover-letter
$EDITOR 0000-cover-letter.patch
git send-email *.patch

Another is something like this:

git send-email --subject-prefix="OPW PATCH vX" --cover-letter --annotate

The second way is more compact and doesn't make a bunch of files that
you then have to deal with; but it does mean opening the editor for
each of the patches as well as the cover letter.

Normally I also keep a copy of the text of the cover letter around
somewhere else so you can cut-and-paste instead of having to type in a
new one every time.

For something that git users do so much, this is strangely complicated...

 -George

Re: Fwd: [OPW PATCH 1/4] tools/xl: Calling _init and _dispose function for libxl types

[David Vrabel]

On 21/10/14 11:32, George Dunlap wrote:
> 
> git send-email --subject-prefix="OPW PATCH vX" --cover-letter --annotate

Use git send-email --compose to only edit the cover letter.

David

Re: Fwd: [OPW PATCH 1/4] tools/xl: Calling _init and _dispose function for libxl types

[Uma Sharma]

Should I resend the patches then?

Regards,
Uma Sharma

On Tue, Oct 21, 2014 at 4:02 PM, George Dunlap
<George.Dunlap@eu.citrix.com> wrote:
> On Mon, Oct 20, 2014 at 10:41 PM, Uma Sharma <uma.sharma523@gmail.com> wrote:
>> Hi all,
>>
>> This series of patches will contain added calls to _init and _dispose
>> function for IDL generated libxl types in tools/libxl/xl_cmdimpl.c.
>>
>> IDL generated libxl types should be used only after calling the init function.
>>
>> Summary of the patches:
>>
>> [PATCH 1/4] Calling _init and _dispose function for libxl types
>> [PATCH 2/4] Call init function for libxl_domain_sched_params
>> [PATCH 3/4] Call init function for libxl_bitmap
>> [PATCH 4/4] Call init and dispose function for libxl_dominfo
>
> Almost there. :-)
>
> What you want is to have the "cover letter" be "0/N".  A couple of
> ways to do this; one simple way is like this:
>
> git format-patch --subject-prefix="OPW PATCH vX" --cover-letter
> $EDITOR 0000-cover-letter.patch
> git send-email *.patch
>
> Another is something like this:
>
> git send-email --subject-prefix="OPW PATCH vX" --cover-letter --annotate
>
> The second way is more compact and doesn't make a bunch of files that
> you then have to deal with; but it does mean opening the editor for
> each of the patches as well as the cover letter.
>
> Normally I also keep a copy of the text of the cover letter around
> somewhere else so you can cut-and-paste instead of having to type in a
> new one every time.
>
> For something that git users do so much, this is strangely complicated...
>
>  -George

Re: Fwd: [OPW PATCH 1/4] tools/xl: Calling _init and _dispose function for libxl types

[George Dunlap]

On Tue, Oct 21, 2014 at 5:34 PM, Uma Sharma <uma.sharma523@gmail.com> wrote:
> Should I resend the patches then?

On the xen-devel list, always reply at the bottom, like this.  :-)

I think normally it wouldn't matter, but since the point of the
exercise is to get you familiar with the tools, I'd say yes, why don't
you send them again (maybe using the 'v2' tag).

 -George

Re: Fwd: [OPW PATCH 1/4] tools/xl: Calling _init and _dispose function for libxl types

[Ian Campbell]

On Tue, 2014-10-21 at 18:04 +0100, George Dunlap wrote:

Just getting back to these after the freeze.

> On Tue, Oct 21, 2014 at 5:34 PM, Uma Sharma <uma.sharma523@gmail.com> wrote:
> > Should I resend the patches then?
> 
> On the xen-devel list, always reply at the bottom, like this.  :-)
> 
> I think normally it wouldn't matter, but since the point of the
> exercise is to get you familiar with the tools, I'd say yes, why don't
> you send them again (maybe using the 'v2' tag).

Was there a v2 here? If so I seem to have misplaced it.

As it stands it looks like I have:
[OPW PATCH 2/4] tools/xl: Call init function for libxl_domain_sched_params
(AKA <544581bd.847e460a.4ff9.ffffab04@mx.google.com>)
[OPW PATCH 3/4] tools/xl: Call init function for libxl_bitmap
(AKA <54458271.a28b420a.52e5.ffffae47@mx.google.com>)

Both of which are acked by Wei, I have applied them.

I don't seem to have the actual 1/4 patch, or was 1/4 just the cover
letter?

[OPW PATCH 4/4] tools/xl:Call init and dispose function for libxl_dominfo
(AKA <544583e4.c8e7420a.6486.ffffb2da@mx.google.com>) was incorrect, as
was the followup "tools/xl:Making _dispose function simplicity for
libxl_dominfo". I think the code in that case is correct as is.

Please let me know if there are any other outstanding patches from the
OPW application process which I've missed.

Ian.

Re: Fwd: [OPW PATCH 1/4] tools/xl: Calling _init and _dispose function for libxl types

[Uma Sharma]

There was no v2 (v2 was not created properly).
Yes, 1/4 was the cover letter. And 4/4 was not correct.

Thank you for applying the patches.

On Mon, Jan 12, 2015 at 11:29 PM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> On Tue, 2014-10-21 at 18:04 +0100, George Dunlap wrote:
>
> Just getting back to these after the freeze.
>
>> On Tue, Oct 21, 2014 at 5:34 PM, Uma Sharma <uma.sharma523@gmail.com> wrote:
>> > Should I resend the patches then?
>>
>> On the xen-devel list, always reply at the bottom, like this.  :-)
>>
>> I think normally it wouldn't matter, but since the point of the
>> exercise is to get you familiar with the tools, I'd say yes, why don't
>> you send them again (maybe using the 'v2' tag).
>
> Was there a v2 here? If so I seem to have misplaced it.
>
> As it stands it looks like I have:
> [OPW PATCH 2/4] tools/xl: Call init function for libxl_domain_sched_params
> (AKA <544581bd.847e460a.4ff9.ffffab04@mx.google.com>)
> [OPW PATCH 3/4] tools/xl: Call init function for libxl_bitmap
> (AKA <54458271.a28b420a.52e5.ffffae47@mx.google.com>)
>
> Both of which are acked by Wei, I have applied them.
>
> I don't seem to have the actual 1/4 patch, or was 1/4 just the cover
> letter?
>
> [OPW PATCH 4/4] tools/xl:Call init and dispose function for libxl_dominfo
> (AKA <544583e4.c8e7420a.6486.ffffb2da@mx.google.com>) was incorrect, as
> was the followup "tools/xl:Making _dispose function simplicity for
> libxl_dominfo". I think the code in that case is correct as is.
>
> Please let me know if there are any other outstanding patches from the
> OPW application process which I've missed.
>
> Ian.
>



-- 
Regards,
Uma Sharma
http://about.me/umasharma