From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] power: reset: at91-reset: fix power down register
Date: Tue, 21 Oct 2014 16:18:34 +0200 [thread overview]
Message-ID: <54466B3A.5030005@atmel.com> (raw)
In-Reply-To: <1413829629-8705-1-git-send-email-alexandre.belloni@free-electrons.com>
On 20/10/2014 20:27, Alexandre Belloni :
> In the case of at91sam9g45_restart(), the driver is writing
> AT91_DDRSDRC_LPCB_POWER_DOWN to AT91_DDRSDRC_RTR, this should actually be
> AT91_DDRSDRC_LPR.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Absolutely:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
If you don't mind Dmitry, I'll take this patch through the at91/arm-soc
git trees in my next at91-3.18-fixes branch.
Thanks Alex, bye,
> ---
> drivers/power/reset/at91-reset.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c
> index 3611806c9cfd..3cb36693343a 100644
> --- a/drivers/power/reset/at91-reset.c
> +++ b/drivers/power/reset/at91-reset.c
> @@ -100,11 +100,11 @@ static void at91sam9g45_restart(enum reboot_mode mode, const char *cmd)
> /* Disable SDRAM0 accesses */
> "1: str %3, [%0, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
> /* Power down SDRAM0 */
> - " str %4, [%0, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
> + " str %4, [%0, #" __stringify(AT91_DDRSDRC_LPR) "]\n\t"
> /* Disable SDRAM1 accesses */
> " strne %3, [%1, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
> /* Power down SDRAM1 */
> - " strne %4, [%1, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
> + " strne %4, [%1, #" __stringify(AT91_DDRSDRC_LPR) "]\n\t"
> /* Reset CPU */
> " str %5, [%2, #" __stringify(AT91_RSTC_CR) "]\n\t"
>
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] power: reset: at91-reset: fix power down register
Date: Tue, 21 Oct 2014 16:18:34 +0200 [thread overview]
Message-ID: <54466B3A.5030005@atmel.com> (raw)
In-Reply-To: <1413829629-8705-1-git-send-email-alexandre.belloni@free-electrons.com>
On 20/10/2014 20:27, Alexandre Belloni :
> In the case of at91sam9g45_restart(), the driver is writing
> AT91_DDRSDRC_LPCB_POWER_DOWN to AT91_DDRSDRC_RTR, this should actually be
> AT91_DDRSDRC_LPR.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Absolutely:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
If you don't mind Dmitry, I'll take this patch through the at91/arm-soc
git trees in my next at91-3.18-fixes branch.
Thanks Alex, bye,
> ---
> drivers/power/reset/at91-reset.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c
> index 3611806c9cfd..3cb36693343a 100644
> --- a/drivers/power/reset/at91-reset.c
> +++ b/drivers/power/reset/at91-reset.c
> @@ -100,11 +100,11 @@ static void at91sam9g45_restart(enum reboot_mode mode, const char *cmd)
> /* Disable SDRAM0 accesses */
> "1: str %3, [%0, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
> /* Power down SDRAM0 */
> - " str %4, [%0, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
> + " str %4, [%0, #" __stringify(AT91_DDRSDRC_LPR) "]\n\t"
> /* Disable SDRAM1 accesses */
> " strne %3, [%1, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
> /* Power down SDRAM1 */
> - " strne %4, [%1, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
> + " strne %4, [%1, #" __stringify(AT91_DDRSDRC_LPR) "]\n\t"
> /* Reset CPU */
> " str %5, [%2, #" __stringify(AT91_RSTC_CR) "]\n\t"
>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2014-10-21 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 18:27 [PATCH] power: reset: at91-reset: fix power down register Alexandre Belloni
2014-10-20 18:27 ` Alexandre Belloni
2014-10-21 14:18 ` Nicolas Ferre [this message]
2014-10-21 14:18 ` Nicolas Ferre
2014-10-21 14:46 ` Sebastian Reichel
2014-10-21 14:46 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54466B3A.5030005@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.