From: Gary Thomas <gary@mlbassoc.com>
To: Otavio Salvador <otavio@ossystems.com.br>,
Neena Busireddy <neena.busireddy@freescale.com>
Cc: "meta-freescale@yoctoproject.org" <meta-freescale@yoctoproject.org>
Subject: Re: [meta-fsl-arm] [PATCH] cairo: Fix PACKAGECONFIG settings
Date: Wed, 22 Oct 2014 11:50:49 -0600 [thread overview]
Message-ID: <5447EE79.6040504@mlbassoc.com> (raw)
In-Reply-To: <CAP9ODKrq=79fJQ1TP=qzxyQ3vjQiJnz4CKL0P62cL8pZ2_jw0A@mail.gmail.com>
On 2014-10-22 09:36, Otavio Salvador wrote:
> On Wed, Oct 22, 2014 at 12:38 PM, Neena Busireddy
> <neena.busireddy@freescale.com> wrote:
>> Hi Otavio,
>>
>> On Tue, Oct 21, 2014 at 10:12 AM, Gary Thomas <gary@mlbassoc.com> wrote:
>>> Remove a forced setting of PACKAGECONFIG_mx6 - this caused some flags
>>> which were set by the main recipe to be lost, e.g. "x11". The flags
>>> which are being set by these lines are correctly set in the main
>>> recipe, so this change fixes the errant behaviour with no other side effects.
>>>
>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>>
>> Can you review this patch and comment?
>>
>> Looks like you added the PACKAGECONFIG for directfb in cairo.bbappend. I have no idea
>> why it was added. However, that patch looks good to me.
>
> That means Gary one or the way it was before?
>
Setting PACKAGECONFIG directly in the .bbappend is clearly
wrong as it erases any settings made by the main recipe which
is doing the same setting any way. Hence my patch.
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
next prev parent reply other threads:[~2014-10-22 17:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 12:12 [meta-fsl-arm] [PATCH] cairo: Fix PACKAGECONFIG settings Gary Thomas
2014-10-22 12:49 ` Otavio Salvador
2014-10-22 14:38 ` Neena Busireddy
2014-10-22 15:36 ` Otavio Salvador
2014-10-22 17:50 ` Gary Thomas [this message]
2014-10-22 17:53 ` Neena Busireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5447EE79.6040504@mlbassoc.com \
--to=gary@mlbassoc.com \
--cc=meta-freescale@yoctoproject.org \
--cc=neena.busireddy@freescale.com \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.