* [meta-fsl-arm] [PATCH] cairo: Fix PACKAGECONFIG settings
@ 2014-10-21 12:12 Gary Thomas
2014-10-22 12:49 ` Otavio Salvador
0 siblings, 1 reply; 6+ messages in thread
From: Gary Thomas @ 2014-10-21 12:12 UTC (permalink / raw)
To: meta-freescale; +Cc: Gary Thomas
Remove a forced setting of PACKAGECONFIG_mx6 - this caused some flags
which were set by the main recipe to be lost, e.g. "x11". The flags
which are being set by these lines are correctly set in the main recipe,
so this change fixes the errant behaviour with no other side effects.
Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
recipes-graphics/cairo/cairo_%.bbappend | 3 ---
1 file changed, 3 deletions(-)
diff --git a/recipes-graphics/cairo/cairo_%.bbappend b/recipes-graphics/cairo/cairo_%.bbappend
index 9eb3253..2b72535 100644
--- a/recipes-graphics/cairo/cairo_%.bbappend
+++ b/recipes-graphics/cairo/cairo_%.bbappend
@@ -6,8 +6,5 @@ CFLAGS_append_mx6 = " -DLINUX \
'-DEGL_API_DFB', '-DEGL_API_FB', d),d),d)}"
-PACKAGECONFIG_mx6 = " \
- ${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)}"
-
PACKAGECONFIG_append_mx6q = " egl glesv2"
PACKAGECONFIG_append_mx6dl = " egl glesv2"
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-fsl-arm] [PATCH] cairo: Fix PACKAGECONFIG settings
2014-10-21 12:12 [meta-fsl-arm] [PATCH] cairo: Fix PACKAGECONFIG settings Gary Thomas
@ 2014-10-22 12:49 ` Otavio Salvador
2014-10-22 14:38 ` Neena Busireddy
0 siblings, 1 reply; 6+ messages in thread
From: Otavio Salvador @ 2014-10-22 12:49 UTC (permalink / raw)
To: Gary Thomas, Neena Busireddy; +Cc: meta-freescale@yoctoproject.org
Hello Neena,
On Tue, Oct 21, 2014 at 10:12 AM, Gary Thomas <gary@mlbassoc.com> wrote:
> Remove a forced setting of PACKAGECONFIG_mx6 - this caused some flags
> which were set by the main recipe to be lost, e.g. "x11". The flags
> which are being set by these lines are correctly set in the main recipe,
> so this change fixes the errant behaviour with no other side effects.
>
> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
Can you review this patch and comment?
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-fsl-arm] [PATCH] cairo: Fix PACKAGECONFIG settings
2014-10-22 12:49 ` Otavio Salvador
@ 2014-10-22 14:38 ` Neena Busireddy
2014-10-22 15:36 ` Otavio Salvador
0 siblings, 1 reply; 6+ messages in thread
From: Neena Busireddy @ 2014-10-22 14:38 UTC (permalink / raw)
To: Otavio Salvador, Gary Thomas; +Cc: meta-freescale@yoctoproject.org
Hi Otavio,
On Tue, Oct 21, 2014 at 10:12 AM, Gary Thomas <gary@mlbassoc.com> wrote:
> Remove a forced setting of PACKAGECONFIG_mx6 - this caused some flags
> which were set by the main recipe to be lost, e.g. "x11". The flags
> which are being set by these lines are correctly set in the main
> recipe, so this change fixes the errant behaviour with no other side effects.
>
> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
Can you review this patch and comment?
Looks like you added the PACKAGECONFIG for directfb in cairo.bbappend. I have no idea
why it was added. However, that patch looks good to me.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-fsl-arm] [PATCH] cairo: Fix PACKAGECONFIG settings
2014-10-22 14:38 ` Neena Busireddy
@ 2014-10-22 15:36 ` Otavio Salvador
2014-10-22 17:50 ` Gary Thomas
2014-10-22 17:53 ` Neena Busireddy
0 siblings, 2 replies; 6+ messages in thread
From: Otavio Salvador @ 2014-10-22 15:36 UTC (permalink / raw)
To: Neena Busireddy; +Cc: meta-freescale@yoctoproject.org, Gary Thomas
On Wed, Oct 22, 2014 at 12:38 PM, Neena Busireddy
<neena.busireddy@freescale.com> wrote:
> Hi Otavio,
>
> On Tue, Oct 21, 2014 at 10:12 AM, Gary Thomas <gary@mlbassoc.com> wrote:
>> Remove a forced setting of PACKAGECONFIG_mx6 - this caused some flags
>> which were set by the main recipe to be lost, e.g. "x11". The flags
>> which are being set by these lines are correctly set in the main
>> recipe, so this change fixes the errant behaviour with no other side effects.
>>
>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>
> Can you review this patch and comment?
>
> Looks like you added the PACKAGECONFIG for directfb in cairo.bbappend. I have no idea
> why it was added. However, that patch looks good to me.
That means Gary one or the way it was before?
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-fsl-arm] [PATCH] cairo: Fix PACKAGECONFIG settings
2014-10-22 15:36 ` Otavio Salvador
@ 2014-10-22 17:50 ` Gary Thomas
2014-10-22 17:53 ` Neena Busireddy
1 sibling, 0 replies; 6+ messages in thread
From: Gary Thomas @ 2014-10-22 17:50 UTC (permalink / raw)
To: Otavio Salvador, Neena Busireddy; +Cc: meta-freescale@yoctoproject.org
On 2014-10-22 09:36, Otavio Salvador wrote:
> On Wed, Oct 22, 2014 at 12:38 PM, Neena Busireddy
> <neena.busireddy@freescale.com> wrote:
>> Hi Otavio,
>>
>> On Tue, Oct 21, 2014 at 10:12 AM, Gary Thomas <gary@mlbassoc.com> wrote:
>>> Remove a forced setting of PACKAGECONFIG_mx6 - this caused some flags
>>> which were set by the main recipe to be lost, e.g. "x11". The flags
>>> which are being set by these lines are correctly set in the main
>>> recipe, so this change fixes the errant behaviour with no other side effects.
>>>
>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>>
>> Can you review this patch and comment?
>>
>> Looks like you added the PACKAGECONFIG for directfb in cairo.bbappend. I have no idea
>> why it was added. However, that patch looks good to me.
>
> That means Gary one or the way it was before?
>
Setting PACKAGECONFIG directly in the .bbappend is clearly
wrong as it erases any settings made by the main recipe which
is doing the same setting any way. Hence my patch.
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-fsl-arm] [PATCH] cairo: Fix PACKAGECONFIG settings
2014-10-22 15:36 ` Otavio Salvador
2014-10-22 17:50 ` Gary Thomas
@ 2014-10-22 17:53 ` Neena Busireddy
1 sibling, 0 replies; 6+ messages in thread
From: Neena Busireddy @ 2014-10-22 17:53 UTC (permalink / raw)
To: Otavio Salvador; +Cc: meta-freescale@yoctoproject.org, Gary Thomas
On Wed, Oct 22, 2014 at 12:38 PM, Neena Busireddy <neena.busireddy@freescale.com> wrote:
> Hi Otavio,
>
> On Tue, Oct 21, 2014 at 10:12 AM, Gary Thomas <gary@mlbassoc.com> wrote:
>> Remove a forced setting of PACKAGECONFIG_mx6 - this caused some flags
>> which were set by the main recipe to be lost, e.g. "x11". The flags
>> which are being set by these lines are correctly set in the main
>> recipe, so this change fixes the errant behaviour with no other side effects.
>>
>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>
> Can you review this patch and comment?
>
> Looks like you added the PACKAGECONFIG for directfb in cairo.bbappend.
> I have no idea why it was added. However, that patch looks good to me.
That means Gary one or the way it was before?
It was Gary patch.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-22 18:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-21 12:12 [meta-fsl-arm] [PATCH] cairo: Fix PACKAGECONFIG settings Gary Thomas
2014-10-22 12:49 ` Otavio Salvador
2014-10-22 14:38 ` Neena Busireddy
2014-10-22 15:36 ` Otavio Salvador
2014-10-22 17:50 ` Gary Thomas
2014-10-22 17:53 ` Neena Busireddy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.