All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: thuth@linux.vnet.ibm.com, kvm@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, Andy Lutomirski <luto@amacapital.net>,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH RFC 00/11] qemu: towards virtio-1 host support
Date: Thu, 23 Oct 2014 08:44:09 +0200	[thread overview]
Message-ID: <5448A3B9.4050400@siemens.com> (raw)
In-Reply-To: <1414010056.364.20.camel@pasglop>

On 2014-10-22 22:34, Benjamin Herrenschmidt wrote:
> On Wed, 2014-10-22 at 16:17 +0200, Jan Kiszka wrote:
>> I thought about this again, and I'm not sure anymore if we can use
>> ACPI
>> to "black-list" the incompatible virtio devices. Reason: hotplug. To
>> my
>> understanding, the ACPI DRHD tables won't change during runtime when a
>> device shows up or disappears. We would have to isolate virtio devices
>> from the rest of the system by using separate buses for it (and avoid
>> listing those in any DRHD table) and enforce that they only get
>> plugged
>> into those buses. I suppose that is not desirable.
>>
>> Maybe it's better to fix virtio /wrt IOMMUs.
> 
> I always go back to my initial proposal which is to define that current
> virtio always bypass any iommu (which is what it does really) and have
> it expose via a new capability if that isn't the case. That means fixing
> that Xen thingy to allow qemu to know what to expose I assume but that
> seems to be the less bad approach.

Just one thing to consider: feature negotiation happens after guest
startup. If we run a virtio device under IOMMU control, what will we
have to do when the guest says it does not support such devices? Simply
reject operation?

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: thuth@linux.vnet.ibm.com, kvm@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, Andy Lutomirski <luto@amacapital.net>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH RFC 00/11] qemu: towards virtio-1 host support
Date: Thu, 23 Oct 2014 08:44:09 +0200	[thread overview]
Message-ID: <5448A3B9.4050400@siemens.com> (raw)
In-Reply-To: <1414010056.364.20.camel@pasglop>

On 2014-10-22 22:34, Benjamin Herrenschmidt wrote:
> On Wed, 2014-10-22 at 16:17 +0200, Jan Kiszka wrote:
>> I thought about this again, and I'm not sure anymore if we can use
>> ACPI
>> to "black-list" the incompatible virtio devices. Reason: hotplug. To
>> my
>> understanding, the ACPI DRHD tables won't change during runtime when a
>> device shows up or disappears. We would have to isolate virtio devices
>> from the rest of the system by using separate buses for it (and avoid
>> listing those in any DRHD table) and enforce that they only get
>> plugged
>> into those buses. I suppose that is not desirable.
>>
>> Maybe it's better to fix virtio /wrt IOMMUs.
> 
> I always go back to my initial proposal which is to define that current
> virtio always bypass any iommu (which is what it does really) and have
> it expose via a new capability if that isn't the case. That means fixing
> that Xen thingy to allow qemu to know what to expose I assume but that
> seems to be the less bad approach.

Just one thing to consider: feature negotiation happens after guest
startup. If we run a virtio device under IOMMU control, what will we
have to do when the guest says it does not support such devices? Simply
reject operation?

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux

  reply	other threads:[~2014-10-23  6:44 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-07 14:39 [PATCH RFC 00/11] qemu: towards virtio-1 host support Cornelia Huck
2014-10-07 14:39 ` [Qemu-devel] " Cornelia Huck
2014-10-07 14:39 ` [PATCH RFC 01/11] linux-headers/virtio_config: Update with VIRTIO_F_VERSION_1 Cornelia Huck
2014-10-07 14:39 ` Cornelia Huck
2014-10-07 14:39   ` [Qemu-devel] " Cornelia Huck
2014-10-07 14:39 ` [PATCH RFC 02/11] virtio: cull virtio_bus_set_vdev_features Cornelia Huck
2014-10-07 14:39   ` [Qemu-devel] " Cornelia Huck
2014-10-07 14:39 ` Cornelia Huck
2014-10-07 14:39 ` [PATCH RFC 03/11] virtio: support more feature bits Cornelia Huck
2014-10-07 14:39   ` [Qemu-devel] " Cornelia Huck
2014-10-13  5:53   ` Rusty Russell
2014-10-13  5:53     ` [Qemu-devel] " Rusty Russell
2014-10-13 10:55     ` Cornelia Huck
2014-10-13 10:55       ` [Qemu-devel] " Cornelia Huck
2014-10-07 14:39 ` Cornelia Huck
2014-10-07 14:40 ` [PATCH RFC 04/11] s390x/virtio-ccw: fix check for WRITE_FEAT Cornelia Huck
2014-10-07 14:40 ` Cornelia Huck
2014-10-07 14:40   ` [Qemu-devel] " Cornelia Huck
2014-10-07 14:40 ` [PATCH RFC 05/11] virtio: introduce legacy virtio devices Cornelia Huck
2014-10-07 14:40   ` [Qemu-devel] " Cornelia Huck
2014-10-28 15:40   ` Greg Kurz
2014-10-28 15:40     ` Greg Kurz
2014-10-30 18:02     ` Cornelia Huck
2014-10-30 18:02       ` Cornelia Huck
2014-10-30 22:29       ` Greg Kurz
2014-10-30 22:29         ` Greg Kurz
2014-11-03 11:44         ` Cornelia Huck
2014-11-03 11:44           ` Cornelia Huck
2014-11-03 11:44         ` Cornelia Huck
2014-10-28 15:40   ` Greg Kurz
2014-10-07 14:40 ` [PATCH RFC 06/11] virtio: allow virtio-1 queue layout Cornelia Huck
2014-10-07 14:40   ` [Qemu-devel] " Cornelia Huck
2014-10-07 14:40 ` [PATCH RFC 07/11] dataplane: allow virtio-1 devices Cornelia Huck
2014-10-07 14:40 ` Cornelia Huck
2014-10-07 14:40   ` [Qemu-devel] " Cornelia Huck
2014-10-28 15:22   ` Greg Kurz
2014-10-28 15:22     ` Greg Kurz
2014-10-30  9:18     ` Cornelia Huck
2014-10-30  9:18       ` Cornelia Huck
2014-10-28 15:22   ` Greg Kurz
2014-10-07 14:40 ` [PATCH RFC 08/11] s390x/css: Add a callback for when subchannel gets disabled Cornelia Huck
2014-10-07 14:40 ` Cornelia Huck
2014-10-07 14:40   ` [Qemu-devel] " Cornelia Huck
2014-10-07 14:40 ` [PATCH RFC 09/11] s390x/virtio-ccw: add virtio set-revision call Cornelia Huck
2014-10-07 14:40   ` [Qemu-devel] " Cornelia Huck
2014-10-07 14:40 ` Cornelia Huck
2014-10-07 14:40 ` [PATCH RFC 10/11] s390x/virtio-ccw: support virtio-1 set_vq format Cornelia Huck
2014-10-07 14:40   ` [Qemu-devel] " Cornelia Huck
2014-10-07 14:40 ` [PATCH RFC 11/11] s390x/virtio-ccw: enable virtio 1.0 Cornelia Huck
2014-10-07 14:40 ` Cornelia Huck
2014-10-07 14:40   ` [Qemu-devel] " Cornelia Huck
2014-10-08  1:24 ` [PATCH RFC 00/11] qemu: towards virtio-1 host support Andy Lutomirski
2014-10-08  1:24   ` [Qemu-devel] " Andy Lutomirski
2014-10-08  9:04   ` Cornelia Huck
2014-10-08  9:04     ` [Qemu-devel] " Cornelia Huck
2014-10-22  8:44     ` Michael S. Tsirkin
2014-10-22  8:44       ` [Qemu-devel] " Michael S. Tsirkin
2014-10-22 14:17       ` Jan Kiszka
2014-10-22 14:17         ` [Qemu-devel] " Jan Kiszka
2014-10-22 14:36         ` Michael S. Tsirkin
2014-10-22 14:36           ` [Qemu-devel] " Michael S. Tsirkin
2014-10-22 20:34         ` Benjamin Herrenschmidt
2014-10-22 20:34           ` [Qemu-devel] " Benjamin Herrenschmidt
2014-10-23  6:44           ` Jan Kiszka [this message]
2014-10-23  6:44             ` Jan Kiszka
2014-10-23  9:18             ` Michael S. Tsirkin
2014-10-23  9:18               ` [Qemu-devel] " Michael S. Tsirkin
2014-10-23  7:12           ` Michael S. Tsirkin
2014-10-23  7:12             ` [Qemu-devel] " Michael S. Tsirkin
2014-10-23 21:42 ` Michael S. Tsirkin
2014-10-23 21:42   ` [Qemu-devel] " Michael S. Tsirkin
2014-10-24  8:38   ` Cornelia Huck
2014-10-24  8:38   ` Cornelia Huck
2014-10-24  8:38     ` [Qemu-devel] " Cornelia Huck
2014-10-24 12:37     ` Cornelia Huck
2014-10-24 12:37       ` [Qemu-devel] " Cornelia Huck
2014-10-24 14:05       ` Michael S. Tsirkin
2014-10-24 14:05         ` [Qemu-devel] " Michael S. Tsirkin
2014-10-24 14:17     ` Michael S. Tsirkin
2014-10-24 14:17       ` [Qemu-devel] " Michael S. Tsirkin
2014-10-28  4:43     ` Michael S. Tsirkin
2014-10-28  4:43       ` [Qemu-devel] " Michael S. Tsirkin
2014-10-30 16:52       ` Cornelia Huck
2014-10-30 16:52         ` [Qemu-devel] " Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5448A3B9.4050400@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=benh@kernel.crashing.org \
    --cc=kvm@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@linux.vnet.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.