* [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey
@ 2014-10-22 16:46 ` Felix Fietkau
0 siblings, 0 replies; 10+ messages in thread
From: Felix Fietkau @ 2014-10-22 16:46 UTC (permalink / raw)
To: linux-wireless; +Cc: ath10k
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
drivers/net/wireless/ath/ath10k/mac.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 4670930..bc440dc 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx,
survey->channel = &sband->channels[idx];
+ if (ar->rx_channel == survey->channel)
+ survey->filled |= SURVEY_INFO_IN_USE;
+
exit:
mutex_unlock(&ar->conf_mutex);
return ret;
--
2.0.4
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey
@ 2014-10-22 16:46 ` Felix Fietkau
0 siblings, 0 replies; 10+ messages in thread
From: Felix Fietkau @ 2014-10-22 16:46 UTC (permalink / raw)
To: linux-wireless; +Cc: ath10k
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
drivers/net/wireless/ath/ath10k/mac.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 4670930..bc440dc 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx,
survey->channel = &sband->channels[idx];
+ if (ar->rx_channel == survey->channel)
+ survey->filled |= SURVEY_INFO_IN_USE;
+
exit:
mutex_unlock(&ar->conf_mutex);
return ret;
--
2.0.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey
2014-10-22 16:46 ` Felix Fietkau
@ 2014-10-23 7:13 ` Kalle Valo
-1 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2014-10-23 7:13 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, ath10k
Felix Fietkau <nbd@openwrt.org> writes:
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> ---
> drivers/net/wireless/ath/ath10k/mac.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index 4670930..bc440dc 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx,
>
> survey->channel = &sband->channels[idx];
>
> + if (ar->rx_channel == survey->channel)
> + survey->filled |= SURVEY_INFO_IN_USE;
> +
Why? Does this fix a visible bug? What changes from user space point of
view? I'm asking because I want to add something to the commit log.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey
@ 2014-10-23 7:13 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2014-10-23 7:13 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, ath10k
Felix Fietkau <nbd@openwrt.org> writes:
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> ---
> drivers/net/wireless/ath/ath10k/mac.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index 4670930..bc440dc 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx,
>
> survey->channel = &sband->channels[idx];
>
> + if (ar->rx_channel == survey->channel)
> + survey->filled |= SURVEY_INFO_IN_USE;
> +
Why? Does this fix a visible bug? What changes from user space point of
view? I'm asking because I want to add something to the commit log.
--
Kalle Valo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey
2014-10-23 7:13 ` Kalle Valo
@ 2014-10-23 10:57 ` Felix Fietkau
-1 siblings, 0 replies; 10+ messages in thread
From: Felix Fietkau @ 2014-10-23 10:57 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, ath10k
On 2014-10-23 09:13, Kalle Valo wrote:
> Felix Fietkau <nbd@openwrt.org> writes:
>
>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>> ---
>> drivers/net/wireless/ath/ath10k/mac.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
>> index 4670930..bc440dc 100644
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx,
>>
>> survey->channel = &sband->channels[idx];
>>
>> + if (ar->rx_channel == survey->channel)
>> + survey->filled |= SURVEY_INFO_IN_USE;
>> +
>
> Why? Does this fix a visible bug? What changes from user space point of
> view? I'm asking because I want to add something to the commit log.
When user space requests survey info, it is useful to know which of the
survey data refers to the channel that is currently actively being used.
One of the use cases is getting the current channel noise for status output.
Without this flag you would have to look up the channel separately and
then compare it against the frequency in the survey output in user space.
- Felix
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey
@ 2014-10-23 10:57 ` Felix Fietkau
0 siblings, 0 replies; 10+ messages in thread
From: Felix Fietkau @ 2014-10-23 10:57 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, ath10k
On 2014-10-23 09:13, Kalle Valo wrote:
> Felix Fietkau <nbd@openwrt.org> writes:
>
>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>> ---
>> drivers/net/wireless/ath/ath10k/mac.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
>> index 4670930..bc440dc 100644
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx,
>>
>> survey->channel = &sband->channels[idx];
>>
>> + if (ar->rx_channel == survey->channel)
>> + survey->filled |= SURVEY_INFO_IN_USE;
>> +
>
> Why? Does this fix a visible bug? What changes from user space point of
> view? I'm asking because I want to add something to the commit log.
When user space requests survey info, it is useful to know which of the
survey data refers to the channel that is currently actively being used.
One of the use cases is getting the current channel noise for status output.
Without this flag you would have to look up the channel separately and
then compare it against the frequency in the survey output in user space.
- Felix
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey
2014-10-23 10:57 ` Felix Fietkau
@ 2014-10-23 13:31 ` Kalle Valo
-1 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2014-10-23 13:31 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, ath10k
Felix Fietkau <nbd@openwrt.org> writes:
> On 2014-10-23 09:13, Kalle Valo wrote:
>> Felix Fietkau <nbd@openwrt.org> writes:
>>
>>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>>> ---
>>> drivers/net/wireless/ath/ath10k/mac.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
>>> index 4670930..bc440dc 100644
>>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>>> @@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx,
>>>
>>> survey->channel = &sband->channels[idx];
>>>
>>> + if (ar->rx_channel == survey->channel)
>>> + survey->filled |= SURVEY_INFO_IN_USE;
>>> +
>>
>> Why? Does this fix a visible bug? What changes from user space point of
>> view? I'm asking because I want to add something to the commit log.
>
> When user space requests survey info, it is useful to know which of the
> survey data refers to the channel that is currently actively being used.
> One of the use cases is getting the current channel noise for status output.
> Without this flag you would have to look up the channel separately and
> then compare it against the frequency in the survey output in user space.
Perfect, thanks. I added this to the commit log in ath-next-test:
commit f7528c6fca1b2ee1899069f1066012f47586a0c8
Author: Felix Fietkau <nbd@openwrt.org>
Date: Wed Oct 22 18:46:02 2014 +0200
ath10k: add SURVEY_INFO_IN_USE for current channel on survey
When user space requests survey info, it is useful to know which of the survey
data refers to the channel that is currently actively being used. One of the
use cases is getting the current channel noise for status output. Without this
flag you would have to look up the channel separately and then compare it
against the frequency in the survey output in user space.
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey
@ 2014-10-23 13:31 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2014-10-23 13:31 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, ath10k
Felix Fietkau <nbd@openwrt.org> writes:
> On 2014-10-23 09:13, Kalle Valo wrote:
>> Felix Fietkau <nbd@openwrt.org> writes:
>>
>>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>>> ---
>>> drivers/net/wireless/ath/ath10k/mac.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
>>> index 4670930..bc440dc 100644
>>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>>> @@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx,
>>>
>>> survey->channel = &sband->channels[idx];
>>>
>>> + if (ar->rx_channel == survey->channel)
>>> + survey->filled |= SURVEY_INFO_IN_USE;
>>> +
>>
>> Why? Does this fix a visible bug? What changes from user space point of
>> view? I'm asking because I want to add something to the commit log.
>
> When user space requests survey info, it is useful to know which of the
> survey data refers to the channel that is currently actively being used.
> One of the use cases is getting the current channel noise for status output.
> Without this flag you would have to look up the channel separately and
> then compare it against the frequency in the survey output in user space.
Perfect, thanks. I added this to the commit log in ath-next-test:
commit f7528c6fca1b2ee1899069f1066012f47586a0c8
Author: Felix Fietkau <nbd@openwrt.org>
Date: Wed Oct 22 18:46:02 2014 +0200
ath10k: add SURVEY_INFO_IN_USE for current channel on survey
When user space requests survey info, it is useful to know which of the survey
data refers to the channel that is currently actively being used. One of the
use cases is getting the current channel noise for status output. Without this
flag you would have to look up the channel separately and then compare it
against the frequency in the survey output in user space.
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
--
Kalle Valo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey
2014-10-22 16:46 ` Felix Fietkau
@ 2014-10-24 13:35 ` Kalle Valo
-1 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2014-10-24 13:35 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, ath10k
Felix Fietkau <nbd@openwrt.org> writes:
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Thanks, applied.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-10-24 13:36 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-22 16:46 [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey Felix Fietkau
2014-10-22 16:46 ` Felix Fietkau
2014-10-23 7:13 ` Kalle Valo
2014-10-23 7:13 ` Kalle Valo
2014-10-23 10:57 ` Felix Fietkau
2014-10-23 10:57 ` Felix Fietkau
2014-10-23 13:31 ` Kalle Valo
2014-10-23 13:31 ` Kalle Valo
2014-10-24 13:35 ` Kalle Valo
2014-10-24 13:35 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.