* [for master] dspdce-fw: Updated dspdce-fw binaries
@ 2014-09-24 11:43 Karthik Ramanan
2014-09-24 11:43 ` [for master] dspdce-fw: Updated dspdce firmware for latest IPC version Karthik Ramanan
0 siblings, 1 reply; 6+ messages in thread
From: Karthik Ramanan @ 2014-09-24 11:43 UTC (permalink / raw)
To: meta-ti
Change summary:
1. Refactor the recipe to have inc file for common portions
2. Add the new firmware that is compatible with the latest IPC.
3. Incorporated review comments from previous patch set.
4. New binary contains minor bug fixes as well.
Karthik Ramanan (1):
dspdce-fw: Updated dspdce firmware for latest IPC version
recipes-bsp/dspdce-fw/dspdce-fw.inc | 18 ++++++++++++++++++
recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb | 19 +++----------------
recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb | 11 +++++++++++
3 files changed, 32 insertions(+), 16 deletions(-)
create mode 100644 recipes-bsp/dspdce-fw/dspdce-fw.inc
create mode 100644 recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb
--
1.7.9.5
^ permalink raw reply [flat|nested] 6+ messages in thread
* [for master] dspdce-fw: Updated dspdce firmware for latest IPC version
2014-09-24 11:43 [for master] dspdce-fw: Updated dspdce-fw binaries Karthik Ramanan
@ 2014-09-24 11:43 ` Karthik Ramanan
2014-09-30 21:15 ` Denys Dmytriyenko
2014-10-01 5:44 ` [PATCH v2] " Karthik Ramanan
0 siblings, 2 replies; 6+ messages in thread
From: Karthik Ramanan @ 2014-09-24 11:43 UTC (permalink / raw)
To: meta-ti
Also refactored the dspdce-fw recipes to have inc file
for common parts
Signed-off-by: Karthik Ramanan <a0393906@ti.com>
---
recipes-bsp/dspdce-fw/dspdce-fw.inc | 18 ++++++++++++++++++
recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb | 19 +++----------------
recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb | 11 +++++++++++
3 files changed, 32 insertions(+), 16 deletions(-)
create mode 100644 recipes-bsp/dspdce-fw/dspdce-fw.inc
create mode 100644 recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb
diff --git a/recipes-bsp/dspdce-fw/dspdce-fw.inc b/recipes-bsp/dspdce-fw/dspdce-fw.inc
new file mode 100644
index 0000000..9676888
--- /dev/null
+++ b/recipes-bsp/dspdce-fw/dspdce-fw.inc
@@ -0,0 +1,18 @@
+DESCRIPTION = "Firmware for DSP for an example application called copycodectest"
+LICENSE = "TI-TSPA"
+
+COMPATIBLE_MACHINE = "dra7xx-evm"
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+S = "${WORKDIR}/dspdce-${MACHINE}-${PV}"
+
+TARGET = "dra7-dsp1-fw.xe66"
+
+do_install() {
+ mkdir -p ${D}${base_libdir}/firmware
+ cp ${S}/firmware/${TARGET} ${D}${base_libdir}/firmware/${TARGET}
+}
+
+FILES_${PN} += "${base_libdir}/firmware/${TARGET}"
+
+INSANE_SKIP_${PN} = "arch"
diff --git a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb
index 69e9814..bfc3e1f 100644
--- a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb
+++ b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb
@@ -1,24 +1,11 @@
-DESCRIPTION = "Firmware for DSP "
-LICENSE = "TI-TSPA"
+require dspdce-fw.inc
+
LIC_FILES_CHKSUM = "file://DSPDCE-${PV}-Manifest.doc;md5=587a7b9fdd99f98fbe99af4a4ba3362a"
-COMPATIBLE_MACHINE = "dra7xx-evm"
-PACKAGE_ARCH = "${MACHINE_ARCH}"
+PR = "r1"
SRC_URI = "http://downloads.ti.com/dsps/dsps_public_sw/glsdk/dspdce/1_00_00_02/exports/dspdce-${MACHINE}-1.00.00.02.tar.gz;protocol=http"
-S = "${WORKDIR}/dspdce-${MACHINE}-${PV}"
-
SRC_URI[md5sum] = "df19baf16f828b5d32b4eed50f0364f5"
SRC_URI[sha256sum] = "0c0f34674110d1ef0300b61b572a326daffb95a31cc9d45888b2e50a83c6f555"
-TARGET = "dra7-dsp1-fw.xe66"
-
-do_install() {
- mkdir -p ${D}${base_libdir}/firmware
- cp ${S}/firmware/${TARGET} ${D}${base_libdir}/firmware/${TARGET}
-}
-
-FILES_${PN} += "${base_libdir}/firmware/${TARGET}"
-
-INSANE_SKIP_${PN} = "arch"
diff --git a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb
new file mode 100644
index 0000000..db01f31
--- /dev/null
+++ b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb
@@ -0,0 +1,11 @@
+require dspdce-fw.inc
+
+LIC_FILES_CHKSUM = "file://DSPDCE-${PV}-Manifest.doc;md5=b8feda5a3ed8197d05993c0d0ff5590e"
+
+PR = "r0"
+
+SRC_URI = " http://downloads.ti.com/dsps/dsps_public_sw/glsdk/dspdce/1_00_00_04/exports/dspdce-${MACHINE}-1.00.00.04.tar.gz;protocol=ftp"
+
+SRC_URI[md5sum] = "72722b12e90c26a85f7f1b56d749cad0"
+SRC_URI[sha256sum] = "64057db41dbee5a992db88129a9154f27c67cfbba8efdc0f09b7de38df4d58eb"
+
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [for master] dspdce-fw: Updated dspdce firmware for latest IPC version
2014-09-24 11:43 ` [for master] dspdce-fw: Updated dspdce firmware for latest IPC version Karthik Ramanan
@ 2014-09-30 21:15 ` Denys Dmytriyenko
2014-10-01 5:44 ` [PATCH v2] " Karthik Ramanan
1 sibling, 0 replies; 6+ messages in thread
From: Denys Dmytriyenko @ 2014-09-30 21:15 UTC (permalink / raw)
To: Karthik Ramanan; +Cc: meta-ti
On Wed, Sep 24, 2014 at 05:13:29PM +0530, Karthik Ramanan wrote:
> Also refactored the dspdce-fw recipes to have inc file
> for common parts
Why do you need 2 versions? Can you just upgrade from 1.00.00.02 to
1.00.00.04?
> Signed-off-by: Karthik Ramanan <a0393906@ti.com>
> ---
> recipes-bsp/dspdce-fw/dspdce-fw.inc | 18 ++++++++++++++++++
> recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb | 19 +++----------------
> recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb | 11 +++++++++++
> 3 files changed, 32 insertions(+), 16 deletions(-)
> create mode 100644 recipes-bsp/dspdce-fw/dspdce-fw.inc
> create mode 100644 recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb
>
> diff --git a/recipes-bsp/dspdce-fw/dspdce-fw.inc b/recipes-bsp/dspdce-fw/dspdce-fw.inc
> new file mode 100644
> index 0000000..9676888
> --- /dev/null
> +++ b/recipes-bsp/dspdce-fw/dspdce-fw.inc
> @@ -0,0 +1,18 @@
> +DESCRIPTION = "Firmware for DSP for an example application called copycodectest"
> +LICENSE = "TI-TSPA"
> +
> +COMPATIBLE_MACHINE = "dra7xx-evm"
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +S = "${WORKDIR}/dspdce-${MACHINE}-${PV}"
> +
> +TARGET = "dra7-dsp1-fw.xe66"
> +
> +do_install() {
> + mkdir -p ${D}${base_libdir}/firmware
> + cp ${S}/firmware/${TARGET} ${D}${base_libdir}/firmware/${TARGET}
> +}
> +
> +FILES_${PN} += "${base_libdir}/firmware/${TARGET}"
> +
> +INSANE_SKIP_${PN} = "arch"
> diff --git a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb
> index 69e9814..bfc3e1f 100644
> --- a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb
> +++ b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb
> @@ -1,24 +1,11 @@
> -DESCRIPTION = "Firmware for DSP "
> -LICENSE = "TI-TSPA"
> +require dspdce-fw.inc
> +
> LIC_FILES_CHKSUM = "file://DSPDCE-${PV}-Manifest.doc;md5=587a7b9fdd99f98fbe99af4a4ba3362a"
>
> -COMPATIBLE_MACHINE = "dra7xx-evm"
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> +PR = "r1"
>
> SRC_URI = "http://downloads.ti.com/dsps/dsps_public_sw/glsdk/dspdce/1_00_00_02/exports/dspdce-${MACHINE}-1.00.00.02.tar.gz;protocol=http"
>
> -S = "${WORKDIR}/dspdce-${MACHINE}-${PV}"
> -
> SRC_URI[md5sum] = "df19baf16f828b5d32b4eed50f0364f5"
> SRC_URI[sha256sum] = "0c0f34674110d1ef0300b61b572a326daffb95a31cc9d45888b2e50a83c6f555"
>
> -TARGET = "dra7-dsp1-fw.xe66"
> -
> -do_install() {
> - mkdir -p ${D}${base_libdir}/firmware
> - cp ${S}/firmware/${TARGET} ${D}${base_libdir}/firmware/${TARGET}
> -}
> -
> -FILES_${PN} += "${base_libdir}/firmware/${TARGET}"
> -
> -INSANE_SKIP_${PN} = "arch"
> diff --git a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb
> new file mode 100644
> index 0000000..db01f31
> --- /dev/null
> +++ b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb
> @@ -0,0 +1,11 @@
> +require dspdce-fw.inc
> +
> +LIC_FILES_CHKSUM = "file://DSPDCE-${PV}-Manifest.doc;md5=b8feda5a3ed8197d05993c0d0ff5590e"
> +
> +PR = "r0"
> +
> +SRC_URI = " http://downloads.ti.com/dsps/dsps_public_sw/glsdk/dspdce/1_00_00_04/exports/dspdce-${MACHINE}-1.00.00.04.tar.gz;protocol=ftp"
> +
> +SRC_URI[md5sum] = "72722b12e90c26a85f7f1b56d749cad0"
> +SRC_URI[sha256sum] = "64057db41dbee5a992db88129a9154f27c67cfbba8efdc0f09b7de38df4d58eb"
> +
> --
> 1.7.9.5
>
> --
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] dspdce-fw: Updated dspdce firmware for latest IPC version
2014-09-24 11:43 ` [for master] dspdce-fw: Updated dspdce firmware for latest IPC version Karthik Ramanan
2014-09-30 21:15 ` Denys Dmytriyenko
@ 2014-10-01 5:44 ` Karthik Ramanan
2014-10-07 19:16 ` Denys Dmytriyenko
1 sibling, 1 reply; 6+ messages in thread
From: Karthik Ramanan @ 2014-10-01 5:44 UTC (permalink / raw)
To: meta-ti
Also refactored the dspdce-fw recipes to have inc file
for common parts
Signed-off-by: Karthik Ramanan <a0393906@ti.com>
---
recipes-bsp/dspdce-fw/dspdce-fw.inc | 18 ++++++++++++++++++
recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb | 24 ------------------------
recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb | 11 +++++++++++
3 files changed, 29 insertions(+), 24 deletions(-)
create mode 100644 recipes-bsp/dspdce-fw/dspdce-fw.inc
delete mode 100644 recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb
create mode 100644 recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb
diff --git a/recipes-bsp/dspdce-fw/dspdce-fw.inc b/recipes-bsp/dspdce-fw/dspdce-fw.inc
new file mode 100644
index 0000000..9676888
--- /dev/null
+++ b/recipes-bsp/dspdce-fw/dspdce-fw.inc
@@ -0,0 +1,18 @@
+DESCRIPTION = "Firmware for DSP for an example application called copycodectest"
+LICENSE = "TI-TSPA"
+
+COMPATIBLE_MACHINE = "dra7xx-evm"
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+S = "${WORKDIR}/dspdce-${MACHINE}-${PV}"
+
+TARGET = "dra7-dsp1-fw.xe66"
+
+do_install() {
+ mkdir -p ${D}${base_libdir}/firmware
+ cp ${S}/firmware/${TARGET} ${D}${base_libdir}/firmware/${TARGET}
+}
+
+FILES_${PN} += "${base_libdir}/firmware/${TARGET}"
+
+INSANE_SKIP_${PN} = "arch"
diff --git a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb
deleted file mode 100644
index 69e9814..0000000
--- a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb
+++ /dev/null
@@ -1,24 +0,0 @@
-DESCRIPTION = "Firmware for DSP "
-LICENSE = "TI-TSPA"
-LIC_FILES_CHKSUM = "file://DSPDCE-${PV}-Manifest.doc;md5=587a7b9fdd99f98fbe99af4a4ba3362a"
-
-COMPATIBLE_MACHINE = "dra7xx-evm"
-PACKAGE_ARCH = "${MACHINE_ARCH}"
-
-SRC_URI = "http://downloads.ti.com/dsps/dsps_public_sw/glsdk/dspdce/1_00_00_02/exports/dspdce-${MACHINE}-1.00.00.02.tar.gz;protocol=http"
-
-S = "${WORKDIR}/dspdce-${MACHINE}-${PV}"
-
-SRC_URI[md5sum] = "df19baf16f828b5d32b4eed50f0364f5"
-SRC_URI[sha256sum] = "0c0f34674110d1ef0300b61b572a326daffb95a31cc9d45888b2e50a83c6f555"
-
-TARGET = "dra7-dsp1-fw.xe66"
-
-do_install() {
- mkdir -p ${D}${base_libdir}/firmware
- cp ${S}/firmware/${TARGET} ${D}${base_libdir}/firmware/${TARGET}
-}
-
-FILES_${PN} += "${base_libdir}/firmware/${TARGET}"
-
-INSANE_SKIP_${PN} = "arch"
diff --git a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb
new file mode 100644
index 0000000..db01f31
--- /dev/null
+++ b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb
@@ -0,0 +1,11 @@
+require dspdce-fw.inc
+
+LIC_FILES_CHKSUM = "file://DSPDCE-${PV}-Manifest.doc;md5=b8feda5a3ed8197d05993c0d0ff5590e"
+
+PR = "r0"
+
+SRC_URI = " http://downloads.ti.com/dsps/dsps_public_sw/glsdk/dspdce/1_00_00_04/exports/dspdce-${MACHINE}-1.00.00.04.tar.gz;protocol=ftp"
+
+SRC_URI[md5sum] = "72722b12e90c26a85f7f1b56d749cad0"
+SRC_URI[sha256sum] = "64057db41dbee5a992db88129a9154f27c67cfbba8efdc0f09b7de38df4d58eb"
+
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] dspdce-fw: Updated dspdce firmware for latest IPC version
2014-10-01 5:44 ` [PATCH v2] " Karthik Ramanan
@ 2014-10-07 19:16 ` Denys Dmytriyenko
2014-10-27 8:41 ` Karthik Ramanan
0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2014-10-07 19:16 UTC (permalink / raw)
To: Karthik Ramanan; +Cc: meta-ti
Karthik,
I'm at lost here. You did address my previous comment of not leaving 2
versions, just updating from .02 to .04, but I don't understand why do you
need an .inc file for, if there's only one version left?
I traced it a bit back and there was a recommendation from Franklin about
creating .inc file for a different recipe for ipumm-fw, but in that case it is
warranted due to the fact that you pull 2 different sources for 2 platforms.
So, in that case it might be better having 2 separate recipes for different
machines with common parts in the .inc file, but see for yourself if that
produces cleaner and simpler results. It's not alwats clear cut and you may
need to experiment to choose the right option...
Either way, dspdce-fw doesn't seem to need an .inc file.
--
Denys
On Wed, Oct 01, 2014 at 11:14:51AM +0530, Karthik Ramanan wrote:
> Also refactored the dspdce-fw recipes to have inc file
> for common parts
>
> Signed-off-by: Karthik Ramanan <a0393906@ti.com>
> ---
> recipes-bsp/dspdce-fw/dspdce-fw.inc | 18 ++++++++++++++++++
> recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb | 24 ------------------------
> recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb | 11 +++++++++++
> 3 files changed, 29 insertions(+), 24 deletions(-)
> create mode 100644 recipes-bsp/dspdce-fw/dspdce-fw.inc
> delete mode 100644 recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb
> create mode 100644 recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb
>
> diff --git a/recipes-bsp/dspdce-fw/dspdce-fw.inc b/recipes-bsp/dspdce-fw/dspdce-fw.inc
> new file mode 100644
> index 0000000..9676888
> --- /dev/null
> +++ b/recipes-bsp/dspdce-fw/dspdce-fw.inc
> @@ -0,0 +1,18 @@
> +DESCRIPTION = "Firmware for DSP for an example application called copycodectest"
> +LICENSE = "TI-TSPA"
> +
> +COMPATIBLE_MACHINE = "dra7xx-evm"
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +S = "${WORKDIR}/dspdce-${MACHINE}-${PV}"
> +
> +TARGET = "dra7-dsp1-fw.xe66"
> +
> +do_install() {
> + mkdir -p ${D}${base_libdir}/firmware
> + cp ${S}/firmware/${TARGET} ${D}${base_libdir}/firmware/${TARGET}
> +}
> +
> +FILES_${PN} += "${base_libdir}/firmware/${TARGET}"
> +
> +INSANE_SKIP_${PN} = "arch"
> diff --git a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb
> deleted file mode 100644
> index 69e9814..0000000
> --- a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -DESCRIPTION = "Firmware for DSP "
> -LICENSE = "TI-TSPA"
> -LIC_FILES_CHKSUM = "file://DSPDCE-${PV}-Manifest.doc;md5=587a7b9fdd99f98fbe99af4a4ba3362a"
> -
> -COMPATIBLE_MACHINE = "dra7xx-evm"
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> -
> -SRC_URI = "http://downloads.ti.com/dsps/dsps_public_sw/glsdk/dspdce/1_00_00_02/exports/dspdce-${MACHINE}-1.00.00.02.tar.gz;protocol=http"
> -
> -S = "${WORKDIR}/dspdce-${MACHINE}-${PV}"
> -
> -SRC_URI[md5sum] = "df19baf16f828b5d32b4eed50f0364f5"
> -SRC_URI[sha256sum] = "0c0f34674110d1ef0300b61b572a326daffb95a31cc9d45888b2e50a83c6f555"
> -
> -TARGET = "dra7-dsp1-fw.xe66"
> -
> -do_install() {
> - mkdir -p ${D}${base_libdir}/firmware
> - cp ${S}/firmware/${TARGET} ${D}${base_libdir}/firmware/${TARGET}
> -}
> -
> -FILES_${PN} += "${base_libdir}/firmware/${TARGET}"
> -
> -INSANE_SKIP_${PN} = "arch"
> diff --git a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb
> new file mode 100644
> index 0000000..db01f31
> --- /dev/null
> +++ b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb
> @@ -0,0 +1,11 @@
> +require dspdce-fw.inc
> +
> +LIC_FILES_CHKSUM = "file://DSPDCE-${PV}-Manifest.doc;md5=b8feda5a3ed8197d05993c0d0ff5590e"
> +
> +PR = "r0"
> +
> +SRC_URI = " http://downloads.ti.com/dsps/dsps_public_sw/glsdk/dspdce/1_00_00_04/exports/dspdce-${MACHINE}-1.00.00.04.tar.gz;protocol=ftp"
> +
> +SRC_URI[md5sum] = "72722b12e90c26a85f7f1b56d749cad0"
> +SRC_URI[sha256sum] = "64057db41dbee5a992db88129a9154f27c67cfbba8efdc0f09b7de38df4d58eb"
> +
> --
> 1.7.9.5
>
> --
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] dspdce-fw: Updated dspdce firmware for latest IPC version
2014-10-07 19:16 ` Denys Dmytriyenko
@ 2014-10-27 8:41 ` Karthik Ramanan
0 siblings, 0 replies; 6+ messages in thread
From: Karthik Ramanan @ 2014-10-27 8:41 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: meta-ti
On 08-Oct-14 12:46 AM, Denys Dmytriyenko wrote:
> Karthik,
>
> I'm at lost here. You did address my previous comment of not leaving 2
> versions, just updating from .02 to .04, but I don't understand why do you
> need an .inc file for, if there's only one version left?
>
> I traced it a bit back and there was a recommendation from Franklin about
> creating .inc file for a different recipe for ipumm-fw, but in that case it is
> warranted due to the fact that you pull 2 different sources for 2 platforms.
> So, in that case it might be better having 2 separate recipes for different
> machines with common parts in the .inc file, but see for yourself if that
> produces cleaner and simpler results. It's not alwats clear cut and you may
> need to experiment to choose the right option...
>
> Either way, dspdce-fw doesn't seem to need an .inc file.
>
Denys,
There is a case where there may be multiple dspdce firmware versions
based on different versions of IPC. It will make sense that we introduce
the inc file when there is a need.
I will abandon this patch and resubmit a v3 for this.
Regards
Karthik
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-27 8:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-24 11:43 [for master] dspdce-fw: Updated dspdce-fw binaries Karthik Ramanan
2014-09-24 11:43 ` [for master] dspdce-fw: Updated dspdce firmware for latest IPC version Karthik Ramanan
2014-09-30 21:15 ` Denys Dmytriyenko
2014-10-01 5:44 ` [PATCH v2] " Karthik Ramanan
2014-10-07 19:16 ` Denys Dmytriyenko
2014-10-27 8:41 ` Karthik Ramanan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.