* [PATCH] KVM: trivial fix comment regarding __kvm_set_memory_region
@ 2014-10-27 15:22 Dominik Dingel
2014-10-27 15:51 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Dingel @ 2014-10-27 15:22 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Gleb Natapov, kvm, linux-kernel, Dominik Dingel
commit 72dc67a69690 ("KVM: remove the usage of the mmap_sem for the protection of the memory slots.")
changed the lock which will be taken. This should be reflected in the function
commentary.
Signed-off-by: Dominik Dingel <dingel@linux.vnet.ibm.com>
---
virt/kvm/kvm_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index d82ec25..8b13607 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -738,7 +738,7 @@ static struct kvm_memslots *install_new_memslots(struct kvm *kvm,
*
* Discontiguous memory is allowed, mostly for framebuffers.
*
- * Must be called holding mmap_sem for write.
+ * Must be called holding kvm->slots_lock for write.
*/
int __kvm_set_memory_region(struct kvm *kvm,
struct kvm_userspace_memory_region *mem)
--
1.8.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: trivial fix comment regarding __kvm_set_memory_region
2014-10-27 15:22 [PATCH] KVM: trivial fix comment regarding __kvm_set_memory_region Dominik Dingel
@ 2014-10-27 15:51 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2014-10-27 15:51 UTC (permalink / raw)
To: Dominik Dingel; +Cc: Gleb Natapov, kvm, linux-kernel
On 10/27/2014 04:22 PM, Dominik Dingel wrote:
> commit 72dc67a69690 ("KVM: remove the usage of the mmap_sem for the protection of the memory slots.")
> changed the lock which will be taken. This should be reflected in the function
> commentary.
Whoa, February 2008. :)
Thanks, applying this patch.
Paolo
> Signed-off-by: Dominik Dingel <dingel@linux.vnet.ibm.com>
> ---
> virt/kvm/kvm_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index d82ec25..8b13607 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -738,7 +738,7 @@ static struct kvm_memslots *install_new_memslots(struct kvm *kvm,
> *
> * Discontiguous memory is allowed, mostly for framebuffers.
> *
> - * Must be called holding mmap_sem for write.
> + * Must be called holding kvm->slots_lock for write.
> */
> int __kvm_set_memory_region(struct kvm *kvm,
> struct kvm_userspace_memory_region *mem)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-27 15:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-27 15:22 [PATCH] KVM: trivial fix comment regarding __kvm_set_memory_region Dominik Dingel
2014-10-27 15:51 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.