All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Michal Nazarewicz <mina86@mina86.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Minchan Kim <minchan@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: CMA: test_pages_isolated failures in alloc_contig_range
Date: Tue, 28 Oct 2014 13:48:26 +0000	[thread overview]
Message-ID: <544F9EAA.5010404@hurleysoftware.com> (raw)
In-Reply-To: <xa1tsii8l683.fsf@mina86.com>

[ +cc Andrew Morton ]

On 10/28/2014 08:38 AM, Michal Nazarewicz wrote:
> On Sun, Oct 26 2014, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
>> Hello,
>>
>> I've run into a CMA-related issue while testing a DMA engine driver with 
>> dmatest on a Renesas R-Car ARM platform. 
>>
>> When allocating contiguous memory through CMA the kernel prints the following 
>> messages to the kernel log.
>>
>> [   99.770000] alloc_contig_range test_pages_isolated(6b843, 6b844) failed
>> [  124.220000] alloc_contig_range test_pages_isolated(6b843, 6b844) failed
>> [  127.550000] alloc_contig_range test_pages_isolated(6b845, 6b846) failed
>> [  132.850000] alloc_contig_range test_pages_isolated(6b845, 6b846) failed
>> [  151.390000] alloc_contig_range test_pages_isolated(6b843, 6b844) failed
>> [  166.490000] alloc_contig_range test_pages_isolated(6b843, 6b844) failed
>> [  181.450000] alloc_contig_range test_pages_isolated(6b845, 6b846) failed
>>
>> I've stripped the dmatest module down as much as possible to remove any 
>> hardware dependencies and came up with the following implementation.
> 
> Like Laura wrote, the message is not (should not be) a problem in
> itself:

[...]

> So as you can see cma_alloc will try another part of the cma region if
> test_pages_isolated fails.
> 
> Obviously, if CMA region is fragmented or there's enough space for only
> one allocation of required size isolation failures will cause allocation
> failures, so it's best to avoid them, but they are not always avoidable.
> 
> To debug you would probably want to add more debug information about the
> page (i.e. data from struct page) that failed isolation after the
> pr_warn in alloc_contig_range.

If the message does not indicate an actual problem, then its printk level is
too high. These messages have been reported when using 3.16+ distro kernels.

Regards,
Peter Hurley

WARNING: multiple messages have this Message-ID (diff)
From: Peter Hurley <peter@hurleysoftware.com>
To: Michal Nazarewicz <mina86@mina86.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Minchan Kim <minchan@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: CMA: test_pages_isolated failures in alloc_contig_range
Date: Tue, 28 Oct 2014 09:48:26 -0400	[thread overview]
Message-ID: <544F9EAA.5010404@hurleysoftware.com> (raw)
In-Reply-To: <xa1tsii8l683.fsf@mina86.com>

[ +cc Andrew Morton ]

On 10/28/2014 08:38 AM, Michal Nazarewicz wrote:
> On Sun, Oct 26 2014, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
>> Hello,
>>
>> I've run into a CMA-related issue while testing a DMA engine driver with 
>> dmatest on a Renesas R-Car ARM platform. 
>>
>> When allocating contiguous memory through CMA the kernel prints the following 
>> messages to the kernel log.
>>
>> [   99.770000] alloc_contig_range test_pages_isolated(6b843, 6b844) failed
>> [  124.220000] alloc_contig_range test_pages_isolated(6b843, 6b844) failed
>> [  127.550000] alloc_contig_range test_pages_isolated(6b845, 6b846) failed
>> [  132.850000] alloc_contig_range test_pages_isolated(6b845, 6b846) failed
>> [  151.390000] alloc_contig_range test_pages_isolated(6b843, 6b844) failed
>> [  166.490000] alloc_contig_range test_pages_isolated(6b843, 6b844) failed
>> [  181.450000] alloc_contig_range test_pages_isolated(6b845, 6b846) failed
>>
>> I've stripped the dmatest module down as much as possible to remove any 
>> hardware dependencies and came up with the following implementation.
> 
> Like Laura wrote, the message is not (should not be) a problem in
> itself:

[...]

> So as you can see cma_alloc will try another part of the cma region if
> test_pages_isolated fails.
> 
> Obviously, if CMA region is fragmented or there's enough space for only
> one allocation of required size isolation failures will cause allocation
> failures, so it's best to avoid them, but they are not always avoidable.
> 
> To debug you would probably want to add more debug information about the
> page (i.e. data from struct page) that failed isolation after the
> pr_warn in alloc_contig_range.

If the message does not indicate an actual problem, then its printk level is
too high. These messages have been reported when using 3.16+ distro kernels.

Regards,
Peter Hurley

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Peter Hurley <peter@hurleysoftware.com>
To: Michal Nazarewicz <mina86@mina86.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Minchan Kim <minchan@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: CMA: test_pages_isolated failures in alloc_contig_range
Date: Tue, 28 Oct 2014 09:48:26 -0400	[thread overview]
Message-ID: <544F9EAA.5010404@hurleysoftware.com> (raw)
In-Reply-To: <xa1tsii8l683.fsf@mina86.com>

[ +cc Andrew Morton ]

On 10/28/2014 08:38 AM, Michal Nazarewicz wrote:
> On Sun, Oct 26 2014, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
>> Hello,
>>
>> I've run into a CMA-related issue while testing a DMA engine driver with 
>> dmatest on a Renesas R-Car ARM platform. 
>>
>> When allocating contiguous memory through CMA the kernel prints the following 
>> messages to the kernel log.
>>
>> [   99.770000] alloc_contig_range test_pages_isolated(6b843, 6b844) failed
>> [  124.220000] alloc_contig_range test_pages_isolated(6b843, 6b844) failed
>> [  127.550000] alloc_contig_range test_pages_isolated(6b845, 6b846) failed
>> [  132.850000] alloc_contig_range test_pages_isolated(6b845, 6b846) failed
>> [  151.390000] alloc_contig_range test_pages_isolated(6b843, 6b844) failed
>> [  166.490000] alloc_contig_range test_pages_isolated(6b843, 6b844) failed
>> [  181.450000] alloc_contig_range test_pages_isolated(6b845, 6b846) failed
>>
>> I've stripped the dmatest module down as much as possible to remove any 
>> hardware dependencies and came up with the following implementation.
> 
> Like Laura wrote, the message is not (should not be) a problem in
> itself:

[...]

> So as you can see cma_alloc will try another part of the cma region if
> test_pages_isolated fails.
> 
> Obviously, if CMA region is fragmented or there's enough space for only
> one allocation of required size isolation failures will cause allocation
> failures, so it's best to avoid them, but they are not always avoidable.
> 
> To debug you would probably want to add more debug information about the
> page (i.e. data from struct page) that failed isolation after the
> pr_warn in alloc_contig_range.

If the message does not indicate an actual problem, then its printk level is
too high. These messages have been reported when using 3.16+ distro kernels.

Regards,
Peter Hurley

  reply	other threads:[~2014-10-28 13:48 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-26 21:09 CMA: test_pages_isolated failures in alloc_contig_range Laurent Pinchart
2014-10-26 21:09 ` Laurent Pinchart
2014-10-26 21:09 ` Laurent Pinchart
2014-10-27 20:38 ` Laura Abbott
2014-10-27 20:38   ` Laura Abbott
2014-10-27 20:38   ` Laura Abbott
2014-10-28 15:12   ` Laurent Pinchart
2014-10-28 15:12     ` Laurent Pinchart
2014-10-28 15:12     ` Laurent Pinchart
2014-10-28 12:38 ` Michal Nazarewicz
2014-10-28 12:38   ` Michal Nazarewicz
2014-10-28 12:38   ` Michal Nazarewicz
2014-10-28 13:48   ` Peter Hurley [this message]
2014-10-28 13:48     ` Peter Hurley
2014-10-28 13:48     ` Peter Hurley
2014-10-28 16:57     ` Michal Nazarewicz
2014-10-28 16:57       ` Michal Nazarewicz
2014-10-28 16:57       ` Michal Nazarewicz
2014-11-04  3:38       ` Peter Hurley
2014-11-04  3:38         ` Peter Hurley
2014-11-04  3:38         ` Peter Hurley
2014-10-28 18:59     ` Laurent Pinchart
2014-10-28 18:59       ` Laurent Pinchart
2014-10-28 18:59       ` Laurent Pinchart
2014-11-03 16:57 ` [PATCH] mm: alloc_contig_range: demote pages busy message from warn to info Michal Nazarewicz
2014-11-03 16:57   ` Michal Nazarewicz
2014-11-04  5:43   ` Minchan Kim
2014-11-04  5:43     ` Minchan Kim
2014-11-04 12:22     ` Peter Hurley
2014-11-04 12:22       ` Peter Hurley
2014-11-04 13:35       ` Michal Nazarewicz
2014-11-04 13:35         ` Michal Nazarewicz
2014-11-04 14:19         ` Peter Hurley
2014-11-04 14:19           ` Peter Hurley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=544F9EAA.5010404@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=akpm@linux-foundation.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=mina86@mina86.com \
    --cc=minchan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.