From: Peter Hurley <peter@hurleysoftware.com>
To: Michal Nazarewicz <mina86@mina86.com>,
Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: alloc_contig_range: demote pages busy message from warn to info
Date: Tue, 04 Nov 2014 09:19:48 -0500 [thread overview]
Message-ID: <5458E084.2060208@hurleysoftware.com> (raw)
In-Reply-To: <xa1tvbmv6qco.fsf@mina86.com>
On 11/04/2014 08:35 AM, Michal Nazarewicz wrote:
> On Tue, Nov 04 2014, Peter Hurley <peter@hurleysoftware.com> wrote:
>> On 11/04/2014 12:43 AM, Minchan Kim wrote:
>>> Hello,
>>>
>>> On Mon, Nov 03, 2014 at 05:57:53PM +0100, Michal Nazarewicz wrote:
>>>> Having test_pages_isolated failure message as a warning confuses
>>>> users into thinking that it is more serious than it really is. In
>>>> reality, if called via CMA, allocation will be retried so a single
>>>> test_pages_isolated failure does not prevent allocation from
>>>> succeeding.
>>>>
>>>> Demote the warning message to an info message and reformat it such
>>>> that the text a??faileda?? does not appear and instead a less worrying
>>>> a??PFNS busya?? is used.
>>>
>>> What do you expect from this message? Please describe it so that we can
>>> review below message helps your goal.
>>
>> I expect this message to not show up in logs unless there is a real problem.
>
> So frankly I don't care. Feel free to send a patch removing the message
> all together. I'll be happy to ack it.
I'd rather just remove CMA allocation from the iommu providers on x86.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Peter Hurley <peter@hurleysoftware.com>
To: Michal Nazarewicz <mina86@mina86.com>,
Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: alloc_contig_range: demote pages busy message from warn to info
Date: Tue, 04 Nov 2014 09:19:48 -0500 [thread overview]
Message-ID: <5458E084.2060208@hurleysoftware.com> (raw)
In-Reply-To: <xa1tvbmv6qco.fsf@mina86.com>
On 11/04/2014 08:35 AM, Michal Nazarewicz wrote:
> On Tue, Nov 04 2014, Peter Hurley <peter@hurleysoftware.com> wrote:
>> On 11/04/2014 12:43 AM, Minchan Kim wrote:
>>> Hello,
>>>
>>> On Mon, Nov 03, 2014 at 05:57:53PM +0100, Michal Nazarewicz wrote:
>>>> Having test_pages_isolated failure message as a warning confuses
>>>> users into thinking that it is more serious than it really is. In
>>>> reality, if called via CMA, allocation will be retried so a single
>>>> test_pages_isolated failure does not prevent allocation from
>>>> succeeding.
>>>>
>>>> Demote the warning message to an info message and reformat it such
>>>> that the text “failed” does not appear and instead a less worrying
>>>> “PFNS busy” is used.
>>>
>>> What do you expect from this message? Please describe it so that we can
>>> review below message helps your goal.
>>
>> I expect this message to not show up in logs unless there is a real problem.
>
> So frankly I don't care. Feel free to send a patch removing the message
> all together. I'll be happy to ack it.
I'd rather just remove CMA allocation from the iommu providers on x86.
next prev parent reply other threads:[~2014-11-04 14:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 21:09 CMA: test_pages_isolated failures in alloc_contig_range Laurent Pinchart
2014-10-26 21:09 ` Laurent Pinchart
2014-10-26 21:09 ` Laurent Pinchart
2014-10-27 20:38 ` Laura Abbott
2014-10-27 20:38 ` Laura Abbott
2014-10-27 20:38 ` Laura Abbott
2014-10-28 15:12 ` Laurent Pinchart
2014-10-28 15:12 ` Laurent Pinchart
2014-10-28 15:12 ` Laurent Pinchart
2014-10-28 12:38 ` Michal Nazarewicz
2014-10-28 12:38 ` Michal Nazarewicz
2014-10-28 12:38 ` Michal Nazarewicz
2014-10-28 13:48 ` Peter Hurley
2014-10-28 13:48 ` Peter Hurley
2014-10-28 13:48 ` Peter Hurley
2014-10-28 16:57 ` Michal Nazarewicz
2014-10-28 16:57 ` Michal Nazarewicz
2014-10-28 16:57 ` Michal Nazarewicz
2014-11-04 3:38 ` Peter Hurley
2014-11-04 3:38 ` Peter Hurley
2014-11-04 3:38 ` Peter Hurley
2014-10-28 18:59 ` Laurent Pinchart
2014-10-28 18:59 ` Laurent Pinchart
2014-10-28 18:59 ` Laurent Pinchart
2014-11-03 16:57 ` [PATCH] mm: alloc_contig_range: demote pages busy message from warn to info Michal Nazarewicz
2014-11-03 16:57 ` Michal Nazarewicz
2014-11-04 5:43 ` Minchan Kim
2014-11-04 5:43 ` Minchan Kim
2014-11-04 12:22 ` Peter Hurley
2014-11-04 12:22 ` Peter Hurley
2014-11-04 13:35 ` Michal Nazarewicz
2014-11-04 13:35 ` Michal Nazarewicz
2014-11-04 14:19 ` Peter Hurley [this message]
2014-11-04 14:19 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5458E084.2060208@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=akpm@linux-foundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.