From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [v2 PATCH 10/12] arm, spl, at91: add at91sam9260 and at91sam9g45 spl support
Date: Thu, 30 Oct 2014 12:41:16 +0100 [thread overview]
Message-ID: <545223DC.60502@denx.de> (raw)
In-Reply-To: <54521028.30109@atmel.com>
Hello Bo,
Am 30.10.2014 11:17, schrieb Bo Shen:
> Hi Heiko,
>
> On 10/30/2014 04:15 PM, Heiko Schocher wrote:
>> diff --git a/arch/arm/include/asm/arch-at91/at91_pmc.h b/arch/arm/include/asm/arch-at91/at91_pmc.h
>> index 27331ff..5f64583 100644
>> --- a/arch/arm/include/asm/arch-at91/at91_pmc.h
>> +++ b/arch/arm/include/asm/arch-at91/at91_pmc.h
>> @@ -95,7 +95,7 @@ typedef struct at91_pmc {
>> #define AT91_PMC_MCKR_CSS_MAIN 0x00000001
>> #define AT91_PMC_MCKR_CSS_PLLA 0x00000002
>> #define AT91_PMC_MCKR_CSS_PLLB 0x00000003
>> -#define AT91_PMC_MCKR_CSS_MASK 0x00000003
>> +#define AT91_PMC_MCKR_CSS_MASK 0x00000007
>
> Where this come from, CSS only two bits.
Good question ... looked again into the doc, it is only two bits.
>
>> #ifdef CONFIG_SAMA5D3
>> #define AT91_PMC_MCKR_PRES_1 0x00000000
>> @@ -114,7 +114,7 @@ typedef struct at91_pmc {
>> #define AT91_PMC_MCKR_PRES_16 0x00000010
>> #define AT91_PMC_MCKR_PRES_32 0x00000014
>> #define AT91_PMC_MCKR_PRES_64 0x00000018
>> -#define AT91_PMC_MCKR_PRES_MASK 0x0000001C
>> +#define AT91_PMC_MCKR_PRES_MASK 0x0000003C
>
> Ditto
Hmm... no idea, why I changed this ... good catch!
Is the rest of the patch (and the patchserie OK) ?
Then I can send a v3 ...
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2014-10-30 11:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 8:14 [U-Boot] [v2 PATCH 0/12] arm, at91, spl: add spl support for the taurus and corvus boards Heiko Schocher
2014-10-30 8:14 ` [U-Boot] [v2 PATCH 01/12] spi, atmel: move CONFIG_SYS_SPI_WRITE_TOUT into common header Heiko Schocher
2014-10-30 8:14 ` [U-Boot] [v2 PATCH 02/12] arm, at91: add spi dataflash support for the taurus board Heiko Schocher
2014-10-30 8:14 ` [U-Boot] [v2 PATCH 03/12] arm, at91, mpddrc: fix typo in ddr2_init() Heiko Schocher
2014-10-31 1:55 ` Bo Shen
2014-10-31 5:33 ` Heiko Schocher
2014-10-30 8:14 ` [U-Boot] [v2 PATCH 04/12] arm, at91: compile mpddrc ram init code also for AT91SAM9M10G45 Heiko Schocher
2014-10-30 8:14 ` [U-Boot] [v2 PATCH 05/12] arm, at91: add missing ddr2 cr register MPDDRC_CR_EBISHARE define Heiko Schocher
2014-10-30 8:15 ` [U-Boot] [v2 PATCH 06/12] spl, nand: add option to boot raw u-boot.bin image only Heiko Schocher
2014-10-30 8:15 ` [U-Boot] [v2 PATCH 07/12] mtd: atmel_nand: add missign include Heiko Schocher
2014-10-30 8:15 ` [U-Boot] [v2 PATCH 08/12] spl, nand, atmel_nand: add erase one block function Heiko Schocher
2014-10-30 23:16 ` Scott Wood
2014-10-30 8:15 ` [U-Boot] [v2 PATCH 09/12] spl, mtd, nand, atmel_nand: invert device ready pin logic Heiko Schocher
2014-10-30 23:18 ` Scott Wood
2014-10-30 8:15 ` [U-Boot] [v2 PATCH 10/12] arm, spl, at91: add at91sam9260 and at91sam9g45 spl support Heiko Schocher
2014-10-30 10:17 ` Bo Shen
2014-10-30 11:41 ` Heiko Schocher [this message]
2014-10-31 1:55 ` Bo Shen
2014-10-31 1:50 ` Bo Shen
2014-10-31 6:03 ` Heiko Schocher
2014-10-31 6:08 ` Wolfgang Denk
2014-10-30 8:15 ` [U-Boot] [v2 PATCH 11/12] arm, at91, spl: add spl support for the taurus board Heiko Schocher
2014-10-30 8:15 ` [U-Boot] [v2 PATCH 12/12] arm, spl, at91: add spl support for the corvus board Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545223DC.60502@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.