Re: [Qemu-trivial] [Qemu-devel] [PATCH] vdi: wrapped uuid_unparse() in #ifdef

[Stefan Weil <sw@weilnetz.de>]

Am 31.10.2014 um 09:02 schrieb SeokYeon Hwang:
> Wrapped uuid_unparse() in #ifdef to avoid "-Wunused-function" on clang 3.4 or later.
>
> Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
> ---
>   block/vdi.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/block/vdi.c b/block/vdi.c
> index 19701ee..e1d211c 100644
> --- a/block/vdi.c
> +++ b/block/vdi.c
> @@ -137,12 +137,14 @@ static inline int uuid_is_null(const uuid_t uu)
>       return memcmp(uu, null_uuid, sizeof(uuid_t)) == 0;
>   }
>   
> +# if defined(CONFIG_VDI_DEBUG)
>   static inline void uuid_unparse(const uuid_t uu, char *out)
>   {
>       snprintf(out, 37, UUID_FMT,
>               uu[0], uu[1], uu[2], uu[3], uu[4], uu[5], uu[6], uu[7],
>               uu[8], uu[9], uu[10], uu[11], uu[12], uu[13], uu[14], uu[15]);
>   }
> +# endif
>   #endif
>   
>   typedef struct {

This code is only used on build hosts without libuuid development header 
files, so the warning can be avoided by installing that header files. 
Nevertheless, I think it is fine for qemu-trivial.

Reviewed-by: Stefan Weil <sw@weilnetz.de>