From: Paolo Bonzini <pbonzini@redhat.com>
To: SeokYeon Hwang <syeon.hwang@samsung.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, sw@weilnetz.de
Subject: Re: [Qemu-trivial] [PATCH] vdi: wrapped uuid_unparse() in #ifdef
Date: Mon, 03 Nov 2014 17:13:43 +0100 [thread overview]
Message-ID: <5457A9B7.7030908@redhat.com> (raw)
In-Reply-To: <1414742525-18639-1-git-send-email-syeon.hwang@samsung.com>
On 31/10/2014 09:02, SeokYeon Hwang wrote:
> Wrapped uuid_unparse() in #ifdef to avoid "-Wunused-function" on clang 3.4 or later.
>
> Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
> ---
> block/vdi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/block/vdi.c b/block/vdi.c
> index 19701ee..e1d211c 100644
> --- a/block/vdi.c
> +++ b/block/vdi.c
> @@ -137,12 +137,14 @@ static inline int uuid_is_null(const uuid_t uu)
> return memcmp(uu, null_uuid, sizeof(uuid_t)) == 0;
> }
>
> +# if defined(CONFIG_VDI_DEBUG)
> static inline void uuid_unparse(const uuid_t uu, char *out)
> {
> snprintf(out, 37, UUID_FMT,
> uu[0], uu[1], uu[2], uu[3], uu[4], uu[5], uu[6], uu[7],
> uu[8], uu[9], uu[10], uu[11], uu[12], uu[13], uu[14], uu[15]);
> }
> +# endif
> #endif
>
> typedef struct {
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: SeokYeon Hwang <syeon.hwang@samsung.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, sw@weilnetz.de
Subject: Re: [Qemu-devel] [PATCH] vdi: wrapped uuid_unparse() in #ifdef
Date: Mon, 03 Nov 2014 17:13:43 +0100 [thread overview]
Message-ID: <5457A9B7.7030908@redhat.com> (raw)
In-Reply-To: <1414742525-18639-1-git-send-email-syeon.hwang@samsung.com>
On 31/10/2014 09:02, SeokYeon Hwang wrote:
> Wrapped uuid_unparse() in #ifdef to avoid "-Wunused-function" on clang 3.4 or later.
>
> Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
> ---
> block/vdi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/block/vdi.c b/block/vdi.c
> index 19701ee..e1d211c 100644
> --- a/block/vdi.c
> +++ b/block/vdi.c
> @@ -137,12 +137,14 @@ static inline int uuid_is_null(const uuid_t uu)
> return memcmp(uu, null_uuid, sizeof(uuid_t)) == 0;
> }
>
> +# if defined(CONFIG_VDI_DEBUG)
> static inline void uuid_unparse(const uuid_t uu, char *out)
> {
> snprintf(out, 37, UUID_FMT,
> uu[0], uu[1], uu[2], uu[3], uu[4], uu[5], uu[6], uu[7],
> uu[8], uu[9], uu[10], uu[11], uu[12], uu[13], uu[14], uu[15]);
> }
> +# endif
> #endif
>
> typedef struct {
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2014-11-03 16:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 8:02 [Qemu-devel] [PATCH] vdi: wrapped uuid_unparse() in #ifdef SeokYeon Hwang
2014-10-31 18:15 ` [Qemu-trivial] " Stefan Weil
2014-10-31 18:15 ` Stefan Weil
2014-11-02 5:14 ` [Qemu-trivial] " Michael Tokarev
2014-11-02 5:14 ` Michael Tokarev
2014-11-03 16:13 ` Paolo Bonzini [this message]
2014-11-03 16:13 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5457A9B7.7030908@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
--cc=syeon.hwang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.