From: Daniel Borkmann <dborkman@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: matt@ozlabs.org, kda@linux-powerpc.org, linuxppc-dev@ozlabs.org,
netdev@vger.kernel.org, alexei.starovoitov@gmail.com
Subject: Re: [PATCH v2] PPC: bpf_jit_comp: add SKF_AD_PKTTYPE instruction
Date: Sat, 01 Nov 2014 19:31:37 +0100 [thread overview]
Message-ID: <54552709.7000409@redhat.com> (raw)
In-Reply-To: <20141101.140035.13626854970331774.davem@davemloft.net>
On 11/01/2014 07:00 PM, David Miller wrote:
> From: Denis Kirjanov <kda@linux-powerpc.org>
> Date: Sat, 1 Nov 2014 21:49:27 +0400
>
>> David, you need a feedback from other guys to apply this patch, right?
>>
>> Alexei wanted some output before/after the patch.
>> Michael Ellerman wanted the explanation what a BPF_ANC | SKF_AD_PKTTYPE means.
The BPF_ANC | SKF_AD_PKTTYPE case means that this is an ancillary
operation aka BPF extension which loads the value of skb->pkt_type
into the accumulator.
A similar transformation, that is, from BPF into eBPF insns can be
found in convert_bpf_extensions() in the SKF_AD_PKTTYPE case, or
commit 709f6c58d4dc ("sparc: bpf_jit: add SKF_AD_PKTTYPE support
to JIT") that recently enabled the same in sparc.
>> So I'm waiting the ack/nack from them...
>
> I don't really think performance metrics are necessary just for adding
> SKF_AD_PKTTYPE support, that's sort of an over the top requirement
> if you ask me.
Right, lib/test_bpf.c actually brings the quoted output w/ numbers
for free. I think the important point was that the 'After:' case
with ``echo 1 > /proc/sys/net/core/bpf_jit_enable'' runs through for
that test case, which has been shown here.
> It's pretty obvious that we should support as many operations as
> possible to each JIT, because all of program has to do is use that
> unsupported opcode and then we have none of that program being JIT'd.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <dborkman@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: kda@linux-powerpc.org, alexei.starovoitov@gmail.com,
netdev@vger.kernel.org, linuxppc-dev@ozlabs.org,
mpe@ellerman.id.au, matt@ozlabs.org
Subject: Re: [PATCH v2] PPC: bpf_jit_comp: add SKF_AD_PKTTYPE instruction
Date: Sat, 01 Nov 2014 19:31:37 +0100 [thread overview]
Message-ID: <54552709.7000409@redhat.com> (raw)
In-Reply-To: <20141101.140035.13626854970331774.davem@davemloft.net>
On 11/01/2014 07:00 PM, David Miller wrote:
> From: Denis Kirjanov <kda@linux-powerpc.org>
> Date: Sat, 1 Nov 2014 21:49:27 +0400
>
>> David, you need a feedback from other guys to apply this patch, right?
>>
>> Alexei wanted some output before/after the patch.
>> Michael Ellerman wanted the explanation what a BPF_ANC | SKF_AD_PKTTYPE means.
The BPF_ANC | SKF_AD_PKTTYPE case means that this is an ancillary
operation aka BPF extension which loads the value of skb->pkt_type
into the accumulator.
A similar transformation, that is, from BPF into eBPF insns can be
found in convert_bpf_extensions() in the SKF_AD_PKTTYPE case, or
commit 709f6c58d4dc ("sparc: bpf_jit: add SKF_AD_PKTTYPE support
to JIT") that recently enabled the same in sparc.
>> So I'm waiting the ack/nack from them...
>
> I don't really think performance metrics are necessary just for adding
> SKF_AD_PKTTYPE support, that's sort of an over the top requirement
> if you ask me.
Right, lib/test_bpf.c actually brings the quoted output w/ numbers
for free. I think the important point was that the 'After:' case
with ``echo 1 > /proc/sys/net/core/bpf_jit_enable'' runs through for
that test case, which has been shown here.
> It's pretty obvious that we should support as many operations as
> possible to each JIT, because all of program has to do is use that
> unsupported opcode and then we have none of that program being JIT'd.
next prev parent reply other threads:[~2014-11-01 18:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 6:12 [PATCH v2] PPC: bpf_jit_comp: add SKF_AD_PKTTYPE instruction Denis Kirjanov
2014-10-30 6:12 ` Denis Kirjanov
2014-10-30 20:32 ` Alexei Starovoitov
2014-10-30 20:32 ` Alexei Starovoitov
2014-10-31 6:09 ` Denis Kirjanov
2014-10-31 6:09 ` Denis Kirjanov
2014-11-01 16:19 ` Denis Kirjanov
2014-11-01 16:19 ` Denis Kirjanov
2014-11-01 17:39 ` David Miller
2014-11-01 17:39 ` David Miller
2014-11-01 17:49 ` Denis Kirjanov
2014-11-01 17:49 ` Denis Kirjanov
2014-11-01 18:00 ` David Miller
2014-11-01 18:00 ` David Miller
2014-11-01 18:31 ` Daniel Borkmann [this message]
2014-11-01 18:31 ` Daniel Borkmann
2014-11-01 18:40 ` Daniel Borkmann
2014-11-01 18:40 ` Daniel Borkmann
2014-11-03 17:06 ` David Miller
2014-11-03 17:06 ` David Miller
2014-11-03 17:21 ` Alexei Starovoitov
2014-11-03 17:21 ` Alexei Starovoitov
2014-11-03 20:29 ` David Miller
2014-11-03 20:29 ` David Miller
2014-11-03 23:43 ` Michael Ellerman
2014-11-03 23:43 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54552709.7000409@redhat.com \
--to=dborkman@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=kda@linux-powerpc.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=matt@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.