From: Daniel Borkmann <dborkman@redhat.com>
To: Denis Kirjanov <kirjanov@gmail.com>
Cc: Matt Evans <matt@ozlabs.org>,
Denis Kirjanov <kda@linux-powerpc.org>,
linuxppc-dev@ozlabs.org,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [PATCH v2] PPC: bpf_jit_comp: add SKF_AD_PKTTYPE instruction
Date: Sat, 01 Nov 2014 19:40:38 +0100 [thread overview]
Message-ID: <54552926.1020504@redhat.com> (raw)
In-Reply-To: <CAHj3AVkpouHa1y0jt9c5dyYvnd6dctociTMW1ORdxaKdsFEbhQ@mail.gmail.com>
On 10/31/2014 07:09 AM, Denis Kirjanov wrote:
> On 10/30/14, Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
>> On Wed, Oct 29, 2014 at 11:12 PM, Denis Kirjanov <kda@linux-powerpc.org>
>> wrote:
>>> Add BPF extension SKF_AD_PKTTYPE to ppc JIT to load
>>> skb->pkt_type field.
>>>
>>> Before:
>>> [ 88.262622] test_bpf: #11 LD_IND_NET 86 97 99 PASS
>>> [ 88.265740] test_bpf: #12 LD_PKTTYPE 109 107 PASS
>>>
>>> After:
>>> [ 80.605964] test_bpf: #11 LD_IND_NET 44 40 39 PASS
>>> [ 80.607370] test_bpf: #12 LD_PKTTYPE 9 9 PASS
>>
>> if you'd only quoted #12, it would all make sense ;)
>> but #11 test is not using PKTTYPE. So your patch shouldn't
>> make a difference. Are these numbers with JIT on and off?
>
> Right.
Ok.
Please mention this in future log messages, as it was not quite
clear that "before" was actually with JIT off, and "after" was
with JIT on.
One could have read it that actually both cases were with JIT on,
and thus the inconsistent result for LD_IND_NET is a bit confusing
since you've quoted it here as well.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <dborkman@redhat.com>
To: Denis Kirjanov <kirjanov@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Denis Kirjanov <kda@linux-powerpc.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linuxppc-dev@ozlabs.org, Michael Ellerman <mpe@ellerman.id.au>,
Matt Evans <matt@ozlabs.org>
Subject: Re: [PATCH v2] PPC: bpf_jit_comp: add SKF_AD_PKTTYPE instruction
Date: Sat, 01 Nov 2014 19:40:38 +0100 [thread overview]
Message-ID: <54552926.1020504@redhat.com> (raw)
In-Reply-To: <CAHj3AVkpouHa1y0jt9c5dyYvnd6dctociTMW1ORdxaKdsFEbhQ@mail.gmail.com>
On 10/31/2014 07:09 AM, Denis Kirjanov wrote:
> On 10/30/14, Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
>> On Wed, Oct 29, 2014 at 11:12 PM, Denis Kirjanov <kda@linux-powerpc.org>
>> wrote:
>>> Add BPF extension SKF_AD_PKTTYPE to ppc JIT to load
>>> skb->pkt_type field.
>>>
>>> Before:
>>> [ 88.262622] test_bpf: #11 LD_IND_NET 86 97 99 PASS
>>> [ 88.265740] test_bpf: #12 LD_PKTTYPE 109 107 PASS
>>>
>>> After:
>>> [ 80.605964] test_bpf: #11 LD_IND_NET 44 40 39 PASS
>>> [ 80.607370] test_bpf: #12 LD_PKTTYPE 9 9 PASS
>>
>> if you'd only quoted #12, it would all make sense ;)
>> but #11 test is not using PKTTYPE. So your patch shouldn't
>> make a difference. Are these numbers with JIT on and off?
>
> Right.
Ok.
Please mention this in future log messages, as it was not quite
clear that "before" was actually with JIT off, and "after" was
with JIT on.
One could have read it that actually both cases were with JIT on,
and thus the inconsistent result for LD_IND_NET is a bit confusing
since you've quoted it here as well.
next prev parent reply other threads:[~2014-11-01 18:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 6:12 [PATCH v2] PPC: bpf_jit_comp: add SKF_AD_PKTTYPE instruction Denis Kirjanov
2014-10-30 6:12 ` Denis Kirjanov
2014-10-30 20:32 ` Alexei Starovoitov
2014-10-30 20:32 ` Alexei Starovoitov
2014-10-31 6:09 ` Denis Kirjanov
2014-10-31 6:09 ` Denis Kirjanov
2014-11-01 16:19 ` Denis Kirjanov
2014-11-01 16:19 ` Denis Kirjanov
2014-11-01 17:39 ` David Miller
2014-11-01 17:39 ` David Miller
2014-11-01 17:49 ` Denis Kirjanov
2014-11-01 17:49 ` Denis Kirjanov
2014-11-01 18:00 ` David Miller
2014-11-01 18:00 ` David Miller
2014-11-01 18:31 ` Daniel Borkmann
2014-11-01 18:31 ` Daniel Borkmann
2014-11-01 18:40 ` Daniel Borkmann [this message]
2014-11-01 18:40 ` Daniel Borkmann
2014-11-03 17:06 ` David Miller
2014-11-03 17:06 ` David Miller
2014-11-03 17:21 ` Alexei Starovoitov
2014-11-03 17:21 ` Alexei Starovoitov
2014-11-03 20:29 ` David Miller
2014-11-03 20:29 ` David Miller
2014-11-03 23:43 ` Michael Ellerman
2014-11-03 23:43 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54552926.1020504@redhat.com \
--to=dborkman@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=kda@linux-powerpc.org \
--cc=kirjanov@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=matt@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.