From: Gonglei <arei.gonglei@huawei.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"Huangpeng \(Peter\)" <peter.huangpeng@huawei.com>
Subject: Re: [Qemu-trivial] [PATCH] tap_int.h: remove repeating macroinstruction
Date: Sun, 2 Nov 2014 13:01:19 +0800 [thread overview]
Message-ID: <5455BA9F.1040807@huawei.com> (raw)
In-Reply-To: <5455B961.7080303@msgid.tls.msk.ru>
On 2014/11/2 12:56, Michael Tokarev wrote:
> 31.10.2014 05:53, arei.gonglei@huawei.com wrote:
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> DEFAULT_NETWORK_SCRIPT and DEFAULT_NETWORK_DOWN_SCRIPT
>> have been defined in net/net.h included in
>> tap.c, which is the only C file that using those two macro.
>> Let's remove the repeating macroinstruction.
>
> Applied (as I noted yesterday), but with slight rename in
> $subject - the new subject reads:
>
> tap_int.h: remove repeating NETWORK_SCRIPT defines
>
> Is that okay with you?
>
Ack. Thanks.
Best regards,
-Gonglei
WARNING: multiple messages have this Message-ID (diff)
From: Gonglei <arei.gonglei@huawei.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"Huangpeng (Peter)" <peter.huangpeng@huawei.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] tap_int.h: remove repeating macroinstruction
Date: Sun, 2 Nov 2014 13:01:19 +0800 [thread overview]
Message-ID: <5455BA9F.1040807@huawei.com> (raw)
In-Reply-To: <5455B961.7080303@msgid.tls.msk.ru>
On 2014/11/2 12:56, Michael Tokarev wrote:
> 31.10.2014 05:53, arei.gonglei@huawei.com wrote:
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> DEFAULT_NETWORK_SCRIPT and DEFAULT_NETWORK_DOWN_SCRIPT
>> have been defined in net/net.h included in
>> tap.c, which is the only C file that using those two macro.
>> Let's remove the repeating macroinstruction.
>
> Applied (as I noted yesterday), but with slight rename in
> $subject - the new subject reads:
>
> tap_int.h: remove repeating NETWORK_SCRIPT defines
>
> Is that okay with you?
>
Ack. Thanks.
Best regards,
-Gonglei
next prev parent reply other threads:[~2014-11-02 5:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 2:53 [Qemu-trivial] [PATCH] tap_int.h: remove repeating macroinstruction arei.gonglei
2014-10-31 2:53 ` [Qemu-devel] " arei.gonglei
2014-11-01 18:10 ` [Qemu-trivial] " Michael Tokarev
2014-11-01 18:10 ` [Qemu-devel] " Michael Tokarev
2014-11-01 18:10 ` Michael Tokarev
2014-11-01 18:10 ` [Qemu-devel] " Michael Tokarev
2014-11-02 4:56 ` Michael Tokarev
2014-11-02 4:56 ` [Qemu-devel] " Michael Tokarev
2014-11-02 5:01 ` Gonglei [this message]
2014-11-02 5:01 ` Gonglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5455BA9F.1040807@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=mjt@tls.msk.ru \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.