From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/17] bus: mvebu-mbus: provide a mechanism to save SDRAM window configuration
Date: Tue, 04 Nov 2014 10:17:52 +0100 [thread overview]
Message-ID: <545899C0.9030301@free-electrons.com> (raw)
In-Reply-To: <1414151970-6626-9-git-send-email-thomas.petazzoni@free-electrons.com>
Hi Thomas,
On 24/10/2014 13:59, Thomas Petazzoni wrote:
> On Marvell EBU platforms, when doing suspend/resume, the SDRAM window
> configuration must be saved on suspend, and restored on
> resume. However, it needs to be restored on resume *before*
> re-entering the kernel, because the SDRAM window configuration defines
> the layout of the memory. For this reason, it cannot simply be done in
> the ->suspend() and ->resume() hooks of the mvebu-mbus driver.
>
> Instead, it needs to be restored by the bootloader "boot info"
> mechanism used when resuming. This mechanism allows the kernel to
> define a list of (address, value) pairs when suspending, that the
> bootloader will restore on resume before jumping back into the kernel.
>
> This commit therefore adds a new function to the mvebu-mbus driver,
> called mvebu_mbus_save_cpu_target(), which will be called by the
> platform code to make the mvebu-mbus driver save the SDRAM window
> configuration in a way that can be understood by the bootloader "boot
> info" mechanism.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> drivers/bus/mvebu-mbus.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++
> include/linux/mbus.h | 1 +
> 2 files changed, 57 insertions(+)
Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Thanks,
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Tawfik Bayouk <tawfik-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Nadav Haklai <nadavh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Ezequiel Garcia
<ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 08/17] bus: mvebu-mbus: provide a mechanism to save SDRAM window configuration
Date: Tue, 04 Nov 2014 10:17:52 +0100 [thread overview]
Message-ID: <545899C0.9030301@free-electrons.com> (raw)
In-Reply-To: <1414151970-6626-9-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Hi Thomas,
On 24/10/2014 13:59, Thomas Petazzoni wrote:
> On Marvell EBU platforms, when doing suspend/resume, the SDRAM window
> configuration must be saved on suspend, and restored on
> resume. However, it needs to be restored on resume *before*
> re-entering the kernel, because the SDRAM window configuration defines
> the layout of the memory. For this reason, it cannot simply be done in
> the ->suspend() and ->resume() hooks of the mvebu-mbus driver.
>
> Instead, it needs to be restored by the bootloader "boot info"
> mechanism used when resuming. This mechanism allows the kernel to
> define a list of (address, value) pairs when suspending, that the
> bootloader will restore on resume before jumping back into the kernel.
>
> This commit therefore adds a new function to the mvebu-mbus driver,
> called mvebu_mbus_save_cpu_target(), which will be called by the
> platform code to make the mvebu-mbus driver save the SDRAM window
> configuration in a way that can be understood by the bootloader "boot
> info" mechanism.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> ---
> drivers/bus/mvebu-mbus.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++
> include/linux/mbus.h | 1 +
> 2 files changed, 57 insertions(+)
Reviewed-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Thanks,
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-04 9:17 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 11:59 [PATCH 00/17] Suspend to RAM support for Armada XP Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-10-24 11:59 ` [PATCH 01/17] Documentation: dt-bindings: minimal documentation for MVEBU SDRAM controller Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-11-03 17:05 ` Gregory CLEMENT
2014-11-03 17:05 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 02/17] ARM: mvebu: enable strex backoff delay Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-11-03 17:08 ` Gregory CLEMENT
2014-11-03 17:08 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 03/17] irqchip: irq-armada-370-xp: use proper return value for ->set_affinity() Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-11-03 17:20 ` Gregory CLEMENT
2014-11-03 17:20 ` Gregory CLEMENT
2014-11-07 4:09 ` Jason Cooper
2014-11-07 4:09 ` Jason Cooper
2014-11-07 4:09 ` Jason Cooper
2014-10-24 11:59 ` [PATCH 04/17] irqchip: irq-armada-370-xp: suspend/resume support Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-11-03 17:38 ` Gregory CLEMENT
2014-11-03 17:38 ` Gregory CLEMENT
2014-11-13 16:32 ` Thomas Petazzoni
2014-11-13 16:32 ` Thomas Petazzoni
2014-10-24 11:59 ` [PATCH 05/17] clocksource: time-armada-370-xp: add " Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-11-03 17:45 ` Gregory CLEMENT
2014-11-03 17:45 ` Gregory CLEMENT
2014-11-03 17:45 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 06/17] gpio: mvebu: " Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-10-24 16:30 ` David Cohen
2014-10-24 16:30 ` David Cohen
2014-10-24 20:45 ` Andrew Lunn
2014-10-24 20:45 ` Andrew Lunn
2014-10-27 5:27 ` Alexandre Courbot
2014-10-27 5:27 ` Alexandre Courbot
2014-10-27 17:45 ` David Cohen
2014-10-27 17:45 ` David Cohen
2014-10-31 7:00 ` Linus Walleij
2014-10-31 7:00 ` Linus Walleij
2014-10-31 7:52 ` Gregory CLEMENT
2014-10-31 7:52 ` Gregory CLEMENT
2014-10-31 8:14 ` Thomas Petazzoni
2014-10-31 8:14 ` Thomas Petazzoni
2014-11-03 13:26 ` Linus Walleij
2014-11-03 13:26 ` Linus Walleij
2014-11-03 13:29 ` Linus Walleij
2014-11-03 13:29 ` Linus Walleij
2014-11-03 17:53 ` Gregory CLEMENT
2014-11-03 17:53 ` Gregory CLEMENT
2014-11-03 21:21 ` Thomas Petazzoni
2014-11-03 21:21 ` Thomas Petazzoni
2014-10-24 11:59 ` [PATCH 07/17] bus: mvebu-mbus: " Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-11-03 18:08 ` Gregory CLEMENT
2014-11-03 18:08 ` Gregory CLEMENT
2014-11-03 21:20 ` Thomas Petazzoni
2014-11-03 21:20 ` Thomas Petazzoni
2014-10-24 11:59 ` [PATCH 08/17] bus: mvebu-mbus: provide a mechanism to save SDRAM window configuration Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-11-04 9:17 ` Gregory CLEMENT [this message]
2014-11-04 9:17 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 09/17] clk: mvebu: add suspend/resume for gatable clocks Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-11-04 9:32 ` Gregory CLEMENT
2014-11-04 9:32 ` Gregory CLEMENT
2014-11-04 9:32 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 10/17] ARM: mvebu: implement suspend/resume support for Armada XP Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-11-04 10:00 ` Gregory CLEMENT
2014-11-04 10:00 ` Gregory CLEMENT
2014-11-13 17:00 ` Thomas Petazzoni
2014-11-13 17:00 ` Thomas Petazzoni
2014-10-24 11:59 ` [PATCH 11/17] ARM: mvebu: reserve the first 10 KB of each memory bank for suspend/resume Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-11-04 10:09 ` Gregory CLEMENT
2014-11-04 10:09 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 12/17] ARM: mvebu: Armada XP GP specific suspend/resume code Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-10-24 14:20 ` Andrew Lunn
2014-10-24 14:20 ` Andrew Lunn
2014-10-24 14:28 ` Thomas Petazzoni
2014-10-24 14:28 ` Thomas Petazzoni
2014-10-24 14:51 ` Andrew Lunn
2014-10-24 14:51 ` Andrew Lunn
2014-10-27 12:51 ` Thomas Petazzoni
2014-10-27 12:51 ` Thomas Petazzoni
2014-10-27 14:19 ` Andrew Lunn
2014-10-27 14:19 ` Andrew Lunn
2014-10-27 14:40 ` Thomas Petazzoni
2014-10-27 14:40 ` Thomas Petazzoni
2014-10-27 14:59 ` Andrew Lunn
2014-10-27 14:59 ` Andrew Lunn
2014-10-27 15:12 ` Thomas Petazzoni
2014-10-27 15:12 ` Thomas Petazzoni
2014-10-27 15:15 ` Andrew Lunn
2014-10-27 15:15 ` Andrew Lunn
2014-11-10 13:53 ` Gregory CLEMENT
2014-11-10 13:53 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 13/17] ARM: mvebu: make sure MMU is disabled in armada_370_xp_cpu_resume Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-11-10 14:05 ` Gregory CLEMENT
2014-11-10 14:05 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 14/17] ARM: mvebu: synchronize secondary CPU clocks on resume Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-11-10 14:12 ` Gregory CLEMENT
2014-11-10 14:12 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 15/17] ARM: mvebu: add suspend/resume DT information for Armada XP GP Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-11-10 14:14 ` Gregory CLEMENT
2014-11-10 14:14 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 16/17] ARM: mvebu: adjust mbus controller description on Armada 370/XP Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-11-10 14:15 ` Gregory CLEMENT
2014-11-10 14:15 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 17/17] ARM: mvebu: add SDRAM controller description for Armada XP Thomas Petazzoni
2014-10-24 11:59 ` Thomas Petazzoni
2014-11-10 14:25 ` Gregory CLEMENT
2014-11-10 14:25 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545899C0.9030301@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.