From: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
To: Andy Yan <andy.yan@rock-chips.com>,
airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com,
rmk+kernel@arm.linux.org.uk
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>, Josh Boyer <jwboyer@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Inki Dae <inki.dae@samsung.com>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Sean Paul <seanpaul@chromium.org>,
djkurtz@google.com, Philipp Zabel <p.zabel@pengutronix.de>,
ykk@rock-chips.com, Grant Likely <grant.likely@linaro.org>,
Dave Airlie <airlied@redhat.com>,
Shawn Guo <shawn.guo@linaro.org>,
jay.xu@rock-chips.com, Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH v7 6/7] drm: bridge/dw-hdmi: convert dw-hdmi to drm_bridge mode
Date: Tue, 11 Nov 2014 14:36:39 +0000 [thread overview]
Message-ID: <54621EF7.4000300@imgtec.com> (raw)
In-Reply-To: <1415710469-12213-1-git-send-email-andy.yan@rock-chips.com>
Hi Andy,
On 11/11/14 12:54, Andy Yan wrote:
> From: Yakir Yang <ykk@rock-chips.com>
>
> keep the connector & birdge in dw_hdmi.c, handle encoder in dw_hdmi-imx.c
Is there a reason for this separation? Keeping encoder in platform files?
If yes, then the commit message should explain that.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>
> ---
>
> Changes in v7: None
> Changes in v6:
> - move some modification from patch#5
>
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
> drivers/gpu/drm/bridge/dw_hdmi.c | 228 +++++++++++++++-------------------
> drivers/staging/imx-drm/dw_hdmi-imx.c | 145 ++++++++++++++-------
> include/drm/bridge/dw_hdmi.h | 13 +-
> 3 files changed, 199 insertions(+), 187 deletions(-)
Regards
ZubairLK
WARNING: multiple messages have this Message-ID (diff)
From: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
To: Andy Yan <andy.yan@rock-chips.com>, <airlied@linux.ie>,
<heiko@sntech.de>, <fabio.estevam@freescale.com>,
<rmk+kernel@arm.linux.org.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>, Josh Boyer <jwboyer@redhat.com>,
Sean Paul <seanpaul@chromium.org>,
Inki Dae <inki.dae@samsung.com>, Dave Airlie <airlied@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
Lucas Stach <l.stach@pengutronix.de>, <djkurtz@google.com>,
<ykk@rock-chips.com>, <linux-kernel@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>, <devel@driverdev.osuosl.org>,
<devicetree@vger.kernel.org>,
<linux-rockchip@lists.infradead.org>, <jay.xu@rock-chips.com>
Subject: Re: [PATCH v7 6/7] drm: bridge/dw-hdmi: convert dw-hdmi to drm_bridge mode
Date: Tue, 11 Nov 2014 14:36:39 +0000 [thread overview]
Message-ID: <54621EF7.4000300@imgtec.com> (raw)
In-Reply-To: <1415710469-12213-1-git-send-email-andy.yan@rock-chips.com>
Hi Andy,
On 11/11/14 12:54, Andy Yan wrote:
> From: Yakir Yang <ykk@rock-chips.com>
>
> keep the connector & birdge in dw_hdmi.c, handle encoder in dw_hdmi-imx.c
Is there a reason for this separation? Keeping encoder in platform files?
If yes, then the commit message should explain that.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>
> ---
>
> Changes in v7: None
> Changes in v6:
> - move some modification from patch#5
>
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
> drivers/gpu/drm/bridge/dw_hdmi.c | 228 +++++++++++++++-------------------
> drivers/staging/imx-drm/dw_hdmi-imx.c | 145 ++++++++++++++-------
> include/drm/bridge/dw_hdmi.h | 13 +-
> 3 files changed, 199 insertions(+), 187 deletions(-)
Regards
ZubairLK
next prev parent reply other threads:[~2014-11-11 14:36 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 12:48 [PATCH v7 0/7] dw-hdmi: convert imx hdmi to bridge/dw-hdmi Andy Yan
2014-11-11 12:48 ` Andy Yan
[not found] ` <1415710124-11887-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-11-11 12:50 ` [PATCH v7 1/7] staging: imx-drm: imx-hdmi: make checkpatch happy Andy Yan
2014-11-11 12:50 ` Andy Yan
[not found] ` <1415710229-11935-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-11-11 12:51 ` [PATCH v7 2/7] staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter Andy Yan
2014-11-11 12:51 ` Andy Yan
2014-11-11 12:52 ` [PATCH v7 3/7] staging: imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi Andy Yan
2014-11-11 12:52 ` Andy Yan
2014-11-11 12:53 ` [PATCH v7 4/7] staging: imx-drm: imx-hdmi: move imx-hdmi to bridge/dw-hdmi Andy Yan
2014-11-11 12:53 ` Andy Yan
2014-11-11 14:16 ` Zubair Lutfullah Kakakhel
2014-11-11 14:16 ` Zubair Lutfullah Kakakhel
[not found] ` <54621A3D.9090406-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2014-11-11 14:41 ` Andy Yan
2014-11-11 14:41 ` Andy Yan
2014-11-11 12:53 ` [PATCH v7 5/7] drm: bridge/dw-hdmi: add support for multi byte register width access Andy Yan
2014-11-11 12:53 ` Andy Yan
2014-11-11 14:20 ` Zubair Lutfullah Kakakhel
2014-11-11 14:20 ` Zubair Lutfullah Kakakhel
2014-11-11 14:23 ` Lucas Stach
2014-11-11 14:23 ` Lucas Stach
2014-11-11 14:37 ` Zubair Lutfullah Kakakhel
2014-11-11 14:37 ` Zubair Lutfullah Kakakhel
2014-11-11 14:46 ` Andy Yan
2014-11-11 14:46 ` Andy Yan
2014-11-11 14:48 ` Zubair Lutfullah Kakakhel
2014-11-11 14:48 ` Zubair Lutfullah Kakakhel
2014-11-11 12:54 ` [PATCH v7 6/7] drm: bridge/dw-hdmi: convert dw-hdmi to drm_bridge mode Andy Yan
2014-11-11 12:54 ` Andy Yan
2014-11-11 14:36 ` Zubair Lutfullah Kakakhel [this message]
2014-11-11 14:36 ` Zubair Lutfullah Kakakhel
2014-11-11 14:50 ` Andy Yan
2014-11-11 14:50 ` Andy Yan
2014-11-11 12:54 ` [PATCH v7 7/7] dt-bindings: add document for dw-hdmi Andy Yan
2014-11-11 12:54 ` Andy Yan
2014-11-11 14:40 ` Zubair Lutfullah Kakakhel
2014-11-11 14:40 ` Zubair Lutfullah Kakakhel
2014-11-11 14:53 ` Andy Yan
2014-11-11 14:53 ` Andy Yan
-- strict thread matches above, loose matches on Subject: below --
2014-11-11 12:12 [PATCH v7 0/7] dw-hdmi: convert imx hdmi to bridge/dw-hdmi Andy Yan
2014-11-11 12:12 ` [PATCH v7 6/7] drm: bridge/dw-hdmi: convert dw-hdmi to drm_bridge mode Andy Yan
2014-11-11 12:12 ` Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54621EF7.4000300@imgtec.com \
--to=zubair.kakakhel@imgtec.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=andy.yan@rock-chips.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=inki.dae@samsung.com \
--cc=jay.xu@rock-chips.com \
--cc=jwboyer@redhat.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
--cc=shawn.guo@linaro.org \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.